Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp481914rdh; Thu, 23 Nov 2023 09:04:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHigH8erXvGSDbX9qCKtIhEm466AcxwRh65lSygh3paiJpEBD+BcVUl0E4+ZqESnPDyAyV6 X-Received: by 2002:a05:6a00:1742:b0:6cb:b7b5:389f with SMTP id j2-20020a056a00174200b006cbb7b5389fmr114140pfc.6.1700759082687; Thu, 23 Nov 2023 09:04:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700759082; cv=none; d=google.com; s=arc-20160816; b=jnr3OgRkFd9QdKQPBIYfPtGu8Qu+ljW9ux7uwrFQb6R1RI0LU9NYvDOU0vIwJKxYl9 sottPUpMlVpouYr5YB6glBdzXiVLp0a5O96nEhNeFgdbTsnaxGjiV0B1qMRUe01RjMzO e/eL0lYGmzKlTXfQCJMvXPrpeEOPbMv4mORHvT84GuJE6yyFjR0/Mvqra5do8az6nf4V kAz03DA5Es6KtGorthQ0NluxSp7CHy0eCkEPXzI6xFbXJ0V33ixHMVsubkBC8DJCkI8b j8R6LQ/E1Coce5sZiKEI9pjrj2ZVYc1Qb+dIoYNaEtdmGUD3ESf5/CUPejYu5oEP3Mbn oTkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:dkim-signature; bh=qbMWppXTD+nsdKUOaZh98FtIc9qszLByxh/ACBMNxDw=; fh=Ru3ezFmCiDylmB6dthpXFWIEu1jRJIbfE0qpxQJ/2R4=; b=0CBnlqJPbaZw11/OAOu0GXgPYfyUx5wQhN563dK6SVeAbbkytxRclBYjcSqQ4KfqR8 jpXzuy0vLkhwOvDOdP2yTQQD03Ue7ulhKIcg2EVPK3JOl1+YTQtJQgfxgHz0ZdoXI6kM qARTYJxrUWwaWlYq6XbP23EXFfHj8qlXKMUGHNYtNXde+ScLNRslQnhwnu98geI7FiVL Hku7Yv6aDK4RnYRHyoXPTgOOC9vlJqyLuysHSdYGhESTi4D+09X/eH61QCzmPGi8PWuH kpuvfuS2BtdPiNMmaUjBMsJpYuNe/FrturU3fsO6kDoBREUTQKbXwFYwTL2dUgo6lmed Pg2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=fAJJH+EQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id k20-20020a056a00135400b006cb8d6e9458si1649256pfu.79.2023.11.23.09.04.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 09:04:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=fAJJH+EQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 268D18053642; Thu, 23 Nov 2023 09:04:40 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235191AbjKWREV (ORCPT + 99 others); Thu, 23 Nov 2023 12:04:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232995AbjKWREL (ORCPT ); Thu, 23 Nov 2023 12:04:11 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F011210C; Thu, 23 Nov 2023 09:03:52 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1cc5fa0e4d5so8583725ad.0; Thu, 23 Nov 2023 09:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700759032; x=1701363832; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=qbMWppXTD+nsdKUOaZh98FtIc9qszLByxh/ACBMNxDw=; b=fAJJH+EQvYBKs7Dn4R4bvhQUX9TWDvaxT5dBRqdjl32CVzKjyCU3fmUCxGx6TmJX0j M2xWY4Vw2w92RWfevjppRO6I0rnTusCKZ9zo2FdQLj8yzh3PyUgyBy+ar2x9XLEOWly2 C4olphsgKpyWnl7KviQmfqFZYP0CmsifkQTnBlzQroQp1PuzBlk203Z2dPs0ScFkv5r+ Wg8S0JdtdN00wIzVYBQhRcgu110hlfO+Zn4WPpVbUGz1YeXRfmhtdtXHOtHP/6XoKJwY 5r9nghGIJxYNuRKMB/TUykCROrRuEIb7OEvn3Yi0UHj1rjPSx2jzB6MwJnHjy5N2j8/k 0C3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700759032; x=1701363832; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qbMWppXTD+nsdKUOaZh98FtIc9qszLByxh/ACBMNxDw=; b=LHQMoFJai+A+v3z00CmBqu9klkXds/AluO37/QaGzfNvVtl0ckjWyE/JZDtfjekthp NyMuKqgfrJri7cs0jSnJ8KVRah61ABQvD6ooHlgpMUm3ZGTf+zjwhg0zQJnpXG5h1ck6 /fK46NFwQPkIG+ASLJUx0fCZOFpz/RfKh1I9draTp3LnRPMZ/jkFu2ywPca4NqdOyj+G l2Ca+8UTeFvI1grtvP64mo8OecOIEvwE5oGqtlYShLocHy3Fa65AALq3Hp9Lso70eE++ 9ijeV3H+Ouwt2btUa0t3D3cSoGaiFdgtI7pdETWCoqjKIa88JGymuCOQS/eaxtpAkrbv 5wRA== X-Gm-Message-State: AOJu0Yw7ry9l/cyPSJi7WKQpEMWFHklFd4ZWgC48K0z3/Aj05nLCZj47 RiMfhYeBz1m8lQwb1VjWdRbUmCcOMgkeuQr8hT0= X-Received: by 2002:a17:902:7483:b0:1cf:7df0:667f with SMTP id h3-20020a170902748300b001cf7df0667fmr92476pll.44.1700759031716; Thu, 23 Nov 2023 09:03:51 -0800 (PST) Received: from [172.24.5.154] ([119.8.44.69]) by smtp.gmail.com with ESMTPSA id s17-20020a170902c65100b001cc8cf4ad14sm1583799pls.142.2023.11.23.09.03.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 09:03:50 -0800 (PST) From: Asuna Yang X-Google-Original-From: Asuna Yang Message-ID: <921fc036-7ebb-43cf-b4a3-de7a7c993bbf@gmail.com> Date: Fri, 24 Nov 2023 01:03:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] USB: serial: option: add Luat Air72*U series products To: Johan Hovold Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Yangyu Chen References: <20231122141803.82844-1-SpriteOvO@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 09:04:40 -0800 (PST) If#= 2: AT If#= 3: PPP + AT If#= 4: Debug Reference from the device documentation: https://doc.openluat.com/wiki/21?wiki_page_id=2501 Should I send a v3 to include the serial interfaces information in the git message? This is my first time sending a patch to the kernel, please forgive me for not being particularly sure of the process. Thanks, On 11/23/23 20:11, Johan Hovold wrote: > On Wed, Nov 22, 2023 at 10:18:03PM +0800, Asuna Yang wrote: >> Update the USB serial option driver support for Luat Air72*U series >> products. >> >> ID 1782:4e00 Spreadtrum Communications Inc. UNISOC-8910 >> >> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 13 Spd=480 MxCh= 0 >> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 >> P: Vendor=1782 ProdID=4e00 Rev=00.00 >> S: Manufacturer=UNISOC >> S: Product=UNISOC-8910 >> C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=400mA >> I: If#= 0 Alt= 0 #EPs= 1 Cls=e0(wlcon) Sub=01 Prot=03 Driver=rndis_host >> E: Ad=82(I) Atr=03(Int.) MxPS= 8 Ivl=4096ms >> I: If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=rndis_host >> E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option >> E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> I: If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option >> E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> I: If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option >> E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> >> Co-developed-by: Yangyu Chen >> Signed-off-by: Yangyu Chen >> Signed-off-by: Asuna Yang > Thanks for the v2. > > Can you say something about what the three serial interfaces are used > for (and which is which)? > > Johan