Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp545184rdh; Thu, 23 Nov 2023 10:58:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IFQYagxfyaDay7pxbg7kuIBOkizt20NN4kWds6Fk1il+27UNc56MjSbdPQpEe8ibh7bLxUx X-Received: by 2002:a05:6a20:d704:b0:18b:3297:3e1a with SMTP id iz4-20020a056a20d70400b0018b32973e1amr613215pzb.47.1700765923746; Thu, 23 Nov 2023 10:58:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700765923; cv=none; d=google.com; s=arc-20160816; b=Egmmx3kssW1van7yn14XkwRQv71cqet1gy1PdGAEeJ5YRYxC2hHG/J38d7bRj1LcD2 MJ2VpZQXllILK2RCbnEAoOEtMBctcmmfYsEiuLcOKJWCN3zPLKIwgHNNfj8f1lDl6NRx /qknLaQzwCEwoa2Hf/HoMz3GL11OmyphQ8+Qp+rcYdrf3gRAvZZSJx3BrijbaBIIwaio 0mYwGVQktr1DQHp6gBdLvb7UUAHiNV3hel8biZF5QiJPVBNT5ivyAQtKSgOHGQL6llme b7+PnGkUk6CRJE+X0RFRxdjQfUx9rwHcmfcNhruATZY7kqBunWi4QlsEWahvYE7m8ufN NIpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5vDWv3+Vdh2C5jUQTfnkwEb2P2xKkS0YYp9hl8KNogA=; fh=777fnGPFCklgku7miEvMi+H6COSNgqVCQUL/O3yYryM=; b=IiSOrHcekNSrAzJmkutNYYfq2k+RZdmrlitcgTqSI1yspQ/CphxpWNjFBIgBrn/ssr MC9iVIGr6Tnzlb21LTI+HKgTqIfM2mm20YDKRvceBw4hiUzIFAU6CAuTRijvGbkL/1C6 eTEfxPzQsajgmVWs6OwTGHaYwEfUTUogCyrfXqloMqfOubcxIuUuq4/EwjwzptrzVELy oMkQc1yQibZRThP4N+P5LbT8KAipchhBbx7vmynuCVix0/3D874xjFbosuM2HtxWutNO FevOLnYxgJSKI8HG4Xz8SiMuLfQPwdbIvC0BiPXHzRfO5eIM736dbhjzyvQrhq//vX6+ 05jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=okzPD7pF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id nd5-20020a17090b4cc500b0027cfd2636casi2502306pjb.0.2023.11.23.10.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 10:58:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=okzPD7pF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id BDF3380A1466; Thu, 23 Nov 2023 10:58:39 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229866AbjKWS5g (ORCPT + 99 others); Thu, 23 Nov 2023 13:57:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjKWS5f (ORCPT ); Thu, 23 Nov 2023 13:57:35 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC7651B3; Thu, 23 Nov 2023 10:57:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=5vDWv3+Vdh2C5jUQTfnkwEb2P2xKkS0YYp9hl8KNogA=; b=okzPD7pF3pX0HtAh0a91/IV1ch J+YSpnJliSZC9AcfeEH3PVD+WQaFZOx9wcgMx0TuAavOW8b3OtZFg2PfnOyKnP2A+/elri5Scewdk h1UYqKEyG1o95yovTg5hLwHHsQlvR6KCVl4wvqvDFnPS0YgCisOZZJg/c4zcH82apVkU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1r6Et5-0011Wu-6z; Thu, 23 Nov 2023 19:57:19 +0100 Date: Thu, 23 Nov 2023 19:57:19 +0100 From: Andrew Lunn To: Furong Xu <0x1207@gmail.com> Cc: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , Simon Horman , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com Subject: Re: [PATCH net v1] net: stmmac: xgmac: Disable FPE MMC interrupts Message-ID: <338001dd-f4d2-46d8-b247-fca1684a0f3e@lunn.ch> References: <20231123093538.2216633-1-0x1207@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231123093538.2216633-1-0x1207@gmail.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 23 Nov 2023 10:58:40 -0800 (PST) On Thu, Nov 23, 2023 at 05:35:38PM +0800, Furong Xu wrote: > Commit aeb18dd07692 ("net: stmmac: xgmac: Disable MMC interrupts > by default") leaves the FPE(Frame Preemption) MMC interrupts enabled. > Now we disable FPE TX and RX interrupts too. Just adding to Wojciech reply. We should be able to see 'What' a patch does by reading the actual change. What is not always obvious is 'Why?' The commit message should be about the 'Why?", and less about the 'What'. Andrew