Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp577423rdh; Thu, 23 Nov 2023 12:02:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IFcCmZ78ixtCG1zl89/srrDEd9GSnfNhy662N5PiuupaHGEQ+BdLh+u/CTXmL7IJajdEyoL X-Received: by 2002:a05:6a00:4396:b0:6cb:84d0:d003 with SMTP id bt22-20020a056a00439600b006cb84d0d003mr560065pfb.23.1700769755897; Thu, 23 Nov 2023 12:02:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700769755; cv=none; d=google.com; s=arc-20160816; b=R3k37r5h0oE23QsV26dBmVem9YLXCaxBMBtWjahAspEMr8yBvS5Ow4ah2PWr3Mv3K/ aJthRjjJMztLYhv5XLdFTPRzBMksSOW2vx34xhetTo/7QEuLEeJsRQYZpApfsrxVoqG/ Feq+4s5xT9vYXZ4P956565VXQfZt7YvZ4c+5gesMcS6ik/VBamzzW89qr/WTSe7EthZ4 n/tDyzRyZZGFuXv4v7xd2rrYIalGMq5TiTj8+V31OUoZs4lwA7K5Ib7uu4AzBFtsxEGX Y/RbmZdlyj0DE03rg32x2JfPYsUYTv1m/XktpXXpdIaIOf+gZZB3jSFcgoilDsMdI8Mp 34sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vvGpKeVBKct7mdmTRc3KhUoKAd20inhURZrMxjX4/5E=; fh=xoaxwifE1FxYtnerj0WyteU+IiY5CWPHKDErLUvEGCU=; b=r88IGgpIKPVymPlUmz3s4bUNQrr9K3NtVu9pQ3IFFuS1L4nlLlRHTrlM7PYIy3QZSi udryj80CeMuPWVEWYQyzMYVNQ6BNAa+Imj2GiDaT+LB96xlcrpIUzMnV3CVQaSWSLmm4 kxCuXn7Igcexk63ylqtNBtikuzNYUES7nrNYhbiJJo7UAOIsI8aZ8SF73G5qwhziDKoX HNXoRktIoWys8nVA1finsjc0XbDhA1uR8D1/vBsdYq6P4MpUR8XegPH2+AIlsy6J0yF0 2zH1WnhtLyDOlbiymwgzYb6HacIARCLgEXSBd7hWaTUVgecFbiuWaLjz3CjPWVY31sRF Ozjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=V0qjOBP1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id l65-20020a632544000000b005b8f38f9975si1869310pgl.751.2023.11.23.12.02.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 12:02:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=V0qjOBP1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id C160B805F2D4; Thu, 23 Nov 2023 12:02:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229687AbjKWUCJ (ORCPT + 99 others); Thu, 23 Nov 2023 15:02:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjKWUCI (ORCPT ); Thu, 23 Nov 2023 15:02:08 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DDD4B0; Thu, 23 Nov 2023 12:02:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=vvGpKeVBKct7mdmTRc3KhUoKAd20inhURZrMxjX4/5E=; b=V0qjOBP1Ij+ha4/POp+VZeQR// UdKuun1a7BjxgkPtpTT0nsDtpZ2UK+2ls8JYdZdIr/RBhKBgCU8XTotvz1jZs5vQd+D7itwEzW5Wk hTg7DwCY4w/jTODhGDoKlzb9uLZIWldL8VJ32CJzcFd62+63feQBO4Org7+ZzrZQCTJw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1r6Ftk-0011vP-30; Thu, 23 Nov 2023 21:02:04 +0100 Date: Thu, 23 Nov 2023 21:02:04 +0100 From: Andrew Lunn To: Suraj Jaiswal Cc: Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Torgue , Jose Abreu , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Prasad Sodagudi , Andrew Halaney , kernel@quicinc.com Subject: Re: [PATCH net-next v3 3/3] net: stmmac: Add driver support for DWMAC5 fault IRQ Support Message-ID: References: <62eaaace3713751cb1ecac3163e857737107ca0e.1700737841.git.quic_jsuraj@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62eaaace3713751cb1ecac3163e857737107ca0e.1700737841.git.quic_jsuraj@quicinc.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 23 Nov 2023 12:02:28 -0800 (PST) > @@ -702,6 +718,10 @@ int stmmac_get_platform_resources(struct platform_device *pdev, > if (stmmac_res->irq < 0) > return stmmac_res->irq; > > + ret = stmmac_get_fault_intr_config(pdev, stmmac_res); > + if (ret) > + dev_err(&pdev->dev, "Fault interrupt not present\n"); This fault/saftey/foobar interrupt is optional? So printing any error message it is missing does not seem like a good idea. Andrew