Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <0cee5543-711d-3d6e-f416-18889badff18@axentia.se>
Date:   Fri, 24 Nov 2023 00:10:53 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH 05/10] drivers/i2c/busses: Don't let i2c adapters declare
 I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
Content-Language: sv-SE
To:     Heiner Kallweit <hkallweit1@gmail.com>,
        Wolfram Sang <wsa@kernel.org>,
        Andi Shyti <andi.shyti@kernel.org>
Cc:     linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231118180504.1785-1-hkallweit1@gmail.com>
 <20231118180504.1785-6-hkallweit1@gmail.com>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <20231118180504.1785-6-hkallweit1@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTV3S2VTOVZ0cjFEUFlpYi9tLys0dzlUcWEyTXNJdFpjRTFXczF5SzRGRmNL?=
 =?utf-8?B?UjBIbkxYZmt0d1JjVXljTkpwWEw0bG5yZS92ZndPeG1MVUFYcVlUaS81TldU?=
 =?utf-8?B?NlpZMnVHK0dETUhkTjFVSzlLaU44R255SHhqSHAxSW9mZGswK05KVnBnUi91?=
 =?utf-8?B?YUQxOHh2NGxUSWxtR2lhNEFpcUp3VzBFa0gzWTE1ZUZtczhhdldhbzRXRDRt?=
 =?utf-8?B?RjgrK1BqMnl5dDBIcngxcU1TTzBSSkE3eDFSemM1UUY3VElkejNrbXpOMzdl?=
 =?utf-8?B?ZHhsbzlYb1JwTDdzS2R5eHNzRUhGUGpYY2tmSFdhMDE0Yy9FNjhSRVMxUTRT?=
 =?utf-8?B?QlZ0YXZCcWczZ2J0dHNXM3kzYnRnT2JXMHkwREpRbUxSMC9CZXYybURURnBZ?=
 =?utf-8?B?TzhxRTBHQ0hXZjcwd1c2bElyTXBBTERTOUtvbXMvMEtZaFJXM1JkSlBxWUFk?=
 =?utf-8?B?WXI5MXBsaVdzQ09wVWRWcGMvWVoxcitvK0xBUVI3ckFxV2gyYkpmT3poY25T?=
 =?utf-8?B?NXlXMkFhZFdJNzVIci80bko4ZFNKWHlTbHNTVG85bXR1U0NiTFZoQTBISW5h?=
 =?utf-8?B?VHJyaHV3T01YTm5wNlNhQ25zeE1kdUpyNFhXZlZncmNNWXRiMGNMODJkMmxv?=
 =?utf-8?B?RnVjZEFhSG1VT1pIaTNTdDFGcmpQWHhOM25jNldlc2xJMTRQVUFFVytKeFAr?=
 =?utf-8?B?SCtJbHJmMEkxSFlieG01dWF1Tm9kWVk4L0ZCcSt6VUpaOVVuUmhiSGxGbTN0?=
 =?utf-8?B?ckpsd0RZRTNmTVQrTUhKRGhtU0laVVhEK0pZbzVuL0JVbnRBQndBVlRiMzVU?=
 =?utf-8?B?Mm4rQlF0emNFV2tBbllRbk90UzJpK0JoZklkM2JBQk9DaW4xbkZaUTIrSkRZ?=
 =?utf-8?B?dExGRmFncytKd3J5SjV3WWNSMjhnSkM0eWpyM1dCZ045UHpZNEtQOVk1bDFa?=
 =?utf-8?B?bktrejFQRFNmL1puZ29reEFaWDFSVE1NQ0hGcVpJbXM4VjNyQ3VScHFSWkIz?=
 =?utf-8?B?QThlQkFoNEY2bjl1QXZHOE1NWHF6dGtyMzMxNGdMcUdDVjVxZW1kOWF4OFhI?=
 =?utf-8?B?Rlk4cW1paGIwV2ZuN0tCd3hZN2pRSnFWQ0dZZ0JkZHVhZFZ1dVlMa2pKcmwz?=
 =?utf-8?B?THVwZGxwM2ZyZWMzdzFQOFdyZE1FUVBabUZuVURGNU16NTM1OERwY0ViNGFI?=
 =?utf-8?B?bENLU29kZitNV1ZXM1pPTUFCUlpaWnM2dzMxcTIxVWpJS0k1RXB1a3Iwcmhj?=
 =?utf-8?B?dHhocnkwNWkxa0FLVGNxNCt0c0VpMnFpQkdCS2lnTSt2SzJGc0w4U1ZyYjFP?=
 =?utf-8?B?QTN6WTBwVlJpRmRlUkduT1N0TXdvNTdQVGY2VGU3NGlHVkI4bExhMmg3Qk9a?=
 =?utf-8?B?bVZ2WXQ2dllmTzEyTVJ5NS82dEVvQVNOeGs2YThQbTVMQVZuM0hxd2pSOHR4?=
 =?utf-8?B?c2VBSlhTU1dUckorRTNTV1o0Y0dWMzJXN25nUzVvb1dFR2JwK2dGOUpmOVpo?=
 =?utf-8?B?ZkpkNVFHdzdaR2w0NXZ5dmtlT1diT2IyeW85Y2dXaUsybUZQNGZ2VEp5YVlD?=
 =?utf-8?B?M29BTGRQQ2Z1azdiYXluQjY1SWdybjYybmhCdTk5cDEwQ1BDbkJsR29TSjhX?=
 =?utf-8?B?aVFPZlAxTFhyMnNQempjc0JvYXlGdnhaR01IMXVSRkwya0lhQmxNWDlTZlRK?=
 =?utf-8?B?emNkSVhkUXRDS2o4VzVlb1JxQ1hPZ2VIbURnNzhFRWZNUkhmc2V4UUJzaUFr?=
 =?utf-8?B?ZnE0QVdUS3g0NkdPZllrLzlWc2t6ZUF3YjRySncvUXI4ejFEMDQzYXVneTli?=
 =?utf-8?B?aEZVN3N1M24reEltNEJyMHFoKzU3NmZuYUdEbjhCL0VpSEtYVGdvV05pbElR?=
 =?utf-8?B?V2ViTGlqdmhUT1hCUEdkd0dYYXRrbU1KcHJaY21VSldNdzdSeURKejdQNVJH?=
 =?utf-8?B?andSQWZOT0tuLy8vQWdpYkR4WXB2ODJPVXFBaWd1SHpjRnlZL3FnTWNzb1pq?=
 =?utf-8?B?UHdvZWI4Y0h0bVhQTXFZTjlCd2diam50MVFVNzRmLzNaMFMxTkR5Z2Zod0Zp?=
 =?utf-8?B?eGtiSUs4Y1BwUDltaUpFUkhNcU9pUWtMVFE2bktvdndNelgyQTBYRm14ZEpC?=
 =?utf-8?Q?llv/6+L82gcx8cauJEB7vP0xJ?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f56eba4-05f9-4115-6f95-08dbec79721a
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 23:10:55.4865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bZGs06IbLofBpEv6UGVoa3xI1XTezElwreIggpIx2DS0H6l2fBNzMfhFT4hBGpcW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR02MB9704
X-Spam-Status: No, score=-3.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 23 Nov 2023 15:11:12 -0800 (PST)

Hi!

2023-11-18 at 19:04, Heiner Kallweit wrote:
> diff --git a/drivers/i2c/busses/i2c-kempld.c b/drivers/i2c/busses/i2c-kempld.c
> index e01d75308..9076ae4d7 100644
> --- a/drivers/i2c/busses/i2c-kempld.c
> +++ b/drivers/i2c/busses/i2c-kempld.c
> @@ -283,8 +283,8 @@ static const struct i2c_algorithm kempld_i2c_algorithm = {
>  static const struct i2c_adapter kempld_i2c_adapter = {
>  	.owner		= THIS_MODULE,
>  	.name		= "i2c-kempld",
> -	.class		= I2C_CLASS_HWMON | I2C_CLASS_SPD |
> -			  I2C_CLASS_DEPRECATED,
> +	.class		= I2C_CLASS_HWMON |
> +	I2C_CLASS_DEPRECATED,

The above is less than ideal...

It should obviously be:

-	.class		= I2C_CLASS_HWMON | I2C_CLASS_SPD |
-			  I2C_CLASS_DEPRECATED,
+	.class		= I2C_CLASS_HWMON | I2C_CLASS_DEPRECATED,

Cheers,
Peter