Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Thu, 23 Nov 2023 18:58:40 -0500
From:   Kent Overstreet <kent.overstreet@linux.dev>
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     linux-kernel@vger.kernel.org, Thomas Graf <tgraf@suug.ch>
Subject: Re: [PATCH] rhashtable: Better error message on allocation failure
Message-ID: <20231123235840.76nk3grth2sqmonc@moria.home.lan>
References: <20231122233225.178910-1-kent.overstreet@linux.dev>
 <ZV8OLxA4ewCf3fEt@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZV8OLxA4ewCf3fEt@gondor.apana.org.au>
Precedence: bulk

On Thu, Nov 23, 2023 at 04:32:47PM +0800, Herbert Xu wrote:
> On Wed, Nov 22, 2023 at 06:32:16PM -0500, Kent Overstreet wrote:
> > Memory allocation failures print backtraces by default, but when we're
> > running out of a rhashtable worker the backtrace is useless - it doesn't
> > tell us which hashtable the allocation failure was for.
> > 
> > This adds a dedicated warning that prints out functions from the
> > rhashtable params, which will be a bit more useful.
> > 
> > Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
> > Cc: Thomas Graf <tgraf@suug.ch>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > ---
> >  lib/rhashtable.c | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
> 
> However, you'll need to repost this via netdev@vger.kernel.org for
> it to be merged.

Thanks!