Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <de256121-f613-42d3-b267-9cd9fbfc8946@infradead.org>
Date:   Thu, 23 Nov 2023 16:19:35 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] fs/Kconfig: Make hugetlbfs a menuconfig
Content-Language: en-US
To:     Peter Xu <peterx@redhat.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <songmuchun@bytedance.com>,
        linux-fsdevel@vger.kernel.org
References: <20231123223929.1059375-1-peterx@redhat.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20231123223929.1059375-1-peterx@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

BTW:

On 11/23/23 14:39, Peter Xu wrote:
> Hugetlb vmemmap default option (HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON)
> is a sub-option to hugetlbfs, but it shows in the same level as hugetlbfs
> itself, under "Pesudo filesystems".
> Make the vmemmap option a sub-option to hugetlbfs, by changing hugetlbfs
> into a menuconfig.
> 
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: Muchun Song <songmuchun@bytedance.com>
> Cc: linux-fsdevel@vger.kernel.org
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  fs/Kconfig | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/fs/Kconfig b/fs/Kconfig
> index fd1f655b4f1f..8636198a8689 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -254,7 +254,7 @@ config TMPFS_QUOTA
>  config ARCH_SUPPORTS_HUGETLBFS
>  	def_bool n
>  
> -config HUGETLBFS
> +menuconfig HUGETLBFS
>  	bool "HugeTLB file system support"
>  	depends on X86 || SPARC64 || ARCH_SUPPORTS_HUGETLBFS || BROKEN
>  	depends on (SYSFS || SYSCTL)
> @@ -266,14 +266,7 @@ config HUGETLBFS
>  
>  	  If unsure, say N.
>  
> -config HUGETLB_PAGE
> -	def_bool HUGETLBFS
> -
> -config HUGETLB_PAGE_OPTIMIZE_VMEMMAP
> -	def_bool HUGETLB_PAGE
> -	depends on ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP
> -	depends on SPARSEMEM_VMEMMAP
> -
> +if HUGETLBFS
>  config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON
>  	bool "HugeTLB Vmemmap Optimization (HVO) defaults to on"
>  	default n
> @@ -282,6 +275,15 @@ config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON
>  	  The HugeTLB VmemmapvOptimization (HVO) defaults to off. Say Y here to

Is this small 'v'            ^ a typo?

thanks.

>  	  enable HVO by default. It can be disabled via hugetlb_free_vmemmap=off
>  	  (boot command line) or hugetlb_optimize_vmemmap (sysctl).
> +endif # HUGETLBFS
> +
> +config HUGETLB_PAGE
> +	def_bool HUGETLBFS
> +
> +config HUGETLB_PAGE_OPTIMIZE_VMEMMAP
> +	def_bool HUGETLB_PAGE
> +	depends on ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP
> +	depends on SPARSEMEM_VMEMMAP
>  
>  config ARCH_HAS_GIGANTIC_PAGE
>  	bool

-- 
~Randy