Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp726361rdh; Thu, 23 Nov 2023 17:08:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IFZu67MN9WCasqHNQPzdTHi3uCLo7SiMzDQsLoOTN+rfdZOXiM8lEnrHPp2ecudDAMrdUYF X-Received: by 2002:a05:6808:9a:b0:3b2:e48d:97b4 with SMTP id s26-20020a056808009a00b003b2e48d97b4mr1187584oic.26.1700788129734; Thu, 23 Nov 2023 17:08:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700788129; cv=none; d=google.com; s=arc-20160816; b=gNJXLJr0+eieoTaYBLAtseB37KabS6tv3hE1GHXpeeW78CZAoxGuiF7hiZG1YginiX mSJN1pGYlBUEfgTVsbvU64Mly5+YbbnA+51J/m03QHr0QIcaCyl4+GyNTf2gt8BohYiB OVtHsrSUm+vPijnFIyA7l0X5tneoNeuZqs3ftZouq/SgFpPJgj5lvwnDqWzjcrEyAhEh miUt9Jy2gxfZVvZEO1YWVEKu2LToHcSGf/R0xTYUvak1hHBve1VQ5fFWTC7gYJeOlN+E TW+kNdfqIaA+ilVT5UWvb6MioU936+xYB5s4zQIzpR9cH9N6MpuNLfUJpbOGJPd5Zi8A W8bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=2xxxAalZ73cRwdZRWpl45yBEiTMvShJqt0Ovd9kac2g=; fh=b6fHyuIa3iGwwxQAclvVdGfVEQAApdDOettH1bqXpF4=; b=Ia4KKNawpp2IS+Qpafr4Y9ggIscIuWkPs3NXJejZKdvZbUfUKUg/sx1ZVoPGhl/Gzu 8ipdLTYj1MF5pAoXT/5GZQQI5SNDuLdlp34VhXD5hJMn7PzwRvQOL5CkXxH6sCR1deIt AypGfdUfEUWJsgP7kHfPX1puQystFPig3lSNPQ73066xqrI3SITq6o3zamwirWUPfzTL r4rzaeUGUgrIXp/4h9hckTSBP9Xoz1fXKiUI9hpm2cicJBTHSs8LRffVHAo8i9TM5xdC ALF9cqrgeqqHt7Ys7tPWoX4+IPolICYJAOZxS6Ynazqym6R5CS1ht/Sziw1SrI+Ve/IT 6ziA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=aLUR6BoF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id 21-20020a630c55000000b005b8ececd69esi2233103pgm.670.2023.11.23.17.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 17:08:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=aLUR6BoF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E4278804E791; Thu, 23 Nov 2023 17:07:29 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229722AbjKXBHS (ORCPT + 99 others); Thu, 23 Nov 2023 20:07:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjKXBHR (ORCPT ); Thu, 23 Nov 2023 20:07:17 -0500 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5EAD1B6 for ; Thu, 23 Nov 2023 17:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1700788038; bh=2xxxAalZ73cRwdZRWpl45yBEiTMvShJqt0Ovd9kac2g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aLUR6BoFlBYtiJSS1etIcfjzdaRpP7n06oAX400JbB3OP61oS/wOD/3jq4bPjiHo7 3wV4SPvTP17Yymwb3AVOw5cxJL3maWt8kTqxiWD0fQM4wcqqDzYWLfxL3K9rkKAnFf ojmOBd5/ZElekPwIA7twndtJZFq7XZH8nRc4O9ntZ4Cxpv3JrqzErLQo5ugIGxzrhe AnO4HeawO2liLqIkV6zztDc+3tAcLf8juI796b7ZvbBbqqPK25FTyG884GBMkPQKCQ LJw3I9E1ued7g3z1a+HLCZCJix/By7U4i3qv7cRtce+cFZDtLBozzgMFENOcehn3bS 8PA1SWmy4fqQQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SbxfF0fnlz4wd2; Fri, 24 Nov 2023 12:07:17 +1100 (AEDT) From: Michael Ellerman To: Peter Xu , Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrea Arcangeli , James Houghton , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , John Hubbard , Yang Shi , Rik van Riel , Hugh Dickins , Matthew Wilcox , Jason Gunthorpe , Axel Rasmussen , "Kirill A . Shutemov" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Mike Rapoport , Mike Kravetz Subject: Re: [PATCH RFC 06/12] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing In-Reply-To: References: <20231116012908.392077-1-peterx@redhat.com> <20231116012908.392077-7-peterx@redhat.com> Date: Fri, 24 Nov 2023 12:06:24 +1100 Message-ID: <87y1eoq7sf.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 17:07:30 -0800 (PST) Peter Xu writes: > On Wed, Nov 22, 2023 at 12:00:24AM -0800, Christoph Hellwig wrote: >> On Tue, Nov 21, 2023 at 10:59:35AM -0500, Peter Xu wrote: ... >> >> If dropping the check is the right thing for now (and I think the ppc >> maintainers and willy as the large folio guy might have a more useful >> opinions than I do), leaving a comment in would be very useful. > > Willy is in the loop, and I just notice I didn't really copy ppc list, even > I planned to.. I am adding the list (linuxppc-dev@lists.ozlabs.org) into > this reply. I'll remember to do so as long as there's a new version. Thanks. > The other reason I feel like hugepd may or may not be further developed for > new features like large folio is that I saw Power9 started to shift to > radix pgtables, and afaics hugepd is only supported in hash tables > (hugepd_ok()). Because it's powerpc it's not quite that simple :} Power9 uses the Radix MMU by default, but the hash page table MMU is still supported. However although hugepd is used with the hash page table MMU, that's only when PAGE_SIZE=4K. These days none of the major distros build with 4K pages. But some of the non-server CPU platforms also use hugepd. 32-bit 8xx does, which is actively maintained by Christophe. And I believe Freescale e6500 can use it, but that is basically orphaned, and although I boot test it I don't run any hugetlb tests. (I guess I should do that). cheers