Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   Yaxiong Tian <iambestgod@outlook.com>
To:     myungjoo.ham@samsung.com, cw00.choi@samsung.com
Cc:     linux-kernel@vger.kernel.org, tianyaxiong@kylinos.cn
Subject: [PATCH] extcon: fix possible name leak in extcon_dev_register()
Date:   Fri, 24 Nov 2023 09:49:13 +0800
Message-ID: <TYZPR01MB4784ADCD3E951E0863F3DB72D5B8A@TYZPR01MB4784.apcprd01.prod.exchangelabs.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: TYZPR01MB4784:EE_|SEYPR01MB5145:EE_
X-MS-Office365-Filtering-Correlation-Id: eace3cc9-2153-441a-0de9-08dbec8f9aba
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: mGG9MXnQD0Bn1MNoQTo5xwRY66MFEihhWleF7a1xJwwqw8gTQaxlXvsYWNf1HZ94oUxRcmyLGW3MFFa7xU//2plDZCtJjoaiVWU2zItA+X4wzezsj6y6gP1T/53VuakySXUYZV/IXZR20fpDsloIskwC2nvrNaa4vllDZpoUp5FSWMEkrW+lrdAojvZ+7QSBn9aRq4XqNdl3p4LCdVsgBliVp99b7cUe8lw7dSCBv/+kb2mzg0PAGu3FtLXwcGUCTZHIVXPS0Gg/vKrgee5attt0Mqjsvez4zsnmWdppt609eA1d2ZgNMYlO8t1SMbQl1K1sL/28V9ivo7sB3hYDCRSV+qvDaSLHRn2jMnlHwxpBcUYnJxatfT4HkEQXMVRpzOu4k1+R5N0w1A6XATPeYw8wsl8Cb3T7YB0BlAHbW/sg5stRZgCIU/kNX9R59dGYad6oS2OYTRHGTnXtTpbNyuCGP2nAtKFTAiUwMs1fA87YgfXiEh+GMm2Wv4bEZNbwWpCDwmccSZRiPH0oTtVvzPbOL22RjCjEwuZOtidzTtRA5Wgrn5mFpcnfose1bhri
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RIz5UQ+HgW+Ma5WYFCu0/5caeU5S3s68MRWdJ61+fqYXmJdx+xovXPNQg9Wv?=
 =?us-ascii?Q?Ef1OmR38rwavYewndsBhPU3G2e0BNFAYw2vsdqp1yU72PTrysJWkN05gUg4B?=
 =?us-ascii?Q?AuO4o8USeXIwXNmvCYxoLu+tybYgEtlLTfz6brwGdy5lUVKYlKleQ+gZ/HNo?=
 =?us-ascii?Q?5Uu/jseNBvs70Tm6hQiPZXTEsq/ocHWqODh9Eld6E/ipfR3eD9e2SeVqT83R?=
 =?us-ascii?Q?+YEjPbrGQym+QNSA/LTz/gfmpxQO+AF4d8sI82HqMpCONSLYDro79SenADIS?=
 =?us-ascii?Q?TR2qoM2E0OndQ2RqBPZoaeZz1yCl289JVbO268LYt6roj5pyrTqd0CWxlHtt?=
 =?us-ascii?Q?s3l05FVM+f91TzSyrtTp765l0ullxgz1QhropRE16Zb3Wl+5hajbfTbasnac?=
 =?us-ascii?Q?hq7UQgnzpFKXuPguOu7ZEcxfPxvPkd4JQ5P+5MGCWXCMyQ1d4Zi+xNbT8i0o?=
 =?us-ascii?Q?rst5lu1/bQ0rcGzm9AuLkKjmY4qrf338O/lHEv+kjTjscc6kZSgh8OlitJFX?=
 =?us-ascii?Q?dCi2KYSmlkaB5GOcvEg8WRdDvlhf7ICeqkkYWAT8GTg36BJ8KK3L5gAP3nz4?=
 =?us-ascii?Q?041gTmEtF7IfODxo/6Y2ZEOCPPD5fapdwztRxmR/j653TgWOTcO/6OikkKB4?=
 =?us-ascii?Q?wF9Kg/2dnojPbo0DgRyBIoguRBUIp4EJZ/XoCUKxW+zdfnWhzuULKfyI0zO6?=
 =?us-ascii?Q?+Hjh5FTIP+2w10j/FtG1ZOl/vYaWH4PYA6PdaVro02HKsZFVcW2kojXNJULl?=
 =?us-ascii?Q?R99HGLhTk9AcD2+JhgewdeNFm96uY2FCERSfTZ/fFAjIDnyBM9Quo/EeMWhp?=
 =?us-ascii?Q?KdfcKpqkrn0QjGIGT2inGP3OFOiXMIPw7QiX6hRWDyQm8Vcj0NX7zu4JAy2G?=
 =?us-ascii?Q?efzjUGTrKDd6guVP7LWQP+Vie69CLg6Y7VD9FqW4Sz+wRy8M9hW8PefLrD+B?=
 =?us-ascii?Q?vBqyYnQjXW5eLJHLBsvgtnGly3D+kiIgtlt2L8PSgZP5DklhaNyQydA9FWog?=
 =?us-ascii?Q?QKNMz72jFW5tfiIQ+6JREWT/EP0kizTgVJehKwb7tuAIokBqiGW80MqnUJmh?=
 =?us-ascii?Q?XbwNtLB5CEJNRsTdOZPGlcE/uuAO+LS+kxiTYN2o8DULyM84xj6HonWPpZnv?=
 =?us-ascii?Q?7LexNa5nL0uDY7vl0NIGCKVRjAkkKW/EsNn7EhjfFCZEPEwbVhCxOKCqNvjU?=
 =?us-ascii?Q?pTLhjV3+TcidXDzl9EeJy5kjsT+KOpU6BsTnpgHiUDWCAv3gPngmdqwrbKcX?=
 =?us-ascii?Q?RljRrHCLeG+Qmph2kUUhS8DR6MGthpmLOHN6dpo4GpzFkec6rV2Kjfd8S7uk?=
 =?us-ascii?Q?9rI=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eace3cc9-2153-441a-0de9-08dbec8f9aba
X-MS-Exchange-CrossTenant-AuthSource: TYZPR01MB4784.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 01:49:32.9821
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR01MB5145
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 23 Nov 2023 17:49:46 -0800 (PST)

From: Yaxiong Tian <tianyaxiong@kylinos.cn>

In the error path after calling dev_set_name(), the device
name is leaked. To fix this,Moving dev_set_name() after the
error path and before device_register.

Signed-off-by: Yaxiong Tian <tianyaxiong@kylinos.cn>
---
 drivers/extcon/extcon.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 6f7a60d2ed91..e7f55c021e56 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -1280,8 +1280,6 @@ int extcon_dev_register(struct extcon_dev *edev)
 
 	edev->id = ret;
 
-	dev_set_name(&edev->dev, "extcon%d", edev->id);
-
 	ret = extcon_alloc_cables(edev);
 	if (ret < 0)
 		goto err_alloc_cables;
@@ -1310,6 +1308,7 @@ int extcon_dev_register(struct extcon_dev *edev)
 	RAW_INIT_NOTIFIER_HEAD(&edev->nh_all);
 
 	dev_set_drvdata(&edev->dev, edev);
+	dev_set_name(&edev->dev, "extcon%d", edev->id);
 	edev->state = 0;
 
 	ret = device_register(&edev->dev);
-- 
2.25.1