Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Fri, 24 Nov 2023 09:53:58 +0530
From:   Wyes Karny <wyes.karny@amd.com>
To:     "Gautham R. Shenoy" <gautham.shenoy@amd.com>
Cc:     Huang Rui <ray.huang@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Perry Yuan <Perry.Yuan@amd.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq/amd-pstate: Fix the return value of
 amd_pstate_fast_switch()
Message-ID: <ZWAlXl6MP20khEwB@BLR-5CG13462PL.amd.com>
References: <20231123082757.3527-1-gautham.shenoy@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231123082757.3527-1-gautham.shenoy@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4iTLR38LZgzGed8tVB67UaEQsqZc0CwYg+nRFlTFfSSXa/civqsX3Y/6LrtZ?=
 =?us-ascii?Q?32AWYBaJG54LSUMDENvo62pMjFBjYLH1H46IC3AbI0GdFyb8MKayOnRukP0D?=
 =?us-ascii?Q?TlFQzacjiQAfFN3R9sTK0B7UrHpTgW/8dY+lF0GC/HedsNuqzMkjMSd4hhzM?=
 =?us-ascii?Q?pZaxGfxEUAaujLCj5ZSD0L2X+3yQu+5636/112LlqOcV/vEtAwvf/L4cMsPv?=
 =?us-ascii?Q?zoi0WBQnifUXB+pUkgRgzPVeubAQB0Pth+oyA0s4wtp3IDl+vjFnBIv/Lh6R?=
 =?us-ascii?Q?TzcVg9abRp2NywIEhkslqY03qbqbt71pwHDTX2fRFd3YA5OwUM7GOZNKQj+w?=
 =?us-ascii?Q?tIRf8sVCFw3aeYpOU2EN0zl1BAuaF944qQGAaP9BdpylCMUT0hFH83iPDLj9?=
 =?us-ascii?Q?ShBog+2nT/Vhh2EXL2BWlMOOxSASueTgO0orFfKNqje8dgg6yz+l0yHuTivH?=
 =?us-ascii?Q?579ICEhgEm4DLyLnHwUIH9M8fOGGqVPEYT6ukAElOHWhMOpnvh+CahvJydZ7?=
 =?us-ascii?Q?Qh3xh9TNxPMe4HsGHr6hzNT5xtAvaPE0UZ6nNxq4OqM3L9XJdrdLeU9ONkuT?=
 =?us-ascii?Q?juOKvjjtPM+IuM8y0TgywvkZ40TCVWyrMCNn86K8AJdn88OEmoFYlYzmAE8N?=
 =?us-ascii?Q?WObY+26FbGZ5UrFH4Kr8ZQSzZR43foIYx/bwu05SDpORoRJNkbD9iyPPv1aS?=
 =?us-ascii?Q?ZKaRHn+ZdEJ/rBxRxbLFLEQmAaPvyPIzouEyuZXhoC3LeyFA5ZQ0ajbE9Ny0?=
 =?us-ascii?Q?RoL99d6zBFPB4C6Lugt4PBNEUifpiv1WVh1VHRYlzN3wV5DjiIFOeTelPfhL?=
 =?us-ascii?Q?UCkx62mBs8Ydlg0AtRCGJuZjQqe6lM/A6DVPjASbnrBkGSuKf7f9JKHQ/lEf?=
 =?us-ascii?Q?imVDxTT86vHhjJvyEiDC/nUGIErLy6k2sPpOOfNWNk2Go4fGF3iDtkWCU/qC?=
 =?us-ascii?Q?PdSqjAvhXUC3WQwRxBOEwDc7G+vBhVKxw8DZSorvVIrb9sj4CaCNPV6Ae8ml?=
 =?us-ascii?Q?xTgEfyidbVBp4pY/BVXKrXbvwHU5AvxUHGeOFozfDnuMCihkvA9zWLktLiw1?=
 =?us-ascii?Q?fzxQ9ejLWD/vWkrUFY3pGy9ttte7STPY+CL6EbB9xyPunKWqPnComM0jpw5c?=
 =?us-ascii?Q?fMhbx+qd9wjzZxu7y5nw/Lw91UfjdpnqueuIsNNyf7HJiBTFjbREA5jx3SXO?=
 =?us-ascii?Q?N+bZlQzFnafQsUac8ezwWDSjspAYkveCPt4LmP8TlphzoX/fgpc34S98Nk+U?=
 =?us-ascii?Q?a/3L+gvPRSjFUpJWZYZiAp25Z8Ye0geXxCCyzPDWNDFGXereyoZDC+M+9ceo?=
 =?us-ascii?Q?vhcMc/eNypjOMTG/ZdfPtAaABMNH1FLM9ki062VaVBw0ifKZq2NUmtOf/zRb?=
 =?us-ascii?Q?bQa5g6QJAEprBaGt+b9vCcvRJRXFu1mNMClmWuZRwy1DnXYCYIltj2btB7S5?=
 =?us-ascii?Q?aoMXOtn3noHuVl54llm1arZ6jEmWy7aNO1u2DOC9DtyBi7naULgj613opCrt?=
 =?us-ascii?Q?P+MBD4EGav5E1ntZe5Cg3qf0gKoOE642lNaORyaI3RMcLm5ERzEI56uixfgV?=
 =?us-ascii?Q?7x5nk5kxTaH887A/wzVjVvt2HRBF2SvYfqnsP7aX?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c47a475-5c08-4732-f88f-08dbeca533f5
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3888.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 04:24:09.0595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kUMnbqdMkd3CHig6rvOGB0bgtlLxh2Hpq7sKRCVsmbC958gRHZJCKq/t7g1sBhFbzErcxmnRA8wW3HTYi+ZBmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6941
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 23 Nov 2023 20:24:23 -0800 (PST)

On 23 Nov 13:57, Gautham R. Shenoy wrote:
> cpufreq_driver->fast_switch() callback expects a frequency as a return
> value. amd_pstate_fast_switch() was returning the return value of
> amd_pstate_update_freq(), which only indicates a success or failure.
> 
> Fix this by making amd_pstate_fast_switch() return the target_freq
> when the call to amd_pstate_update_freq() is successful, and return
> the current frequency from policy->cur when the call to
> amd_pstate_update_freq() is unsuccessful.
> 
> Fixes: 4badf2eb1e98 ("cpufreq: amd-pstate: Add ->fast_switch() callback")

Reviewed-by: Wyes Karny <wyes.karny@amd.com>

> Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 9a1e194d5cf8..300f81d36291 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -518,7 +518,9 @@ static int amd_pstate_target(struct cpufreq_policy *policy,
>  static unsigned int amd_pstate_fast_switch(struct cpufreq_policy *policy,
>  				  unsigned int target_freq)
>  {
> -	return amd_pstate_update_freq(policy, target_freq, true);
> +	if (!amd_pstate_update_freq(policy, target_freq, true))
> +		return target_freq;
> +	return policy->cur;
>  }
>  
>  static void amd_pstate_adjust_perf(unsigned int cpu,
> -- 
> 2.25.1
>