Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp856001rdh; Thu, 23 Nov 2023 22:33:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOCf4LAI1p5KVmCf5Z+lCwdh8zPOjRWgKPxhLMbK+bFXzf5kPKbIvK/r2mN2Q7xV1KJHXd X-Received: by 2002:a05:6870:9f8b:b0:1e9:c7cc:df9a with SMTP id xm11-20020a0568709f8b00b001e9c7ccdf9amr2710831oab.11.1700807596017; Thu, 23 Nov 2023 22:33:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700807595; cv=none; d=google.com; s=arc-20160816; b=Kngx7m5WJnO9cdRmm/vdubH/bOVfWiCg1OTvTQoZH8PtrcaIS3DTTa44SQ01k4qk8J AbXmXnEIHLlHKYyJUE30FbScMlWv2HAmX4SvijKseQXuMYEoo2pxG1nqM8SGSJQUxhsi XTrctkiPQmXSvMsxVC9mPFBZQyrmH46LzWs1r4byGva1VBVfrN+W4KCoJ+0L0YUGajM3 ALVGbqBWVtJilhW+QWzlmU9tXEjJ28wMjbITkXK4qedv6iYLt2eKtFnTPiBj2qzgyHUz flpSotmLwpSuhYgEp4uKJvK+WXJ8TzX6Upc90YAPDlRKq3iVOH3FtUkBFqCIfV9fpKAj SzRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=z4MGNAlbrPy+2s9byz76I+YkkK3yRwQ5k9jtzqcXBuM=; fh=zdCGAjoGTsGCYFoCoQR+gOkazJMlgn9SjF7pSdA+Aak=; b=yPWLaM4pDhA8FAdNPh8BnDgQ/3JAwmIREmTAZlL56Wmtm/iMpMyMjN9WGjkioQjLjG KOQcNQDrjBYjm8sFTOf7vnLw2h/cedsFA5XJ7HPa36vF1R9GM2ANs9TtQ/rT7q4DBO34 uMPUYQG4bO97ft/YYxrmvDuf13kYR2pjsU+nrUuc/4C75h0q6Tnf5UD+5ZLXnxtgLPd4 Cr/daU+3qCjEsN9tngF/AR2DqCN4L22v7KEi0RQ6YotE3ffGTcUtRRZMILQA0AwJrKuS nyeS98mx/RfXR4kw25zHIA3RET/tRNB4gl8spmC07sUJTmBLljTcxDw8O+CFI4TnLVot jaXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@atomide.com header.s=25mailst header.b=fOyeZFM3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id u4-20020a056a00098400b006bb0aafd563si2909364pfg.237.2023.11.23.22.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 22:33:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=fail header.i=@atomide.com header.s=25mailst header.b=fOyeZFM3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 6E78B829EA34; Thu, 23 Nov 2023 22:33:13 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230299AbjKXGcs (ORCPT + 99 others); Fri, 24 Nov 2023 01:32:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjKXGcp (ORCPT ); Fri, 24 Nov 2023 01:32:45 -0500 Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D330591; Thu, 23 Nov 2023 22:32:51 -0800 (PST) Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id 1DB30603EE; Fri, 24 Nov 2023 06:32:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1700807571; bh=+gS/X74h4UfVNPZhsitLFhRKfvXbk2HaAi+3m9/w4LA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fOyeZFM3XB/N1+TWPkAPihd+noaGWJronK71K0i3yOCY4UcLBv1uy0Mq2MrhaW5sw L4fWQqlSnNwNM4oVau/CDo1e6vK0+H9Sa1Qnal8PBAV9kQ1REiOgueHKoHaCb/3t2t yZntys8VgzYz07KKMJVtaV+czADccc7zutPFMiv2U1IAdF5JP2BH8MMUmHXvQ3WtHX NXIe/acjhZKOzAA2QpDnySk9I7tLMJYuaJmMh0hsENtiUIIBnGFACcoG4S3WXHXI2R H4BmW0ylNun2MKKfpeTN6NzDcA5hxRPfwA+u0B6d1pQF2SkROP87ijITBwdeXHIC+n xAapRrmmE8Viw== Date: Fri, 24 Nov 2023 08:32:10 +0200 From: Tony Lindgren To: Dan Carpenter Cc: oe-kbuild@lists.linux.dev, Greg Kroah-Hartman , Jiri Slaby , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , lkp@intel.com, oe-kbuild-all@lists.linux.dev, "David S . Miller" , Andy Shevchenko , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v3 3/3] serial: core: Move console character device handling from printk Message-ID: <20231124063210.GI5169@atomide.com> References: <20231121113203.61341-4-tony@atomide.com> <6933c98f-7f76-4955-ba0f-89ea340b672d@suswa.mountain> <8a4c0b43-cf63-400d-b33d-d9c447b7e0b9@suswa.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a4c0b43-cf63-400d-b33d-d9c447b7e0b9@suswa.mountain> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 22:33:13 -0800 (PST) * Dan Carpenter [231123 07:29]: > On Thu, Nov 23, 2023 at 10:24:24AM +0300, Dan Carpenter wrote: > > Hi Tony, > > > > kernel test robot noticed the following build warnings: > > > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Tony-Lindgren/printk-Save-console-options-for-add_preferred_console_match/20231121-193809 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing > > patch link: https://lore.kernel.org/r/20231121113203.61341-4-tony%40atomide.com > > patch subject: [PATCH v3 3/3] serial: core: Move console character device handling from printk > > config: parisc-randconfig-r081-20231122 (https://download.01.org/0day-ci/archive/20231122/202311221437.5Gil0Pml-lkp@intel.com/config) > > compiler: hppa-linux-gcc (GCC) 13.2.0 > > reproduce: (https://download.01.org/0day-ci/archive/20231122/202311221437.5Gil0Pml-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Reported-by: Dan Carpenter > > | Closes: https://lore.kernel.org/r/202311221437.5Gil0Pml-lkp@intel.com/ > > > > smatch warnings: > > drivers/tty/serial/serial_base_bus.c:266 serial_base_add_preferred_console() error: uninitialized symbol 'nmbr_match'. > > drivers/tty/serial/serial_base_bus.c:265 serial_base_add_preferred_console() error: uninitialized symbol 'char_match'. > > > > vim +/nmbr_match +266 drivers/tty/serial/serial_base_bus.c > > > > e4ebdcd790e0f3 Tony Lindgren 2023-11-21 261 int serial_base_add_preferred_console(struct uart_driver *drv, > > e4ebdcd790e0f3 Tony Lindgren 2023-11-21 262 struct uart_port *port) > > e4ebdcd790e0f3 Tony Lindgren 2023-11-21 263 { > > e4ebdcd790e0f3 Tony Lindgren 2023-11-21 264 const char *port_match __free(kfree); > > b1b8726ec3f40b Tony Lindgren 2023-11-21 @265 const char *char_match __free(kfree); > > b1b8726ec3f40b Tony Lindgren 2023-11-21 @266 const char *nmbr_match __free(kfree); > > > > These need to be initialized to NULL. > > > > const char *char_match __free(kfree) = NULL; > > > > Let's add a todo to make checkpatch warn about this. > > KTODO: make checkpatch warn about __free() functions without an initializer Yes good idea. Thanks, Tony