Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20231124131331.23279543@canb.auug.org.au>
In-Reply-To: <20231124131331.23279543@canb.auug.org.au>
From:   Amir Goldstein <amir73il@gmail.com>
Date:   Fri, 24 Nov 2023 09:58:00 +0200
Message-ID: <CAOQ4uxjFta+-jirxbD3z4qDZ735F=jtghzSNuTxsOxEY+A41zQ@mail.gmail.com>
Subject: Re: linux-next: build warning after merge of the vfs-brauner tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Christian Brauner <brauner@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Nov 24, 2023 at 4:13=E2=80=AFAM Stephen Rothwell <sfr@canb.auug.org=
.au> wrote:
>
> Hi all,
>
> After merging the vfs-brauner tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/filesystems/api-summary:14: include/linux/fs.h:1655: WARNIN=
G: Definition list ends without a blank line; unexpected unindent.
> include/linux/fs.h:1658: warning: Function parameter or member 'level' no=
t described in '__sb_write_started'
>
> Introduced by commit
>
>   2a7b49f698d0 ("fs: create __sb_write_started() helper")

Christian,

Do you mind folding:

@@ -1648,6 +1648,7 @@ static inline bool
__sb_start_write_trylock(struct super_block *sb, int level)
 /**
  * __sb_write_started - check if sb freeze level is held
  * @sb: the super we write to
+ * @level: the freeze level
  *
  * > 0 sb freeze level is held
  *   0 sb freeze level is not held

Thanks,
Amir.