Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
References: <20231124060200.GR38156@ZenIV> <20231124060422.576198-1-viro@zeniv.linux.org.uk>
 <20231124060422.576198-3-viro@zeniv.linux.org.uk> <CAOQ4uxjyS45FKJORfxpMHeFbZhszNR2QM6nTF46UxT1iz85Gsg@mail.gmail.com>
 <20231124075509.GU38156@ZenIV>
In-Reply-To: <20231124075509.GU38156@ZenIV>
From:   Amir Goldstein <amir73il@gmail.com>
Date:   Fri, 24 Nov 2023 10:02:46 +0200
Message-ID: <CAOQ4uxhVCzJtX7sNqHH2btkGY-Lnin4GjvXJv1nEEfk-O+EK_g@mail.gmail.com>
Subject: Re: [PATCH v3 03/21] dentry: switch the lists of children to hlist
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     linux-fsdevel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Christian Brauner <brauner@kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Nov 24, 2023 at 9:55=E2=80=AFAM Al Viro <viro@zeniv.linux.org.uk> w=
rote:
>
> On Fri, Nov 24, 2023 at 09:44:27AM +0200, Amir Goldstein wrote:
> > On Fri, Nov 24, 2023 at 8:05=E2=80=AFAM Al Viro <viro@zeniv.linux.org.u=
k> wrote:
> > >
> > > Saves a pointer per struct dentry and actually makes the things less
> > > clumsy.  Cleaned the d_walk() and dcache_readdir() a bit by use
> > > of hlist_for_... iterators.
> > >
> > > A couple of new helpers - d_first_child() and d_next_sibling(),
> > > to make the expressions less awful.
> > >
> > > X-fuck-kABI: gladly
> >
> > ???
>
> It breaks kABI.  Hard.  For a good reason.  And if you need an elaboratio=
n
> of the reasons why kABI is, er, not universally liked - let's take it
> to private email.  Some rants are really too unprintable for maillists...

I don't mind rants, even quite fond of yours :)

But "X-fuck-kABI: gladly" serves no real value.
You'd already documented the kAPI change in porting.rst.
If you want to add a note about kABI, I suggest that you add it there.

Thanks,
Amir.