Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp922030rdh; Fri, 24 Nov 2023 00:50:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IEXEg4rpTQZUoTkJTI+dXlFfasLnocn0KNGPT5AywR8zIHNjqRCxEBr+LmrDnH45Zf+8xnw X-Received: by 2002:a17:902:cec1:b0:1ce:5f09:ffdf with SMTP id d1-20020a170902cec100b001ce5f09ffdfmr2076708plg.0.1700815834114; Fri, 24 Nov 2023 00:50:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700815834; cv=none; d=google.com; s=arc-20160816; b=pCYd/SKhQ1nVO/P4XSQAMsV0gErC+8J12T9ONj6rEwnTE/XZzjMFURQDj0fS+xDOYh x3uycV5MOBK8wAtkn13uveCPFzkqPf3H4x5flNmpv9iTwd8iJM/JyZekka5uhDEEAySZ Dv7MGKqWqykw93EnKY0YhXSFA1mw9pJngY0binWWbm9XdEyIJE8Cb3cl1pGYbfiz1xNo zUBSecCAr3fBdNqS9zl0Ye5ef0/sIvZ3dScLSIa74KuLqiW906xyuN3Ft2gV9eUPGUd/ n/oms8ZhTJVYAlQ47P1qReEFj9+W3cvYsoiAk9uT/bFup1DHi/zxyog6jB7IZGyYJtAt qjhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:mime-version:date :dkim-signature:message-id; bh=Nq4cVHE3aS50pt61PJBpp6DABCIdQLm3XSVvZSjl8uU=; fh=Sjf+bUDXgJcjM+9A2wNg3kF1YgCoA/txVDGHS3qC8Y8=; b=mPvCxgWN33Unf2NNqN9XeSEGqr89Wnb/gUGIIVilZzQQwD8mAL80J53l1kKVR1Ady8 B36Biu34HxgZcZYixheEc+H5hKUphdVsL2WsbJOJCqyu9RfUAFJ1G0YGDwdis5/+seG5 mpRitDec/Hd5EwLR4vJFLrcl6l+ZR1i3hMsLKi/yTHB/YkXmnAIW/52fxATi9dMTpENx MzUinI6AjbwdQ5jHnAVusBgSrcTewuraiV3SmymA+fSeAbD1bkur7VHzm3rbx/cMwTyE 1CHuA/VTrkbP4+7jWa1Vc6oJteERLsJEPg61agdoXxZbPF/RzAJ2LAfo7Q1z6+cdvIhd pcig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=rxfeKF8m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id o1-20020a170902d4c100b001ce5b86d0dbsi3109855plg.414.2023.11.24.00.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 00:50:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=rxfeKF8m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 4E1FF81B4AE9; Fri, 24 Nov 2023 00:49:48 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235132AbjKXItU (ORCPT + 99 others); Fri, 24 Nov 2023 03:49:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235236AbjKXIsw (ORCPT ); Fri, 24 Nov 2023 03:48:52 -0500 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [IPv6:2001:41d0:203:375::aa]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86CCF1BD for ; Fri, 24 Nov 2023 00:48:58 -0800 (PST) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700815736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nq4cVHE3aS50pt61PJBpp6DABCIdQLm3XSVvZSjl8uU=; b=rxfeKF8mUCS/Ycfqhd59nX5VIxjqyfT5JuPWaX2p2Du7Mpb4hf8w2dPJiyH5L55SJw73A+ D24FYt7tGvTO0IvfbghPOQ52hNnp9cwPswKJAGRHwLjKnXSFAtDNI8aFPN+IBWPDqZQaxm CJEG510yGmlFSpfqsgDzPzroEiLLP1g= Date: Fri, 24 Nov 2023 16:48:49 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib Content-Language: en-US To: Maxime Ripard Cc: Dmitry Baryshkov , Phong LE , Neil Armstrong , Sui Jingfeng , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart , Thomas Zimmermann References: <79301d04-c0cb-4740-8a6d-27a889b65daf@linux.dev> <121163c9-0d56-47ad-a12e-e67390fef2b4@linux.dev> <00ba2245-0e48-4b21-bcd4-29dfb728e408@linux.dev> <10c4ae94-525f-4ac1-9d59-80bb4f7d362e@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 24 Nov 2023 00:49:48 -0800 (PST) Hi, On 2023/11/24 16:13, Maxime Ripard wrote: > On Fri, Nov 24, 2023 at 03:51:00PM +0800, Sui Jingfeng wrote: >> Hi, >> >> On 2023/11/24 15:38, Maxime Ripard wrote: >>> On Fri, Nov 24, 2023 at 01:52:26AM +0800, Sui Jingfeng wrote: >>>> On 2023/11/23 16:08, Dmitry Baryshkov wrote: >>>>>> I'm agree with the idea that drm bridges drivers involved toward to a direction >>>>>> that support more complex design, but I think we should also leave a way for the >>>>>> most frequent use case. Make it straight-forward as a canonical design. >>>>> Not having anything connector-related in the drm_bridge driver is a >>>>> canonical design. >>>> What you said is just for the more complex uses case. I can't agree, sorry. >>>> >>>> By choosing the word "canonical design", I means that the most frequently used >>>> cases in practice are the canonical design, 95+% motherboards I have seen has >>>> only one *onboard* display bridges chip. For my driver, I abstract the internal >>>> (inside of the chip) encoder as drm_encoder and abstract the external TX chip as >>>> drm_bridge, this design still works very well. >>>> >>>> >>>> Originally, I means that this is a concept of the hardware design. >>>> You are wrong even through in the software design context, the >>>> transparent simple drm bridge drivers(simple-bridge.c) also *allow* >>>> to create drm connector manually. I don't think I need to emulate >>>> more example, please read the code by youself. >> 'emulate' -> 'enumerate' >> >>> Ok. That's it. We've been patient long enough. You have been given a >>> review and a list of things to fix for your driver to be merged. >> This series is not relevant to my driver, can we please *limit* the >> discussion to this series? > Right, I conflated the two, I meant this series, or the general goal to > enable that bridge with your driver. The rest of the driver is of course > unaffected. > >>> Whether you follow them or not is your decision. >> I'm not saying that I will not follow, just to make sure what's >> solution is you want. I need discussion to figure out. > You had direct, repeated, feedback on that already by a maintainer and > one of the most experienced dev and reviewer on bridges. If you need > more guidance, you can definitely ask questions, but asking questions > and telling them they are wrong is very different. > >>> We won't tolerate insulting comments though. >> There is *no* insulting, please don't misunderstanding before >> *sufficient* communication, OK? Originally, I thought Dmitry may >> ignore(or overlook) what is the current status. > Saying to someone maintaining and/or reviewing that code for years now > that they are wrong and should go read the code is insulting. OK, I will remind my written words in the future. I will back to investigate for a period of time. Thanks a lot for reviewing. > Maxime