Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Fri, 24 Nov 2023 10:19:37 +0100
From:   Larysa Zaremba <larysa.zaremba@intel.com>
To:     Furong Xu <0x1207@gmail.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Joao Pinto <jpinto@synopsys.com>,
        Simon Horman <horms@kernel.org>, <netdev@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <xfr@outlook.com>,
        <rock.xu@nio.com>
Subject: Re: [PATCH net v2 1/1] net: stmmac: xgmac: Disable FPE MMC interrupts
Message-ID: <ZWBqqXMOZ3jcBkqB@lzaremba-mobl.ger.corp.intel.com>
References: <20231124015433.2223696-1-0x1207@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231124015433.2223696-1-0x1207@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qh+CPZsKuMlj6ScU9mfFVMuNWbxT5E3rVJLST0ckUvLz9fubo4AsdXRbDNA8?=
 =?us-ascii?Q?RCMkfyFa6ajhWo2cMUFCoGrnf9c/+KCBYCZbxGs5Xl3nScdYE7Bv7X7isB75?=
 =?us-ascii?Q?VZ+YPbVCnPr+2HBDVYfTvjiQ+p0qe7ZTTNbFzDS92SCb52AvuHqRE16YZrf9?=
 =?us-ascii?Q?voJaMDliz0B9vuNQvgMV13y5tKvGVDwRqc62QOKQ32596wVizbyhOiUQn47Q?=
 =?us-ascii?Q?IcUMewjC3g6D64TG2FBJSpbxCcmngdZBFRGlpPMLTnck4opUaKCyAnfusoKo?=
 =?us-ascii?Q?OQbw+If6dLxOCm1ja68SUKTDSkkzEr/Ib4Nhs/yDBYsKTD2bSHX+wRjRV/VX?=
 =?us-ascii?Q?rpINKGU1WNyJV3lOP6aa9Pq7eP3cGZHu5dXIJWxFKYoJzjFNj3L6afv3eYjq?=
 =?us-ascii?Q?fIJZVpt6aLHxB5tn+c+qI8QMd2GYnIeaqrGEHQM8oCYmD5vX5kdwN9jpTbhU?=
 =?us-ascii?Q?iDudr4f2meLSBoUP5aPTHZVmdnTV09C3YV6n/pb+oqmWn4uVubjCCdvFRLdI?=
 =?us-ascii?Q?qjZwSzKfMtoP6DbNb0wkY15LLfntY7OOcaKeXxF+UU8AhF1eT9dpfccB6tUy?=
 =?us-ascii?Q?b88xxGuMHyuvPNSmQJ46sF3wdoDA3AjtwDSc6Gd5P5p/eTCB6dyVPJbxFpf9?=
 =?us-ascii?Q?6+PrY0q/0+3VGppFLc2HMwLC9wbUpx0D+noReyQeqhgAACB+Sk/0HfE8zGo8?=
 =?us-ascii?Q?3wjGBsrB9ZoxvWGrNbeQWSvGsaVnKW7dRn1o2m3kHBy7vPRusnI66McqMHCQ?=
 =?us-ascii?Q?1cCn7NUn/jmfJ8uI0HyJrtyA2cT+AMjpf5Y1wXnMVLi3cSiBd9bQXXl8m2/g?=
 =?us-ascii?Q?UOZmH5OwbImbdIHeijK3R3if5gpeCsMtB8CE6ju2702CNmnkzO3GdIESvQEO?=
 =?us-ascii?Q?9e7rOME+fBafcAqac4r8OA4FZyfGSiSASsNuDZz4zYJFioyNTCi8dnk2ktwD?=
 =?us-ascii?Q?zg0cfZxjY6/9LniyAbJunAkTSl2lmAtGS0eJIcjqLnhSDNSGVe+PgolOQRIR?=
 =?us-ascii?Q?WRoNDnTm/K8PDJjkbpDx8m5BAz64KsfqZ2Ivp7AOaosSTmiHlWd3vVHfCFHn?=
 =?us-ascii?Q?IqmwqWbgls3qBUE4+ucnqshCght5M9ZzpN2ATH41EtcptPR50SWJNBQUC9CB?=
 =?us-ascii?Q?m2so6wcYqlwwGUTud0nHV6PpZvgOEAQGY0XzFnKVU09PMTgQfVVYKTxrYAWi?=
 =?us-ascii?Q?qm/u0YrUSIPLrg/7vpYSR5fb0q/nXa6HlnswNKFgGIoiDk81q8rRVfgHkHSB?=
 =?us-ascii?Q?uULEvXkMzGfROFOu1/kjY923idGSQKURiOGPAmUz9C9OjNVse8E7TLTWDqOe?=
 =?us-ascii?Q?5Wrqs/yUd849aYQhfVRcWLHIsEiQe4CHEcRY4U1cyLf4MMdxwXY3qoREeAfM?=
 =?us-ascii?Q?PsnzuflW0yUdTBcAV/w3E4Kyp0O7fLjIMKCuWNyCjVIOZkCM3bp1xUqJE6Qh?=
 =?us-ascii?Q?YozvmA8dfgbVL+oLvDs25sswMlmYcMzmsfRhGdABDjE2Z+vE+/RYIiD3/pOo?=
 =?us-ascii?Q?2zv/sY57iehiJz2mHtz8IuvIuJQkmuBgPrs1YbbjicR34yxdJswjM3vzwYJz?=
 =?us-ascii?Q?ndWqe8i2lEXOwGZYfiSfr3MxQIInsajfizKyH7cvp7tMpeNOX6ra9fRGZCvo?=
 =?us-ascii?Q?5g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ef63d50-8dc7-4b64-fc14-08dbecce8018
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7540.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 09:19:46.0631
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j5rcuQHUlswZm52pqmPPkms/G+NOgG+z+0rw8vgyTWmNt78ojGXpE7Ateettn8QoOq6GvAlzRjTSm2LrouFcCuKPbT1bId467rOTjD6HrjY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7655
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 24 Nov 2023 01:20:00 -0800 (PST)

On Fri, Nov 24, 2023 at 09:54:33AM +0800, Furong Xu wrote:
> Commit aeb18dd07692 ("net: stmmac: xgmac: Disable MMC interrupts
> by default") tries to disable MMC interrupts to avoid a storm of
> unhandled interrupts, but leaves the FPE(Frame Preemption) MMC
> interrupts enabled.

Now commit message is lacking something like "FPE MMC interrupts can cause the 
same problem", but I think it is good enough.

Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com>

> Now we mask FPE TX and RX interrupts to disable all MMC interrupts.
> 
> Fixes: aeb18dd07692 ("net: stmmac: xgmac: Disable MMC interrupts by default")
> Signed-off-by: Furong Xu <0x1207@gmail.com>
> ---
> Changes in v2:
>   - Update commit message, thanks Wojciech and Andrew.
> ---
>  drivers/net/ethernet/stmicro/stmmac/mmc_core.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c
> index ea4910ae0921..cdd7fbde2bfa 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c
> @@ -177,8 +177,10 @@
>  #define MMC_XGMAC_RX_DISCARD_OCT_GB	0x1b4
>  #define MMC_XGMAC_RX_ALIGN_ERR_PKT	0x1bc
>  
> +#define MMC_XGMAC_FPE_TX_INTR_MASK	0x204
>  #define MMC_XGMAC_TX_FPE_FRAG		0x208
>  #define MMC_XGMAC_TX_HOLD_REQ		0x20c
> +#define MMC_XGMAC_FPE_RX_INTR_MASK	0x224
>  #define MMC_XGMAC_RX_PKT_ASSEMBLY_ERR	0x228
>  #define MMC_XGMAC_RX_PKT_SMD_ERR	0x22c
>  #define MMC_XGMAC_RX_PKT_ASSEMBLY_OK	0x230
> @@ -352,6 +354,8 @@ static void dwxgmac_mmc_intr_all_mask(void __iomem *mmcaddr)
>  {
>  	writel(0x0, mmcaddr + MMC_RX_INTR_MASK);
>  	writel(0x0, mmcaddr + MMC_TX_INTR_MASK);
> +	writel(MMC_DEFAULT_MASK, mmcaddr + MMC_XGMAC_FPE_TX_INTR_MASK);
> +	writel(MMC_DEFAULT_MASK, mmcaddr + MMC_XGMAC_FPE_RX_INTR_MASK);
>  	writel(MMC_DEFAULT_MASK, mmcaddr + MMC_XGMAC_RX_IPC_INTR_MASK);
>  }
>  
> -- 
> 2.34.1
> 
>