Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp948461rdh; Fri, 24 Nov 2023 01:39:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5mSEniV+yE7jtqmW5gAStHPH6bfNo1vuZf2a8mFsEI9XDpVswbJJhtcE6vfH9BZSZbpoB X-Received: by 2002:a17:90b:350c:b0:280:ff37:8981 with SMTP id ls12-20020a17090b350c00b00280ff378981mr1799479pjb.44.1700818753887; Fri, 24 Nov 2023 01:39:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700818753; cv=none; d=google.com; s=arc-20160816; b=qZe3TELsMs1onGycxWRScBsJJWyDowCZKEU/OtLfJ/gyeh27VyzCBr7pKNXhBF7NvG L6o6h0vbq7gchF0WMw6JU8aXRoNEFVQAU2f9pXmK6flUlyMSTPG4kuS+TXjDBELDhFJq 8xlAG25zPKa/Uj5OGlfKfv2J9Au/SauLAMwJ9PEwB7Jd2V5o3+oEPglP0ozuXr29Xa1Q 027nG/RPNs2AiKuZ9Mk4qhBkem44So8JeAnDur7k9ww4YIPp77RZF+arHEXDQHEoqtLI hJhE3wqZTlkWizpsOGzbkx+FQk+mNc3xbm450ElRgf+qWOXM7wVd6CpR/1xnIvyLRSwy d6DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=geI8GtZzgpBXL5dK3wkA+z2fxGZtMOBQC6A7G59OA2k=; fh=af5YSZgJzP4WCmDlUz16YXcwyThtYFM+c5vlF94px38=; b=IT7k0BNzMbxS9gpTuLetNUwE8nlcYfUVM78oX18CmL9DKBuQD3ohZF7GuBAlzP5Arn LowR+deYCq6NCk4NNIDlhwzScdjcSlq1zPGe+EAWvib51ES4MXqx1+1l1f7iGp752u56 Fvg61qJoFxqixzj8o7RtqgSU+f2Z5aS0K+slHNKGso0UN9NP7KVdCHcpSG4N6KMi4wCR PQACq39JEZyxUdr6zvG0NxJ9MCMZaVP7h3wNjpVVd36carasPqBo00hWJybp76X9EGGq QVnUBrBhjk0zRkNGK54a5c1mKYOstCxWRThVMI/PXPwVfNxyv1gXXv0FuQYlzaXXdBeo bDlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=etL+CSQr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id j12-20020a17090a840c00b002850fa45ad1si3151318pjn.95.2023.11.24.01.39.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 01:39:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=etL+CSQr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 23E338081CDF; Fri, 24 Nov 2023 01:39:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345155AbjKXJi4 (ORCPT + 99 others); Fri, 24 Nov 2023 04:38:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbjKXJiy (ORCPT ); Fri, 24 Nov 2023 04:38:54 -0500 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DB5AD7E for ; Fri, 24 Nov 2023 01:38:54 -0800 (PST) Received: by mail-yb1-xb34.google.com with SMTP id 3f1490d57ef6-da3b4b7c6bdso1609670276.2 for ; Fri, 24 Nov 2023 01:38:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700818733; x=1701423533; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=geI8GtZzgpBXL5dK3wkA+z2fxGZtMOBQC6A7G59OA2k=; b=etL+CSQrBatydm0PGGfHEH9tq/QRETNazIDKmg5AesapV+i2MRq+fnshfUTJaUaYjZ Jyd9CBHN0nS8g0fGSRgwu79Fct7LDyMn7ni50M8TqPB2TfPiYqcn8Yix2Xh1Hp7EyZZ5 I8ZuJdcJMMSRA/stKrj3j2aqvygpb+COFwkh1JSn11nOI/cfd0MypYJmTS9ot0fV0oA7 lZIBBV59VHdZ92Ej2DppxxKY/Dm3sfSp+QfmL7SJctQVLCZaBViSQVZzJ8Dyeogzlb4F SiNtn7aq/8k5Cl+hGYGsM/bJdUvezST/pU6OJSptuMPbDsfuQSbunzlVocT+K+2HbSdZ nUuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700818733; x=1701423533; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=geI8GtZzgpBXL5dK3wkA+z2fxGZtMOBQC6A7G59OA2k=; b=eGPCDFgVwehF0S8+dmLOk+4Gpg60PqqeV1v3OYJqEsRDLNfp3FqX2MAGfDXkOed1bq 9huIl6oKwW64DAvJcBUwtExUagVrrjIwk+gZJTRneHnqskEDAAhNGcj8+/IMl3Ow7G/P ojnMFcONWZVlEPpNqod83gG23qspgBYL1XY5IsHFpSQGadwTcPmT18cAfDF1K8cU0ol3 xlYzPaUBDlTb9O/y9wVka6V/UMf+ueihjJxqci6BPnvw8k30dKWBWpp/BHmb+C09vqtd +zq6LSIS0FPCsPRnh6/7Itd2g88AVVKGyXxcJ8FhPCrpvtrvesyDsXxRtUP6AwXU4wI8 gq/w== X-Gm-Message-State: AOJu0YxpQk6Kq0LAfEhKkKLHJrLnrTSqTgErJO5z2DgcnGhJkQTKCkH0 4oF10y+UI3wXI7ftMgdZz4wZb5p2WIb3urp6IXv4JA== X-Received: by 2002:a05:6902:49:b0:d9a:cd50:b99a with SMTP id m9-20020a056902004900b00d9acd50b99amr1760789ybh.12.1700818733666; Fri, 24 Nov 2023 01:38:53 -0800 (PST) MIME-Version: 1.0 References: <20231116111441.2339-1-tychang@realtek.com> <20231116111441.2339-3-tychang@realtek.com> In-Reply-To: <20231116111441.2339-3-tychang@realtek.com> From: Linus Walleij Date: Fri, 24 Nov 2023 10:38:42 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] Add GPIO support for Realtek DHC(Digital Home Center) RTD SoCs. To: Tzuyi Chang Cc: Bartosz Golaszewski , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 24 Nov 2023 01:39:10 -0800 (PST) Hi Tzuyi, On Thu, Nov 16, 2023 at 12:14=E2=80=AFPM Tzuyi Chang = wrote: > This driver enables configuration of GPIO direction, GPIO values, GPIO > debounce settings and handles GPIO interrupts. > > Signed-off-by: Tzuyi Chang Apart from the missing kerneldoc that the autobuilder is complaining about this looks good to me. If you fix the kerneldoc: Reviewed-by: Linus Walleij Yours, Linus Walleij