Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp948892rdh; Fri, 24 Nov 2023 01:40:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IErEan2W99y2f5ETxsXK8uh7LuJCbt1D9ocS/69FDOLzBiVvxzydb5TMVRJWeyrtjd4C8gE X-Received: by 2002:a05:6a00:1797:b0:6cb:d28f:d91e with SMTP id s23-20020a056a00179700b006cbd28fd91emr2433958pfg.25.1700818810219; Fri, 24 Nov 2023 01:40:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700818810; cv=none; d=google.com; s=arc-20160816; b=Iqf4K+TXHGlRFt148DfHtFVdoj26wH0NnvvH+ja+gqebt1sjlnINI1GBtuqWWNTD4d 84HeGpl5BIrsvxhQBvWd8LZofQGhGUgyMCmLL6KqvmCDDZB9PC7KMK1j1xK70cWZtMZo IiBnLCKslxHKHKLxcG6CQI+/bRfpU9aZgufhkXtR/0rrF3L45ntjQKzGOeqRGzKE7DHs MjPK9X45RbiDNCbONqITFSuCSRRj/olQqKFk45zRxUmRUg1o6B5T+5qZYegi31rs6sR2 PdhZPLPZ2hntZ3w/dett2+yDzltYZD25MLCTuxwncicOrLEjBSqEcsiyvjyt5NCaEmU0 Rbcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=S8H5wgkG7B5BzheZ4ZvCgLtyGDS/xoXFDJfUCvqhL0U=; fh=hdqFnmdMaSsJOCELlJhVBQe4BUIAYe0TRI7pjAKgpfw=; b=1EhccMm3yuh0wZ4ZhWX+ysu0FO41u5MuKmFMuonBXrLIyX0XGLmPh0xSIOT3genbvA 39RAd/v+LmCjj4575dIh3FCBcdlWvzvyr7HPLPUmQL989I0vGcCjLnKrz49gduiP2RAX zHDaJGvA+HyiHANIkMavVsJDC/HGndmLNaAX5qsYismlilRAVLMosxjXfGjO/QHArZcu hhoZNqa8xbJizIGhqRL+r7WVm3MZlwKYqc8tFIsi2WaftFGJwzQGO1cG7rdl5h3BrJdn Tyu5206iiYf+YRq50NZR/S9RPwZqnGgIiGjXTTW5jk8ptfr5vMlwYEuGBqyuoP1xj4jr o4WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uEVLiLTr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id fh41-20020a056a00392900b006b9fd40d6cfsi3189444pfb.216.2023.11.24.01.40.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 01:40:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uEVLiLTr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id BD219808EDFE; Fri, 24 Nov 2023 01:40:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345148AbjKXJjw (ORCPT + 99 others); Fri, 24 Nov 2023 04:39:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbjKXJju (ORCPT ); Fri, 24 Nov 2023 04:39:50 -0500 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68AF3D54 for ; Fri, 24 Nov 2023 01:39:57 -0800 (PST) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-5cce3010367so15926987b3.0 for ; Fri, 24 Nov 2023 01:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700818796; x=1701423596; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=S8H5wgkG7B5BzheZ4ZvCgLtyGDS/xoXFDJfUCvqhL0U=; b=uEVLiLTrQQm2ABtQxxbZHX/oaIT1H7v3NBxWp8DymXauXBftnscQqfVGXQxhSomCWB E/5cYEiAwxnwL+vY1ECJNOQTTcE8mb8kDH5+2RuJCrqRybpRq3nqk5R8sInwpxrNNqtL S9/M/Arl2O2Jr6tz4AQdFzDw8PfSuuY19P2vTUVDVppqR9urVWjiWX8xHdTy626293aj Au0CuTiVFtbZVAmmREm9hOTbojET/Ficmor/dfsPfNblSHQqjfKojjJzTWU17XlESjo2 R2CEGReh44zKpzUkiXYdHzL8it5jGL2JE7Nocr5VsFcwjYoe8vIgB/eBZnL7NgXQeF80 KbQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700818796; x=1701423596; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S8H5wgkG7B5BzheZ4ZvCgLtyGDS/xoXFDJfUCvqhL0U=; b=HIA9uetoUPZOofc2EEJNExK673kUoq+DWEN/e3cy3jjBL8aybJ1i27eIGFB1cWfvtQ bdVIfTcL9FhZHAcD+zQCzTk+KyjPrU/nck/VApP7PvQN/WWOSiwD1i8+x+gqTWGOZPlw nK3a2WxPWNxKaTqSJnhTqhVG1jeJnfoi8dUqidcq3iOETKSErz8HXATUmcaZ8k6OGDqo BiKSfckb09B5qtGYdKa6TVPj2dZDKXJjnHfSrRORsWMdOkMuFWl2zASP5DBI03KzgU/c gu5nKGbhW/gyfmaCS319OXkohBPkvAcrKwFsbbHpIlt3xR/Q7L9FLGIe+fF6xa61+5gj sMEw== X-Gm-Message-State: AOJu0YwGUwR1U0Gs3iQ6gsApM31g9ymziQaJTmoYLepEaZHUHd0SAtT0 /oLPf5okTIVut9sPP0yOQLjKdjw0PpJHkKbA1Qhy5v7iG8up/K/y X-Received: by 2002:a05:690c:2c0b:b0:5c6:4de5:168f with SMTP id eo11-20020a05690c2c0b00b005c64de5168fmr1651678ywb.10.1700818796617; Fri, 24 Nov 2023 01:39:56 -0800 (PST) MIME-Version: 1.0 References: <20231121091107.5564-1-tychang@realtek.com> In-Reply-To: <20231121091107.5564-1-tychang@realtek.com> From: Linus Walleij Date: Fri, 24 Nov 2023 10:39:45 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: realtek: Fix logical error when finding descriptor To: Tzuyi Chang Cc: Dan Carpenter , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 24 Nov 2023 01:40:07 -0800 (PST) On Tue, Nov 21, 2023 at 10:11=E2=80=AFAM Tzuyi Chang = wrote: > The pin descriptor should be returned if the name has been found in the > descriptor table. Remove the negation in the if statement for accurate > retrieval. > > Fixes: e99ce78030db ("pinctrl: realtek: Add common pinctrl driver for Rea= ltek DHC RTD SoCs") > Signed-off-by: Tzuyi Chang Patch applied for fixes! Yours, Linus Walleij