Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp949824rdh; Fri, 24 Nov 2023 01:42:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IExd+LstpE3E4IRjIu18ZJzu8FfLxnzhEexR5lBgP/5JvYrIdH7k5Mpcf9ZPz/sFq2BBAGY X-Received: by 2002:a05:6a00:a22:b0:6cb:d24c:4a9f with SMTP id p34-20020a056a000a2200b006cbd24c4a9fmr2740191pfh.29.1700818934551; Fri, 24 Nov 2023 01:42:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700818934; cv=none; d=google.com; s=arc-20160816; b=IfrkWL4n0ADWp9DRFFF7u9b+bXNqe+qhXKiHGEwYLWfkJ1O+9zEIBODLpt4uy2nsDQ EU+Xu1OoMlEoKi3frmuTBxx7jh7aW+CSpV5UIf3JaxQZOtd+kaiDkkRNMd8NguKTacvT 30FaE+xjsZKcrq+2NOa8s41asfl2nZkxtEZxwng5bYude0wC2opJWagZzfWZ0WTCS1EK ynN8law18yviZJhT+3b1gBVhZNgvcEggwweHRKZ52NzTv8ZNR57dUFnFIURvaPnw40SQ DVBPwk8am9lO0gHYi00GfoPQrAoojTeNgLHZi9gt+SqOz2NR+ptYOVB3ZMHB38OGppg6 6uoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=s4SI9p0/D+Tl9WXxDjh8yU/Je1TY6XTCkgPMRok5amE=; fh=b77tZpM7mucn1fQym20myN45Q/4ueHs8lwghw5CiR2Y=; b=sw++k4ULDGZYxOkwHBKwn1mwB3XYNi4ERNfAR82hma7b3jzdxjtENQ3pVCuXfRvKdD TJDkPVGLZXU4kOjWl+OXWKeGwpsS8Zw+Tp1sUOsUNY7ya98zuIZPbWVadyZsjRdNMFRX sc5bMDkWpNf22TzlKZzW8RvugNZJJqQR1NDr9qNnxH+GZgpKkR8Zcu2AxHjG9pKEoEKx 39VpaAIa7hAxbekOEVnfG5TWACcLTtuupmB1CKLWErDDDQAybfZudPooeZG0Jm99Ip2b b8SALa1Gd6a++e5QRMfAPnpZsgvCciUJriUpCNoegimw+y0+gdYdL/I0ehjzv72EglrB PDWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id n4-20020a632704000000b005c1e762bc50si3066017pgn.742.2023.11.24.01.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 01:42:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id B849A82F875C; Fri, 24 Nov 2023 01:42:08 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345148AbjKXJlg (ORCPT + 99 others); Fri, 24 Nov 2023 04:41:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229708AbjKXJld (ORCPT ); Fri, 24 Nov 2023 04:41:33 -0500 X-Greylist: delayed 331 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 24 Nov 2023 01:41:40 PST Received: from mail.lichtvoll.de (lichtvoll.de [IPv6:2001:67c:14c:12f::11:100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 092BCD54; Fri, 24 Nov 2023 01:41:39 -0800 (PST) Received: from 127.0.0.1 (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by mail.lichtvoll.de (Postfix) with ESMTPSA id 536DB81E3F3; Fri, 24 Nov 2023 10:36:06 +0100 (CET) Authentication-Results: mail.lichtvoll.de; auth=pass smtp.auth=martin smtp.mailfrom=martin@lichtvoll.de From: Martin Steigerwald To: Cedric Blancher , Al Viro Cc: linux-fsdevel , Linux Kernel Mailing List Subject: Re: d_genocide()? What about d_holodomor(), d_massmurder(), d_execute_warcrimes()? Re: [PATCH 15/20] d_genocide(): move the extern into fs/internal.h Date: Fri, 24 Nov 2023 10:36:05 +0100 Message-ID: <10399078.nUPlyArG6x@lichtvoll.de> In-Reply-To: <20231124074856.GA581958@ZenIV> References: <20231124060553.GA575483@ZenIV> <20231124065759.GT38156@ZenIV> <20231124074856.GA581958@ZenIV> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 24 Nov 2023 01:42:09 -0800 (PST) Al Viro - 24.11.23, 08:48:57 CET: > On Fri, Nov 24, 2023 at 06:57:59AM +0000, Al Viro wrote: > > > > +extern void d_genocide(struct dentry *); > > > > > > Seriously, who came up with THAT name? "Genocide" is not a nice > > > term, > > > not even if you ignore political correctness. > > > Or what will be next? d_holodomor()? d_massmurder()? > > > d_execute_warcrimes()?> > > kill_them_all(), on the account of that being what it's doing? > > To elaborate a bit: what that function does (well, tries to do - it has > serious limitations, which is why there is only one caller remaining and > that one is used only when nothing else can access the filesystem > anymore) is "kill given dentry, along with all its children, all their > children, etc." I never got why in the context of computers anything is ever being killed. It does not live to begin with. You can stop something, remove it, delete it, destroy it, pause it, resume it, overwrite it and you can do it really quickly or (almost) instantly or slowly or recursively or some combination of those, but kill? You cannot kill what does not live. d_delete/destroy/remove_recursively() could be a suitable function name. Pick one. Similar it is with the term children or parent. There are no children in computer software. Period. But here it may be more difficult to find alternative wording. Would still be good to find something, cause I was quite taken aback by the wording of the OOM killer. (Actually I was taken aback that an operating system could even have something that forcefully quits a process without saving data. It never matched my expectations of reliability and stability.) So how about stopping to put meaning into computer software source code that simply is not there to begin with? How about starting to use terms that describe what is actually being done and what is actually there? -- Martin