Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Fri, 24 Nov 2023 17:49:06 +0800
From:   kernel test robot <lkp@intel.com>
To:     Justin Lai <justinlai0215@realtek.com>, kuba@kernel.org
Cc:     oe-kbuild-all@lists.linux.dev, davem@davemloft.net,
        edumazet@google.com, pabeni@redhat.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        andrew@lunn.ch, pkshih@realtek.com, larry.chiu@realtek.com,
        Justin Lai <justinlai0215@realtek.com>
Subject: Re: [PATCH net-next v12 12/13] realtek: Update the Makefile and
 Kconfig in the realtek folder
Message-ID: <202311241318.bdYlmH2b-lkp@intel.com>
References: <20231123124313.1398570-13-justinlai0215@realtek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231123124313.1398570-13-justinlai0215@realtek.com>
Precedence: bulk

Hi Justin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Justin-Lai/rtase-Add-pci-table-supported-in-this-module/20231123-204759
base:   net-next/main
patch link:    https://lore.kernel.org/r/20231123124313.1398570-13-justinlai0215%40realtek.com
patch subject: [PATCH net-next v12 12/13] realtek: Update the Makefile and Kconfig in the realtek folder
config: csky-randconfig-r081-20231124 (https://download.01.org/0day-ci/archive/20231124/202311241318.bdYlmH2b-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231124/202311241318.bdYlmH2b-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311241318.bdYlmH2b-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/realtek/rtase/rtase_main.c:2318:12: warning: 'rtase_resume' defined but not used [-Wunused-function]
    2318 | static int rtase_resume(struct device *device)
         |            ^~~~~~~~~~~~
>> drivers/net/ethernet/realtek/rtase/rtase_main.c:2305:12: warning: 'rtase_suspend' defined but not used [-Wunused-function]
    2305 | static int rtase_suspend(struct device *device)
         |            ^~~~~~~~~~~~~


vim +/rtase_resume +2318 drivers/net/ethernet/realtek/rtase/rtase_main.c

8f9d7c2677f7dc Justin Lai 2023-11-23  2304  
da2f11aefe82ee Justin Lai 2023-11-23 @2305  static int rtase_suspend(struct device *device)
da2f11aefe82ee Justin Lai 2023-11-23  2306  {
da2f11aefe82ee Justin Lai 2023-11-23  2307  	struct net_device *dev = dev_get_drvdata(device);
da2f11aefe82ee Justin Lai 2023-11-23  2308  
da2f11aefe82ee Justin Lai 2023-11-23  2309  	if (netif_running(dev)) {
da2f11aefe82ee Justin Lai 2023-11-23  2310  		netif_stop_queue(dev);
da2f11aefe82ee Justin Lai 2023-11-23  2311  		netif_device_detach(dev);
da2f11aefe82ee Justin Lai 2023-11-23  2312  		rtase_hw_reset(dev);
da2f11aefe82ee Justin Lai 2023-11-23  2313  	}
da2f11aefe82ee Justin Lai 2023-11-23  2314  
da2f11aefe82ee Justin Lai 2023-11-23  2315  	return 0;
da2f11aefe82ee Justin Lai 2023-11-23  2316  }
da2f11aefe82ee Justin Lai 2023-11-23  2317  
da2f11aefe82ee Justin Lai 2023-11-23 @2318  static int rtase_resume(struct device *device)
da2f11aefe82ee Justin Lai 2023-11-23  2319  {
da2f11aefe82ee Justin Lai 2023-11-23  2320  	struct net_device *dev = dev_get_drvdata(device);
da2f11aefe82ee Justin Lai 2023-11-23  2321  	struct rtase_private *tp = netdev_priv(dev);
da2f11aefe82ee Justin Lai 2023-11-23  2322  	int ret;
da2f11aefe82ee Justin Lai 2023-11-23  2323  
da2f11aefe82ee Justin Lai 2023-11-23  2324  	/* restore last modified mac address */
da2f11aefe82ee Justin Lai 2023-11-23  2325  	rtase_rar_set(tp, dev->dev_addr);
da2f11aefe82ee Justin Lai 2023-11-23  2326  
da2f11aefe82ee Justin Lai 2023-11-23  2327  	if (!netif_running(dev))
da2f11aefe82ee Justin Lai 2023-11-23  2328  		goto out;
da2f11aefe82ee Justin Lai 2023-11-23  2329  
da2f11aefe82ee Justin Lai 2023-11-23  2330  	rtase_wait_for_quiescence(dev);
da2f11aefe82ee Justin Lai 2023-11-23  2331  
da2f11aefe82ee Justin Lai 2023-11-23  2332  	rtase_tx_clear(tp);
da2f11aefe82ee Justin Lai 2023-11-23  2333  	rtase_rx_clear(tp);
da2f11aefe82ee Justin Lai 2023-11-23  2334  
da2f11aefe82ee Justin Lai 2023-11-23  2335  	ret = rtase_init_ring(dev);
da2f11aefe82ee Justin Lai 2023-11-23  2336  	if (ret) {
da2f11aefe82ee Justin Lai 2023-11-23  2337  		netdev_err(dev, "unable to init ring\n");
da2f11aefe82ee Justin Lai 2023-11-23  2338  		rtase_free_desc(tp);
da2f11aefe82ee Justin Lai 2023-11-23  2339  		return -ENOMEM;
da2f11aefe82ee Justin Lai 2023-11-23  2340  	}
da2f11aefe82ee Justin Lai 2023-11-23  2341  
da2f11aefe82ee Justin Lai 2023-11-23  2342  	rtase_hw_config(dev);
da2f11aefe82ee Justin Lai 2023-11-23  2343  	/* always link, so start to transmit & receive */
da2f11aefe82ee Justin Lai 2023-11-23  2344  	rtase_hw_start(dev);
da2f11aefe82ee Justin Lai 2023-11-23  2345  
da2f11aefe82ee Justin Lai 2023-11-23  2346  	netif_wake_queue(dev);
da2f11aefe82ee Justin Lai 2023-11-23  2347  	netif_device_attach(dev);
da2f11aefe82ee Justin Lai 2023-11-23  2348  out:
da2f11aefe82ee Justin Lai 2023-11-23  2349  
da2f11aefe82ee Justin Lai 2023-11-23  2350  	return 0;
da2f11aefe82ee Justin Lai 2023-11-23  2351  }
da2f11aefe82ee Justin Lai 2023-11-23  2352  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki