Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Fri, 24 Nov 2023 15:55:25 +0530
From:   "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To:     Huang Rui <ray.huang@amd.com>
Cc:     "Karny, Wyes" <Wyes.Karny@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq/amd-pstate: Fix the return value of
 amd_pstate_fast_switch()
Message-ID: <ZWB6Fb3KcqC1fqbD@BLR-5CG11610CF.amd.com>
References: <20231123082757.3527-1-gautham.shenoy@amd.com>
 <ZWAlXl6MP20khEwB@BLR-5CG13462PL.amd.com>
 <ZWBRVlxBxb6DW+3P@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZWBRVlxBxb6DW+3P@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TUaYcRXFLRG4+w7OrHaDYZE9MpZ9L4OjFbasWdNBgQuS7t03TZfarQvr4qE2?=
 =?us-ascii?Q?6HoWfPYiq3DMxXvhr+BMdXuMwwg/tb1sWQbREcw9Ty/HOYLY0qtj5YZH1WSQ?=
 =?us-ascii?Q?7ePvIIQYuMTOldZX2SdwAzhijpPmljjTUxSnkp81328j0ZUIpQknNvissY59?=
 =?us-ascii?Q?PPkrAlY7npayvDk6ukP1qUa+oNDmQZs5Cj0a/Ft+PehaQXi6VI6yfelIkLpE?=
 =?us-ascii?Q?17jAxChru5P3PyWtfT2D385SrYJQ8c5O9uw6M/DOwP5m9J9zn7hkVYZRVUT6?=
 =?us-ascii?Q?Dr8g71d4ZEmT7GRWvYC8VnSa7aKWj+OoyEZad0Tgxc2wDPq9d04Ybodx5jm8?=
 =?us-ascii?Q?JpyPv/2DR+GKwuQ4fMXQh7LQwH5DOCwxdC6KosjGIkxwofB7eD+3ye7lj7Oh?=
 =?us-ascii?Q?Q5A/U8XxmgAOkxVKKmExHkt+WMinBA9L0MVP1guSeT4KO0/X0gbdSJOQ0/hA?=
 =?us-ascii?Q?ERXRdwVtSKHzF4z0dOyqiOu4h8iqypKhjCM083mO5JfDyEOyV20QpbInnn5i?=
 =?us-ascii?Q?MO7K/E/6/PNAfHUpjHt/9KCJhCqHEYiF/Dp2Uw21LRe6JgrpfpHVha7kgZgp?=
 =?us-ascii?Q?3nl43nsNauxbIt9diAaRQjN2TLvUoi4PWlAE4XMvRMd2c2QbIRKkjxV0GPEw?=
 =?us-ascii?Q?yn3Ws0/ZkU1LwFB44v/7+xW2T8k5RQIiJ+c+EF6udb4LEb3rdb5e1CApAY43?=
 =?us-ascii?Q?0eObMv6YanXwZw6cBxQG2pVvhfH5dyUB2OYRaUuYWDhr2Ce0lXmx1+QEYTna?=
 =?us-ascii?Q?0LfXB3IKdZKkpojWk0dHbgPHqGzCSRVSmb2wjEYJ9wddoOYPBKFpa1QKuooh?=
 =?us-ascii?Q?9UJKBTTfjZJo5s5ovK0P6tMWG20whuoGvsKLghOMrgmUjDwCXbOZtIbsLV5S?=
 =?us-ascii?Q?waYVBiOVWu3+t/oRvtBzJRiI8NSZE1XeyP+xT+H+Q+pFBc8sMn8GLXbKgDBO?=
 =?us-ascii?Q?5ggNDy03+mT73gt2CycBbsJh+0eVHAEyHrb3eOzwq7LN/eY+jYZLgSsEPYAR?=
 =?us-ascii?Q?klCDuvaKYhlqQ0UxYZMXp9hb8PisooCTgqZDq3xH+QeGSnKhi3KEHDt/wENB?=
 =?us-ascii?Q?VVNvVtOAG4Z6l96Pr6gusTk3IR5VzBfiiI5M6QWLnO1OcoqKEv+s5KfjHrfV?=
 =?us-ascii?Q?z4ToRX7gi4LIZiL7tog1Tytk5N8I5bT+x4+XlFies2eNBVfAWDEmx6qiZqVj?=
 =?us-ascii?Q?rUm75e6kpXLHWAmgJ1uDxQdpybe0LAK5Wdv7/G95Qq3sbqY2ZAkp6UYbJl+Q?=
 =?us-ascii?Q?S99XcqIVGkgcQwdsZHN6vfh3DydmwiKhOCNMrRsPbYlHBasSOoJEUuN/ufig?=
 =?us-ascii?Q?vtV1OFANIb+db22qaezY+cQXZ0m4EjsitYPk2aqAixH5OblNdk2Bruk3OZCg?=
 =?us-ascii?Q?MZh7qfeFP55dom7VEQtNGC+hhV0jwTdg525u4gxZOCCsN/rPwp7t6CVCZrQC?=
 =?us-ascii?Q?jiBxya1EMXWfeXHBqUO6NpicU5juWrFOoyQHp/4IwK9FyDuifYiju8+QM51Z?=
 =?us-ascii?Q?x7/RKP07V9R2qGnaCgfLlNO5uFpYEZdslhQXQ8X+y1OnecxdvRgbC+DWteWG?=
 =?us-ascii?Q?skqwusOtL1c7P6YUbO9fPVa2rnqQBVbQzbdVYN4o?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 677dd298-94a2-411b-2e60-08dbecd7b15a
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 10:25:34.1881
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SwLHtPUagDusg29EDl4RwbwvTXDJp35u1Qa0+uPoiaC3QDLmj92nQ+GOM5tSMI50L5sZmDt6SBRNI1pf4e/krw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8988
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 24 Nov 2023 02:25:52 -0800 (PST)

On Fri, Nov 24, 2023 at 03:31:34PM +0800, Huang Rui wrote:
> On Fri, Nov 24, 2023 at 12:23:58PM +0800, Karny, Wyes wrote:
> > On 23 Nov 13:57, Gautham R. Shenoy wrote:
> > > cpufreq_driver->fast_switch() callback expects a frequency as a return
> > > value. amd_pstate_fast_switch() was returning the return value of
> > > amd_pstate_update_freq(), which only indicates a success or failure.
> > > 
> > > Fix this by making amd_pstate_fast_switch() return the target_freq
> > > when the call to amd_pstate_update_freq() is successful, and return
> > > the current frequency from policy->cur when the call to
> > > amd_pstate_update_freq() is unsuccessful.
> > > 
> > > Fixes: 4badf2eb1e98 ("cpufreq: amd-pstate: Add ->fast_switch() callback")
> > 
> > Reviewed-by: Wyes Karny <wyes.karny@amd.com>
> > 
> 
> Acked-by: Huang Rui <ray.huang@amd.com>

Thanks!
> 
> Do you want to cc stable mailing list to fix it in stable kernels?

Yes, I forgot to do that. I will send a v2 having collected your
Acked-by and the Reviewed-by's from Perry and Wyes.

> 
> Thanks,
> Ray

--
Thanks and Regards
gautham.