Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp982246rdh; Fri, 24 Nov 2023 02:40:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/+qNxr/QXZP8iY/OdHLNPFdhuzfbWdmFmMK8xsH7rBFXUDKOj+fI7lzX3EtZfAMFXTMda X-Received: by 2002:a05:6a20:1587:b0:18b:f075:7e0e with SMTP id h7-20020a056a20158700b0018bf0757e0emr1404013pzj.32.1700822439540; Fri, 24 Nov 2023 02:40:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700822439; cv=none; d=google.com; s=arc-20160816; b=TGRWW3jXXDYFGTd2V204/bpmbun+Kf0osuXys3jVBLlBhBuketCYG+mYlKojhpAmR0 qoMtMURX0kGrfobyOu74RA28+DntkPGskYo2Oby26wY3z1CaJa7lrJNBLUANap+lMxyO NeoY8fM5lkXZmind+pxWcget/sgnN1h6XvwrCztBBeiNAu4IHTq0tmXtTk8JwPI/Bcsi 7eaCHCFeiZC1v1zPZ9bJX6QrA0+m5pWpRld1JxGNWVFQDdgSyGSFHdjTiop66cv2wbV+ OxiaIrLqYGXqVtEdbXpUQvHkyH6l/Y5dnisQzA1VdHa/MOZLthD/a4hmz1XP01Qz+X/+ qYhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:references :in-reply-to:subject:to:from:date:message-id:dkim-signature; bh=y+1TDiBAnMt4VxdCKGR5QS2biqH47tvAiQJ9i4yez2Y=; fh=Icg4OCv3shlK+ohy8wXXNa3gywwOYw505cpR7znLGl4=; b=MuLcBRRY8ZaNpjCc+dCEeO5aHpiZvWAdcbCV8laJkJe/Y9rMTzWhGrgaX7xXIvI6Dc S9n52iwE49STPpjVztBlMu6HfQ5s1E3wXjkfpC7bOAEI6wdgVPPSqTirh7br8XyGVT3G FLz2V+qnMU/s9nuUm7g9KJTdrJ+mkNaPxzlTRgLxsJ/BYlXJi5irfSqvICBhJAzbV4Q5 9w3Toh1Dwls/XvRNUCFJ6J3beU7T8dHgHtWfor9olabRLIBBxlqGxoxeb4VYJ2O1eEGd LxxGCkBvwORbhUH1X87U+7McQfNExjZB929ClY9yGEgAza8PxGcwZeYxgFmUxnKiuzM1 llqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="p/qa+RJd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id x28-20020aa79a5c000000b006cb66a1fa04si3141157pfj.33.2023.11.24.02.40.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 02:40:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="p/qa+RJd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 5102F83BC6F7; Fri, 24 Nov 2023 02:40:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345606AbjKXKkX (ORCPT + 99 others); Fri, 24 Nov 2023 05:40:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345599AbjKXKkV (ORCPT ); Fri, 24 Nov 2023 05:40:21 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54EDC1AE for ; Fri, 24 Nov 2023 02:40:28 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0480C433C7; Fri, 24 Nov 2023 10:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700822428; bh=y+1TDiBAnMt4VxdCKGR5QS2biqH47tvAiQJ9i4yez2Y=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=p/qa+RJdm7WokbrVvywi9obaB050hb9y0zng38ZwWloP45PRz9232CjxOYzodFL8L gRibElH+QG/dcvyBOrWEQED3vZjkhgtvRO5jbcTTOzHXl8kJR/SHt51HgicJgDeK6t FnC5SWQYnR15tJhpZFgGipbCieJveCjAfpWuZzbnyF8RPh5dDt99LCC65nIFbYNSp6 FiGYFMdrKwQ+xpUTiO5gbQVwNBlfKEcl39Y3h01GRO/KwBKd71tFV3ohenFQK4m8d0 RyxAnwN1W8Rv+7n6JjcXMwcWRNcuP1XBOes1rA1hxsvmlCZYCapgbcKHVP/vT17+SO ojiNCUBS7DoLg== Message-ID: <74226af80ecee1c3544c1bcf66565514.mripard@kernel.org> Date: Fri, 24 Nov 2023 10:40:25 +0000 From: "Maxime Ripard" To: "Dmitry Osipenko" Subject: Re: [PATCH v18 05/26] drm/shmem-helper: Remove obsoleted is_iomem test In-Reply-To: <20231029230205.93277-6-dmitry.osipenko@collabora.com> References: <20231029230205.93277-6-dmitry.osipenko@collabora.com> Cc: dri-devel@lists.freedesktop.org, kernel@collabora.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, "Boris Brezillon" , "Chia-I Wu" , =?utf-8?b?Q2hyaXN0aWFuIEvDtm5pZw==?= , "Daniel Vetter" , "David Airlie" , "Emma Anholt" , "Gerd Hoffmann" , "Gurchetan Singh" , "Maarten Lankhorst" , "Maxime Ripard" , "Melissa Wen" , "Qiang Yu" , "Steven Price" , "Thomas Zimmermann" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 24 Nov 2023 02:40:37 -0800 (PST) On Mon, 30 Oct 2023 02:01:44 +0300, Dmitry Osipenko wrote: > Everything that uses the mapped buffer should be agnostic to is_iomem. > The only reason for the is_iomem test is that we're setting shmem->vaddr > to the returned map->vaddr. Now that the shmem->vaddr code is gone, remove > the obsoleted is_iomem test to clean up the code. >=20 >=20 > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime