Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1015368rdh; Fri, 24 Nov 2023 03:32:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNMv8rkiL/PjCFdL+l+VqXn+QSyjDsYyhUB4a1zVxMX0l8oc54hNJEDeBNkjAdjVxHoqcQ X-Received: by 2002:a05:6e02:1a2b:b0:34f:2756:8fd with SMTP id g11-20020a056e021a2b00b0034f275608fdmr2522039ile.9.1700825535748; Fri, 24 Nov 2023 03:32:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700825535; cv=none; d=google.com; s=arc-20160816; b=I4PtPFH3eEBSSXKjXl9dUE3ShaSWimS9TmtraLwbDHXP8RLQeu7YWQK769eKj+PTPv /JlSMOZBoanBvxWkIYTlKdagiDGk7HPB7BZtISlmENH51lJTI+JVWposH2I0+DFjMHXG e2A0cxlq1SyFoePhYnHk5RI2ePabA3DsVJ7WYAtxrAKuLaMaBwN/m4/9nBHxhSLxk9dx i5UzwT0pRY8bGT5BLhliYjKCpGk8K1zzVg/ItVtUARa65ICb7n4vmJGd2H74Oc7LyKUW MRMNuSwtOMJE7h/e4vgCIbQV/qrisEqBc9freXu1Ww8Iz2q88JzwzvKLiI5TAjLvVAd9 TWbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ln++9QARH+w1/fjLxBRFi2CjigajCw2fSbA5owLj8YU=; fh=M7PL738PFkMHEpyyixWA1tRNbDgP8QjiHVX5D2t/uok=; b=Azm1QptJf8R6RHfs7AAumqKhiwDtHjXIR1qURWAgDZS1GYtwFtxGKB5+XZwbOrJDER 36C+PSMU+DQZju6y5y/SqXa3Uv+Ri5Sv+LNYDziQORXxoMgYWa9STCsqQGD8KB8MnOig 9iaLhlT1FtRN5HQijuheFtLTAZq23nBBPTuO814OL1dNAC5k5GpuE/b+fE+s+N21WNrH P/FUl3eoGm0WZKxN5YxF3i8pwP6VYvrH77PfO7F6TqeWt+RPeuFFBVz7ded/h2b71HXu 5p2MFvIaS5EK00f8rBA3x/llWuf4mecx02b9K1F0+Vxk9hhim48sVqxoYqz7cQxaS/8q 30pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id cn2-20020a056a020a8200b005b8f401a3a6si3439126pgb.41.2023.11.24.03.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 03:32:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 76EFA8020BEC; Fri, 24 Nov 2023 03:31:46 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230334AbjKXLbc (ORCPT + 99 others); Fri, 24 Nov 2023 06:31:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbjKXLb3 (ORCPT ); Fri, 24 Nov 2023 06:31:29 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 473B710DB; Fri, 24 Nov 2023 03:31:35 -0800 (PST) X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="395225662" X-IronPort-AV: E=Sophos;i="6.04,223,1695711600"; d="scan'208";a="395225662" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2023 03:31:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="771235102" X-IronPort-AV: E=Sophos;i="6.04,223,1695711600"; d="scan'208";a="771235102" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2023 03:31:31 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r6UPB-0000000GhXG-1NjR; Fri, 24 Nov 2023 13:31:29 +0200 Date: Fri, 24 Nov 2023 13:31:29 +0200 From: Andy Shevchenko To: Linus Walleij Cc: Tzuyi Chang , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] Add GPIO support for Realtek DHC(Digital Home Center) RTD SoCs. Message-ID: References: <20231116111441.2339-1-tychang@realtek.com> <20231116111441.2339-3-tychang@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 24 Nov 2023 03:31:46 -0800 (PST) On Fri, Nov 24, 2023 at 10:38:42AM +0100, Linus Walleij wrote: > On Thu, Nov 16, 2023 at 12:14 PM Tzuyi Chang wrote: > > > This driver enables configuration of GPIO direction, GPIO values, GPIO > > debounce settings and handles GPIO interrupts. > > > > Signed-off-by: Tzuyi Chang > > Apart from the missing kerneldoc that the autobuilder is complaining about > this looks good to me. If you fix the kerneldoc: > Reviewed-by: Linus Walleij I think I might have comments in the future. I haven't looked at the series due to noticing LKP complains. -- With Best Regards, Andy Shevchenko