Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <9c41d1ce-d4e7-efca-1be0-ddf296f59ac8@quicinc.com>
Date:   Fri, 24 Nov 2023 17:04:28 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH V2 4/4] clk: qcom: videocc-sm8150: Add runtime PM support
Content-Language: en-US
To:     Konrad Dybcio <konrad.dybcio@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
CC:     <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>
References: <20231118123944.2202630-1-quic_skakitap@quicinc.com>
 <20231118123944.2202630-5-quic_skakitap@quicinc.com>
 <9710258c-3419-41f2-9b30-f818b031ae5f@linaro.org>
From:   "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>
In-Reply-To: <9710258c-3419-41f2-9b30-f818b031ae5f@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 11/23/2023 1:31 AM, Konrad Dybcio wrote:
>
>
> On 11/18/23 13:39, Satya Priya Kakitapalli wrote:
>> Add runtime PM support to ensure the supply rails are enabled
>> when necessary.
>>
>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>> Changes since v1:
>>   - None.
>>
>>   drivers/clk/qcom/videocc-sm8150.c | 20 ++++++++++++++++++--
>>   1 file changed, 18 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/qcom/videocc-sm8150.c 
>> b/drivers/clk/qcom/videocc-sm8150.c
>> index 52a9a453a143..b57df5ff96c4 100644
>> --- a/drivers/clk/qcom/videocc-sm8150.c
>> +++ b/drivers/clk/qcom/videocc-sm8150.c
>> @@ -6,6 +6,7 @@
>>   #include <linux/clk-provider.h>
>>   #include <linux/module.h>
>>   #include <linux/platform_device.h>
>> +#include <linux/pm_runtime.h>
>>   #include <linux/regmap.h>
>>     #include <dt-bindings/clock/qcom,videocc-sm8150.h>
>> @@ -240,17 +241,32 @@ MODULE_DEVICE_TABLE(of, 
>> video_cc_sm8150_match_table);
>>   static int video_cc_sm8150_probe(struct platform_device *pdev)
>>   {
>>       struct regmap *regmap;
>> +    int ret;
>> +
>> +    ret = devm_pm_runtime_enable(&pdev->dev);
>> +    if (ret)
>> +        return ret;
>> +
>> +    ret = pm_runtime_resume_and_get(&pdev->dev);
>> +    if (ret)
>> +        return ret;
>>         regmap = qcom_cc_map(pdev, &video_cc_sm8150_desc);
>> -    if (IS_ERR(regmap))
>> +    if (IS_ERR(regmap)) {
>> +        pm_runtime_put(&pdev->dev);
> Shouldn't this be _sync?
>

Yes, will update it on v2


> Konrad