Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1059909rdh; Fri, 24 Nov 2023 04:33:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IGmDHdHdMhctENKLv1KNHTN3WQiWCsD9ljuMW1eQiIQdl1gexa5VVVsRIOxYub227Eql96g X-Received: by 2002:a17:90b:4c8f:b0:280:c576:31af with SMTP id my15-20020a17090b4c8f00b00280c57631afmr2275209pjb.40.1700829184968; Fri, 24 Nov 2023 04:33:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700829184; cv=none; d=google.com; s=arc-20160816; b=B52DSP1g1UkFq9y79XHDG5vI9/lKjpGI266YalIjHVGyQ9U7uTvXZYWeGaejVDDAC0 LyCFhqChTyMcBGrUk4Z5H8UC7g1KT1K+aCDzC78DgRE60AxRqVXPKfwltiEX/0lrVyLZ oMG/AGCNW/KR4TlbAwkkg2wU9+e4VOx+/rU6+fyQ2HNunDWeyqCsOAj99/17+CbIkpfi FsJt9mO5k2qEkZMLM2Ma+wA3aMuoUwqQyTSCVbxAiguOnLDASd8RqX84vDhBUcU2PWl6 k5A8cNzdel7vxSvD/UybpIQP5Ayrgu3XagzsPEe1dZIEFGY7OHqNurQ1VDVXsqatod+Y JpEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=NES+7f+kZaJ25DoU6Ma6AjSQpEjNkVReugKPazrliVU=; fh=kGKewxLKDpGQf8psD48t3+VowkJZnRa4zXPRN7F/fbI=; b=dSHjt3Nnh8nswLeeBtdvVh61EMJvju3Ey30BGMAcPP9iC4aWao30ECpc4lMvbUgvTa zObm5kRwnGzTT7A2C5f0zgi/kfYJ7Z0OEE3JFZPUQgfA8YTiiWCeEMU67cLNNob1TDor UNVyAQu84xf9DhH561PeuK96Vl4ZH7/icZJ3HGf8EKhmRUuL0n0UrC0wbNpFFoRoX1qi mP4Kd8gMZ16vW5OU+I3470++C/xuoEJn0RrxO1zPLA4ywIgcwr5usHScYRIhybT7XNtT Qc+PMNB15FBp+eyHAbyc4y6TPfgDXwqfINWz7O7kAwkXaSE7ZvXPRVKkQe0wYutvBJ2X fLfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IUxRDH8e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id n14-20020a17090ade8e00b002847b85bbeasi3916184pjv.150.2023.11.24.04.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 04:33:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IUxRDH8e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 791A880C65F8; Fri, 24 Nov 2023 04:33:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230418AbjKXMcy (ORCPT + 99 others); Fri, 24 Nov 2023 07:32:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229742AbjKXMcw (ORCPT ); Fri, 24 Nov 2023 07:32:52 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB1A7B6; Fri, 24 Nov 2023 04:32:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700829179; x=1732365179; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Ua9WzBIueklW0+q3gIH97GV61BDNLh+kPw+aWwuovUk=; b=IUxRDH8eW1DtuOP8ZBMeRPovkV7fjYpJk0CL3+g1BlZVJtbhfRWD3aiS qkJlLyZYb2qXzAStaDZAbOlY8u+hNYOTaFAZOJXJJdcO7ppF83esjEbev N3iQb25/vBqaOPoNGbWsT5BiVmjUUeqw79qpN2XCMLnk0/mkb2FBv/vk8 rI7DE3RmjVr55ytQ5iUnZsswFnG9Y3jAbHO5XMckrOU/eb3BMMqXVpt3o 7sppvncGiOSUYqdvgVC5dwGCSB20guVYErXw47K1hXKWLSMe0weHcunbU DqMBzMD3Fyu8nvBrvNm7ZEKZqfmKrAuemziExatH9f6JxqBwiTpRH+kYy A==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="391291470" X-IronPort-AV: E=Sophos;i="6.04,224,1695711600"; d="scan'208";a="391291470" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2023 04:32:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="1014895116" X-IronPort-AV: E=Sophos;i="6.04,224,1695711600"; d="scan'208";a="1014895116" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2023 04:32:58 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r6VMd-0000000Giba-2QBm; Fri, 24 Nov 2023 14:32:55 +0200 Date: Fri, 24 Nov 2023 14:32:55 +0200 From: Andy Shevchenko To: Raag Jadav Cc: Mika Westerberg , linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] pinctrl: tangier: simplify locking using cleanup helpers Message-ID: References: <20231123140212.12135-1-raag.jadav@intel.com> <20231123142816.GE1074920@black.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 24 Nov 2023 04:33:03 -0800 (PST) On Fri, Nov 24, 2023 at 02:08:05PM +0200, Raag Jadav wrote: > On Fri, Nov 24, 2023 at 01:09:17PM +0200, Andy Shevchenko wrote: > > On Thu, Nov 23, 2023 at 04:28:16PM +0200, Mika Westerberg wrote: > > > On Thu, Nov 23, 2023 at 07:32:12PM +0530, Raag Jadav wrote: > > > > Use lock guards from cleanup.h to simplify locking. > > > > > > > > Signed-off-by: Raag Jadav > > > > > > Acked-by: Mika Westerberg > > > > Pushed to my review and testing queue, thanks! > > Awesome, I noticed a few commits having duplicate Acks in Intel tree. You are right, I have mistakenly run a msg-filter before applying my byt series. Thanks for spotting this, now should be fixed! -- With Best Regards, Andy Shevchenko