Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Fri, 24 Nov 2023 14:36:51 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Sean Young <sean@mess.org>
Cc:     linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
        Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, Jonathan Corbet <corbet@lwn.net>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/4] pwm: make it possible to apply pwm changes in
 atomic context
Message-ID: <ZWCm8_S7epYQwZiG@orome.fritz.box>
References: <cover.1700323916.git.sean@mess.org>
 <ab49d3c11dd3fa432459cc8e11a77127f1a803dd.1700323916.git.sean@mess.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="hgjpG1/obTMMognX"
Content-Disposition: inline
In-Reply-To: <ab49d3c11dd3fa432459cc8e11a77127f1a803dd.1700323916.git.sean@mess.org>
User-Agent: Mutt/2.2.12 (2023-09-09)
Precedence: bulk


--hgjpG1/obTMMognX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Nov 18, 2023 at 04:16:18PM +0000, Sean Young wrote:
[...]
> diff --git a/include/linux/pwm.h b/include/linux/pwm.h
> index c4b066f7c5097..495aba06c64c3 100644
> --- a/include/linux/pwm.h
> +++ b/include/linux/pwm.h
> @@ -286,6 +286,7 @@ struct pwm_ops {
>   * @npwm: number of PWMs controlled by this chip
>   * @of_xlate: request a PWM device given a device tree PWM specifier
>   * @of_pwm_n_cells: number of cells expected in the device tree PWM specifier
> + * @atomic: can the driver execute pwm_apply_cansleep in atomic context

I'm a little reluctant to suggest that we rename this to might_sleep as
well because it would require that we audit each and every driver to set
this properly, since by default all devices have so far been defaulting
to "might_sleep". But then again, I think that's something that we're
going to need to do at some point anyway.

In the interim, I think we could keep it like this and address this as a
follow-up.

Thierry

--hgjpG1/obTMMognX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmVgpvMACgkQ3SOs138+
s6HAAw//ct4gKrWjBExDza1kxoB9kMmSwy8Ix26Sb4TjW89uZEp7FQCAgvsILRk2
XVKu9xl2vdM/WBprSkvv/UQdBz+g18xJVFKbJdz4WYwrYjdRic5vdlpUsrkbjYUr
WbccEEMdQN+s4c6QpRCFxAEJbwTvI5KY/HG5cRhfp6EtwfXgBnjtjwRcYc+4/jEm
AaJ/fEdpKd9biRwFIkFyrZsZef3MJI4KVE5Nfkz+lkMCZuSCehkKO/Mw4gNsbgWR
ehd9Gcz+nBZDPYgn87UTrOJfM13DBIRpLT087OK/MObKvzYGH9z0q5UcoFoCMdPD
v70M5i+jFEDTkjYoIibeftoL88uq0boga3YwU8UP8KhlnJSW4gUubDfP31W8SGcB
ZUEwW6Z0hxmDMOdH9FvikAdWYhopwu+Y8kcZUkDVFO6FiNZihP3pm/Pdc0RSf/Vc
WaA9mFhHOngaOde/dLx5E8OYc37WHqXehS3TsfExjkuiUEJv9hBIkx4AT47mSEKi
AQstSySIApc0vaXsT0DZ6BCNah6MBGmAchtX1t9jtf2k4bW0iv2fh3z6maOS3U3S
Yk/XhoT9Zrsaxd+30PaaoU5HFNEFzT0n86QyLecTnGX5jdd1ecLn4V/QslJFon7A
BrpbbhA0oiKZ05xlpvjL3I24i6lFx59EI76uFrxDh/kMkdESiiM=
=NVyq
-----END PGP SIGNATURE-----

--hgjpG1/obTMMognX--