Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1111955rdh; Fri, 24 Nov 2023 05:37:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDXudTYFEio0RrgxpJOXd20HwcqCVDG6vwsvkAu2bcQpLV2nRgonfqDo5IeitUv2GPl/Sa X-Received: by 2002:a05:6a20:4388:b0:187:78ef:e3f1 with SMTP id i8-20020a056a20438800b0018778efe3f1mr4360655pzl.20.1700833050269; Fri, 24 Nov 2023 05:37:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700833050; cv=none; d=google.com; s=arc-20160816; b=XqGrjznkqj1SL2RlbgYsrIGuCSCybfCMZSM/rf4UsWOdKTEg6T0jmuwVDl4wKz9tXa vvcuwu0l1907eAv4Uc7yCjJiSiMU1vGUAfzy227rljUp9Nq4ke+0x44zlNkRoHhq7Bzs k27EoNGrNs+7j7s1LLSZwjCLMHFL3l/SWCWH4Fq2ntIwgF/nRyMDdl8jRkfRImZ7kICv a9xFyViu4/4DqsvQgZXn6Rh0MW1ZsQTXi9WOPQs6jBMdMGVSatlePrnpiBzDRj3abSIo szdKX0+2CmO7TpF5gIgO436ZDiA6hEGB50P7DH2H/iHdhKplWdx8qGWkLURCNgxfAfFZ pvdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=HRWPMs4oCCg9lIhrK/FdHI6XoKn9IW2M0mF9ZvUtAtQ=; fh=xdIClvGFRVyhf4fQQBj75tpTj0KguYr4ZF3SZ/9+VRw=; b=uJKHeF0/gCUXnbV7psHBlXwl80zEFQXJEShqTwk30EdRwiQPAXIa6G6r/ESaN+4IPI 6Kc4mn2BwQP/gWw52mnD02vUp147XiVA4XVsrzge2feQOP1M7X6g1dzXOgpYczGnEFEy Nn5rY7pAgMSmlMgaszI4U6DK7Ph1bYkb9UYIPceL2Xjqzvk8d1rzG0ub6ctVUWVcXGuo UBSz8NeP0+fPdkEykioe7iEQGQ8du2GB8C6D52xH+/N2sf5kahBevnW+QnwoH+Nnq6XY /tsDCqVetDk+37zgNsTZ72YQeoBCBy096QZlW29LXAHFWym2OD9ZebcpvHP2bR3Yn+sq OuBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id q6-20020a635046000000b005adba954597si3627610pgl.504.2023.11.24.05.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 05:37:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id E9DF480789CC; Fri, 24 Nov 2023 05:35:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345280AbjKXNfB (ORCPT + 99 others); Fri, 24 Nov 2023 08:35:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345481AbjKXNen (ORCPT ); Fri, 24 Nov 2023 08:34:43 -0500 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC2521FF9; Fri, 24 Nov 2023 05:34:48 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=guwen@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0Vx1k3KH_1700832884; Received: from 30.221.129.111(mailfrom:guwen@linux.alibaba.com fp:SMTPD_---0Vx1k3KH_1700832884) by smtp.aliyun-inc.com; Fri, 24 Nov 2023 21:34:46 +0800 Message-ID: <83d3784e-1fed-36b6-22a8-52995fac429e@linux.alibaba.com> Date: Fri, 24 Nov 2023 21:34:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH net-next 0/7] net/smc: implement SMCv2.1 virtual ISM device support To: Wenjia Zhang , wintera@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kgraul@linux.ibm.com, jaka@linux.ibm.com Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com, alibuda@linux.alibaba.com, tonylu@linux.alibaba.com, raspl@linux.ibm.com, schnelle@linux.ibm.com, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1700402277-93750-1-git-send-email-guwen@linux.alibaba.com> <30b53b21-40ad-407a-bef7-ddc28f8978e2@linux.ibm.com> From: Wen Gu In-Reply-To: <30b53b21-40ad-407a-bef7-ddc28f8978e2@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 24 Nov 2023 05:35:28 -0800 (PST) On 2023/11/24 21:11, Wenjia Zhang wrote: > > > On 19.11.23 14:57, Wen Gu wrote: >> The fourth edition of SMCv2 adds the SMC version 2.1 feature updates for >> SMC-Dv2 with virtual ISM. Virtual ISM are created and supported mainly by >> OS or hypervisor software, comparable to IBM ISM which is based on platform >> firmware or hardware. >> >> With the introduction of virtual ISM, SMCv2.1 makes some updates: >> >> - Introduce feature bitmask to indicate supplemental features. >> - Reserve a range of CHIDs for virtual ISM. >> - Support extended GIDs (128 bits) in CLC handshake. >> >> So this patch set aims to implement these updates in Linux kernel. And it >> acts as the first part of the new version of [1]. >> >> [1] https://lore.kernel.org/netdev/1695568613-125057-1-git-send-email-guwen@linux.alibaba.com/ >> >> Wen Gu (7): >>    net/smc: Rename some variable 'fce' to 'fce_v2x' for clarity >>    net/smc: support SMCv2.x supplemental features negotiation >>    net/smc: introduce virtual ISM device support feature >>    net/smc: define a reserved CHID range for virtual ISM devices >>    net/smc: compatible with 128-bits extend GID of virtual ISM device >>    net/smc: disable SEID on non-s390 archs where virtual ISM may be used >>    net/smc: manage system EID in SMC stack instead of ISM driver >> >>   drivers/s390/net/ism.h     |  6 --- >>   drivers/s390/net/ism_drv.c | 54 +++++++-------------------- >>   include/linux/ism.h        |  1 - >>   include/net/smc.h          | 16 +++++--- >>   net/smc/af_smc.c           | 68 ++++++++++++++++++++++++++------- >>   net/smc/smc.h              |  7 ++++ >>   net/smc/smc_clc.c          | 93 ++++++++++++++++++++++++++++++++-------------- >>   net/smc/smc_clc.h          | 22 +++++++---- >>   net/smc/smc_core.c         | 30 ++++++++++----- >>   net/smc/smc_core.h         |  8 ++-- >>   net/smc/smc_diag.c         |  7 +++- >>   net/smc/smc_ism.c          | 57 ++++++++++++++++++++-------- >>   net/smc/smc_ism.h          | 31 +++++++++++++++- >>   net/smc/smc_pnet.c         |  4 +- >>   14 files changed, 269 insertions(+), 135 deletions(-) >> > > Hi Wen Gu, > > Just FYI, the review is still on going and some tests on our plateform still need to do. I'll give you my comments as > soon as the testing is done. I think it would be at the beginning of next week. > > Thanks, > Wenjia Hi Wenjian, Thank you very much. I appreciate that you help to test them on your platform since I can only test them with loopback-ism. And I am going to send a new version which is rebased to the latest net-next and fix two existing comments. If the current tests have not started yet, could you please test based on my upcoming v2 ? Thanks and regards, Wen Gu