Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <a283cb15-d740-4f94-a81e-0147c2035cf7@prevas.dk>
Date:   Fri, 24 Nov 2023 14:37:11 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] serial: imx: fix tx statemachine deadlock
To:     Paul Geurts <paul_geurts@live.nl>, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <2023112434-winter-embezzle-1b46@gregkh>
 <AM0PR09MB26758F651BC1B742EB45775995B8A@AM0PR09MB2675.eurprd09.prod.outlook.com>
Content-Language: en-US, da
Cc:     Eberhard Stoll <eberhard.stoll@gmx.de>
From:   Rasmus Villemoes <rasmus.villemoes@prevas.dk>
In-Reply-To: <AM0PR09MB26758F651BC1B742EB45775995B8A@AM0PR09MB2675.eurprd09.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2RDVXc3SGZ0ME83c013eDU1THBVZkZlS1BLeEE0MVFMcWxqYndVbmVsNEgw?=
 =?utf-8?B?OFNiZHFmN0VqckNUUStwb2JsbDFUcnRzREZ0Q0FhbVVKd21YdlBqcmlydXNF?=
 =?utf-8?B?ZDgyZUt0ZVRzR1ZGc3NEOVhtNUJ4YjZtL0JUa2ZSeEloc05BUEJrMjQrWGZV?=
 =?utf-8?B?RWppaVo4eVZjU1pCZ3pDSjRtR1dOZUwyNFNjaEZxY1dZMHBxK0trSTljbGND?=
 =?utf-8?B?cXdmb0N0cDJTZjIwdVMxNzBsdFlpZm1mTFR0TGFQRmtFbnp5YlJrV3hMVVE2?=
 =?utf-8?B?ME55SUhWeU5QTU85YmoyMmJNdXliNld0eXVKdkFhYXhqRVNXTmd6d3NSVzM4?=
 =?utf-8?B?ZU01TTJySk5Xb3V4T1JoTW9sTnJpZktOa1JNOTZDRUtmaWZ4N0NRWWEvN1dE?=
 =?utf-8?B?b05PbXRYZk4yaFQwSUU2ZlBSMDdOY1BlT2kvOXpDd1ExdFhFK0RPSkxQdUJz?=
 =?utf-8?B?aWp1NDc1aWlkMEwzODB1eTJYOFVENjJFTmc0YVdlRCt2UnRuLzBkU2pmWXZ4?=
 =?utf-8?B?aC9Hbzh3d0RmcjdlbU4yN2VtZU05bXNlcXdtaTZnZUxIMXEwbWZNK3ZhcGlh?=
 =?utf-8?B?WEI4YndBY3BkZEpsbGNnS0NMWUNXMmh5cGNaMUwxMVd2TE8xbGc3dFA0bkwx?=
 =?utf-8?B?WThOa1pXc2sxNm00K1R2ZVN3SkJMTVYwL2Ixa082N1JXSklMMVhTZEltMzR0?=
 =?utf-8?B?N0kzcHFSbDlhWUowaVZLeEtsRDhUUjlRZ0lJaThUemJ4aG44ZEFTOGQ0bGt0?=
 =?utf-8?B?OHdJQmlRcWhxalRnbGw4T3pDWGhuLzRiUGpYSTdYTEpSMVNUWlZUdVVmTndC?=
 =?utf-8?B?MVdJdGp1Nk1qcmZOZWppc1RmOTgxRTRsVjBsTGFGdzN5NG5TTElyZ3RnZVh0?=
 =?utf-8?B?bkxBVk5XdU1pQllPK25ZNlkyQXltbFovNk80dkorb09uVmk0N1FSQW5yaFhX?=
 =?utf-8?B?QmpOMitqeWo5S0R0aCtGUDY3TDU4RUUwWkdaZm5HYW1sb2RLbkRpZ2xjeFN0?=
 =?utf-8?B?WFVMRWkxNCtnZGJJZ3AvZUtOWFRDRlM4TmhMdXNneEdwQkk1d0srSFJXNkxI?=
 =?utf-8?B?UkJVeHd2dFE0cmZmeElTelVlMlExYWxsN2JtOW5aekhYb2tUc1lzNGxSODhH?=
 =?utf-8?B?d1lsYlBsKy9uUHFCaHgyUzV4TlBUZEpRYkFvUXk3eEFOdzAzOHRLZlZpdWRt?=
 =?utf-8?B?U21Senc2c0NYcmx5OWdDbkx0d09zVmFmQnRGMjM4ZUpVbFJkQ2NNTFlLVE91?=
 =?utf-8?B?NzVaNER1OEUxUXZoc3Jud1RPRXpwQ0VaSTBEQUlXZWhhbzA3MXFza0ZhZEpC?=
 =?utf-8?B?WWV6TFdnZ3ZrSG9XZVJ5dmtaOUdvU1dHNlhJUC9EZlZPWHFVWXVXWEtneVF3?=
 =?utf-8?B?NDZxekQ0ZDJWZmtQUXNnVVI2SGwzWUFNUFZaaW02MUx2U0FFdkFZRGhoZTJK?=
 =?utf-8?B?Vm8zblp5bWl0eUxiTnhIMlVVZ0kwRkd0TUppaUlGUnRQN2VENWVkUU5VWlJW?=
 =?utf-8?B?bGlZTmVzNnFXSEV1eUJlbDU0MnVueEdFRVV2aUQxdWUrVlowVFd4OEVISTRS?=
 =?utf-8?B?Y1pCVzh6SHl6NWlyWGcvMFhNUnR2QUJ6WnlKZTdVUkRGK3EzUldnT0VQdXBw?=
 =?utf-8?B?aHVrVEdCbFNUMmVNNmdtNFp3MkE2U25HZmZkN1FTRHZPc3ZQWWRpUVozUFpL?=
 =?utf-8?B?SmhYQkMwWmZxRjg4UXlBajV3NnpUZEhOVktaamJMa3hPd1k5cm40dGY2YlhN?=
 =?utf-8?B?MjdCaXVyS2ovRFNWWFBLZmpkR0ZWRUpNSTNiSjBEWGRuby9sU3VXQmJMWmkr?=
 =?utf-8?B?SUxtRCtIWDZmWlhSWU16MzFwNXpaOGozNC9OekVSM29IZmJLTGtEYmphQ0w1?=
 =?utf-8?B?eHlqNjlna2hFdExDUnlTVHhPRGo4YmdEem1OWDE1VWFYb01uVXVlVkFsN28x?=
 =?utf-8?B?bWhwQVlRZU40dmNXMDdwT1JwaDNMYjUxRk1POEZIQ0lKVXhwRWN2UVRyQVYy?=
 =?utf-8?B?N2hTb2Q5Tlk0M2tYYjFlSTB0dXNIT3dWMXN5bzloZmtSc09oMURRZkNib2Mr?=
 =?utf-8?B?dVNVb1k4dzFNSEFzdGwvNmJBT2R3NG5Kb2xOV080aGo1WGVGT1MzZ2d5dGhq?=
 =?utf-8?B?ekZUc09IZlRkN1dLVWUrY0dycWdqa3BibHBhN0czekhDQS9FT0hoWEs5NTdV?=
 =?utf-8?B?VWc9PQ==?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: ed9a4478-0028-4e24-bbc8-08dbecf27824
X-MS-Exchange-CrossTenant-AuthSource: DB9PR10MB7100.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 13:37:14.6537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z7bTj5h0TNiuGpwit24nyvND/bmkMflo9CYL0AU2a1dFSYzHuL5/AFebFLS1Dp59gFQ3PH0vV4ftJscD72Hgi0wNJ65S+wGUKJCjV0vKl5M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3609
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 24 Nov 2023 05:37:35 -0800 (PST)

On 24/11/2023 14.11, Paul Geurts wrote:
> When using the serial port as RS485 port, the tx statemachine is used to
> control the RTS pin to drive the RS485 transceiver TX_EN pin. When the
> TTY port is closed in the middle of a transmission (for instance during
> userland application crash), imx_uart_shutdown disables the interface
> and disables the Transmission Complete interrupt. afer that,
> imx_uart_stop_tx bails on an incomplete transmission, to be retriggered
> by the TC interrupt. This interrupt is disabled and therefore the tx
> statemachine never transitions out of SEND. The statemachine is in
> deadlock now, and the TX_EN remains low, making the interface useless.
> 
> imx_uart_stop_tx now checks for incomplete transmission AND whether TC
> interrupts are enabled before bailing to be retriggered. This makes sure
> the state machine handling is reached, and is properly set to
> WAIT_AFTER_SEND.
> 
> Fixes: cb1a60923609 ("serial: imx: implement rts delaying for rs485")
> Signed-off-by: Paul Geurts <paul_geurts@live.nl>

Hi Paul

Interestingly, both Eberhard (cc'ed) and I have hit similar problems in
this driver recently. See the thread
https://lore.kernel.org/lkml/20231120132256.136625-1-rasmus.villemoes@prevas.dk/
.

It is possible that this also fixes the problems I/we saw, but I can't
get around to testing until sometime next week.

Rasmus