Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <000000000000778f1005dab1558e@google.com> <CAG48ez2AAk6JpZAA6GPVgvCmKimXHJXO906e=r=WGU06k=HB3A@mail.gmail.com>
 <1037989.1647878628@warthog.procyon.org.uk> <CAG48ez1+4dbZ9Vi8N4NKCtGwuXErkUs6bC=8Pf+6jiZbxrwR7g@mail.gmail.com>
In-Reply-To: <CAG48ez1+4dbZ9Vi8N4NKCtGwuXErkUs6bC=8Pf+6jiZbxrwR7g@mail.gmail.com>
From:   Jann Horn <jannh@google.com>
Date:   Fri, 24 Nov 2023 15:38:21 +0100
Message-ID: <CAG48ez3AazYzfJCFgu2MKSoxMEpJXz0td+rbeCOhsM38i78m3A@mail.gmail.com>
Subject: Re: [syzbot] possible deadlock in pipe_write
To:     David Howells <dhowells@redhat.com>
Cc:     syzbot <syzbot+011e4ea1da6692cf881c@syzkaller.appspotmail.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Mar 21, 2022 at 5:17=E2=80=AFPM Jann Horn <jannh@google.com> wrote:
> On Mon, Mar 21, 2022 at 5:03 PM David Howells <dhowells@redhat.com> wrote=
:
> > Jann Horn <jannh@google.com> wrote:
> >
> > > The syz reproducer is:
> > >
> > > #{"threaded":true,"procs":1,"slowdown":1,"sandbox":"","close_fds":fal=
se}
> > > pipe(&(0x7f0000000240)=3D{<r0=3D>0xffffffffffffffff, <r1=3D>0xfffffff=
fffffffff})
> > > pipe2(&(0x7f00000001c0)=3D{0xffffffffffffffff, <r2=3D>0xfffffffffffff=
fff}, 0x80)
> > > splice(r0, 0x0, r2, 0x0, 0x1ff, 0x0)
> > > vmsplice(r1, &(0x7f00000006c0)=3D[{&(0x7f0000000080)=3D"b5", 0x1}], 0=
x1, 0x0)
> > >
> > > That 0x80 is O_NOTIFICATION_PIPE (=3D=3DO_EXCL).
> > >
> > > It looks like the bug is that when you try to splice between a normal
> > > pipe and a notification pipe, get_pipe_info(..., true) fails, so
> > > splice() falls back to treating the notification pipe like a normal
> > > pipe - so we end up in iter_file_splice_write(), which first locks th=
e
> > > input pipe, then calls vfs_iter_write(), which locks the output pipe.
> > >
> > > I think this probably (?) can't actually lead to deadlocks, since
> > > you'd need another way to nest locking a normal pipe into locking a
> > > watch_queue pipe, but the lockdep annotations don't make that clear.
> >
> > Is this then a bug/feature in iter_file_splice_write() rather than in t=
he
> > watch queue code, per se?
>
> I think at least when you call splice() on two normal pipes from
> userspace, it'll never go through this codepath for real pipes,
> because pipe-to-pipe splicing is special-cased? And sendfile() bails
> out in that case because pipes don't have a .splice_read() handler.
>
> And with notification pipes, we don't take that special path in
> splice(), and so we hit the lockdep warning. But I don't know whether
> that makes it the fault of notification pipes...
>
> Maybe it would be enough to just move the "if (pipe->watch_queue)"
> check in pipe_write() up above the __pipe_lock(pipe)?

[coming back to this thread 1.5 years later...]
I've turned that idea into a fix, let's have syzbot try it out before
I submit the fix patch:

#syz test: https://github.com/thejh/linux.git 56c486e68166