Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Pratyush Yadav <pratyush@kernel.org>
To:     Srikanth Boyapally <srikanth.boyapally@amd.com>
Cc:     <tudor.ambarus@linaro.org>, <pratyush@kernel.org>,
        <michael@walle.cc>, <miquel.raynal@bootlin.com>, <richard@nod.at>,
        <vigneshr@ti.com>, <linux-mtd@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <git@amd.com>
Subject: Re: [PATCH] mtd: spi-nor: issi: Add support for is25lp02g
In-Reply-To: <20231123054713.361101-1-srikanth.boyapally@amd.com> (Srikanth
        Boyapally's message of "Thu, 23 Nov 2023 11:17:13 +0530")
References: <20231123054713.361101-1-srikanth.boyapally@amd.com>
Date:   Fri, 24 Nov 2023 15:47:22 +0100
Message-ID: <mafs0jzq7dx8l.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Hi,

On Thu, Nov 23 2023, Srikanth Boyapally wrote:

> Add support for issi is25lp02g.
>
> Verified on AMD-Xilinx versal platform and executed
> mtd_debug read/write test.
>
> Signed-off-by: Srikanth Boyapally <srikanth.boyapally@amd.com>

Based on a datasheet [0] I found online, this flash seems to have SFDP.
And since you do not add any flash specific fixups, it likely does not
need an entry and would work fine with the generic flash driver. Did you
try using that? See [1] for more info on contribution guidelines.

[0] https://www.issi.com/WW/pdf/25LP-WP02GG.pdf
[1] https://lore.kernel.org/linux-mtd/20231123160721.64561-2-tudor.ambarus@linaro.org/

-- 
Regards,
Pratyush Yadav