Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <CAOQ4uxjssgw1tZrUQvtHHVacSgR9NE0yF8DA3+R5LNFAocCvVQ@mail.gmail.com>
 <000000000000258ac60606589787@google.com>
In-Reply-To: <000000000000258ac60606589787@google.com>
From:   Jann Horn <jannh@google.com>
Date:   Fri, 24 Nov 2023 16:11:54 +0100
Message-ID: <CAG48ez2UkCR7LMaQfCQVLW4VOZG9CuPDMHG7cBtaAitM=zPBCg@mail.gmail.com>
Subject: Re: [syzbot] [overlayfs?] KASAN: invalid-free in ovl_copy_up_one
To:     amir73il@gmail.com,
        syzbot <syzbot+477d8d8901756d1cbba1@syzkaller.appspotmail.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-unionfs@vger.kernel.org, miklos@szeredi.hu,
        syzkaller-bugs@googlegroups.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Sep 27, 2023 at 5:10=E2=80=AFPM syzbot
<syzbot+477d8d8901756d1cbba1@syzkaller.appspotmail.com> wrote:
> syzbot has tested the proposed patch and the reproducer did not trigger a=
ny issue:
>
> Reported-and-tested-by: syzbot+477d8d8901756d1cbba1@syzkaller.appspotmail=
.com
>
> Tested on:
>
> commit:         8e9b46c4 ovl: do not encode lower fh with upper sb_wri..
> git tree:       https://github.com/amir73il/linux.git ovl_want_write
> console output: https://syzkaller.appspot.com/x/log.txt?x=3D10d10ffa68000=
0
> kernel config:  https://syzkaller.appspot.com/x/.config?x=3Dbb54ecdfa197f=
132
> dashboard link: https://syzkaller.appspot.com/bug?extid=3D477d8d8901756d1=
cbba1
> compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for D=
ebian) 2.40

It looks like the fix was submitted without the Reported-by tag, so
syzkaller doesn't recognize that the fix has landed... I'll tell
syzkaller now which commit the fix is supposed to be in, please
correct me if this is wrong:

#syz fix: ovl: do not encode lower fh with upper sb_writers held