Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <de706c0c-d6dc-45d4-a316-56ff56be5c25@infradead.org>
Date:   Fri, 24 Nov 2023 07:34:28 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] video: fbdev: mmp: Fix typo in code comment
Content-Language: en-US
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>,
        linux-kernel@vger.kernel.org
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Helge Deller <deller@gmx.de>, Zhou Zhu <zzhu3@marvell.com>,
        dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
References: <20231124095221.659445-1-dario.binacchi@amarulasolutions.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20231124095221.659445-1-dario.binacchi@amarulasolutions.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 11/24/23 01:52, Dario Binacchi wrote:
> s/singals/signals/
> 
> Fixes: 641b4b1b6a7c ("video: mmpdisp: add spi port in display controller")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> 
>  drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/mmp/hw/mmp_spi.c b/drivers/video/fbdev/mmp/hw/mmp_spi.c
> index 16401eb95c6c..64e34b7e739e 100644
> --- a/drivers/video/fbdev/mmp/hw/mmp_spi.c
> +++ b/drivers/video/fbdev/mmp/hw/mmp_spi.c
> @@ -91,7 +91,7 @@ static int lcd_spi_setup(struct spi_device *spi)
>  	writel(tmp, reg_base + LCD_SPU_SPI_CTRL);
>  
>  	/*
> -	 * After set mode it need a time to pull up the spi singals,
> +	 * After set mode it need a time to pull up the spi signals,

Also:
	                  it needs time
or
	                  it needs some time

>  	 * or it would cause the wrong waveform when send spi command,
>  	 * especially on pxa910h
>  	 */

thanks.
-- 
~Randy