Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Fri, 24 Nov 2023 17:02:02 +0100
From:   Christian Brauner <brauner@kernel.org>
To:     David Howells <dhowells@redhat.com>
Cc:     Jann Horn <jannh@google.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] fs/pipe: Fix lockdep false-positive in watchqueue
 pipe_write()
Message-ID: <20231124-gearbeitet-unberechenbar-70241992a995@brauner>
References: <20231124150822.2121798-1-jannh@google.com>
 <1210483.1700841227@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1210483.1700841227@warthog.procyon.org.uk>
Precedence: bulk

On Fri, Nov 24, 2023 at 03:53:47PM +0000, David Howells wrote:
> Jann Horn <jannh@google.com> wrote:
> 
> > +	/*
> > +	 * Reject writing to watch queue pipes before the point where we lock
> > +	 * the pipe.
> > +	 * Otherwise, lockdep would be unhappy if the caller already has another
> > +	 * pipe locked.
> > +	 * If we had to support locking a normal pipe and a notification pipe at
> > +	 * the same time, we could set up lockdep annotations for that, but
> > +	 * since we don't actually need that, it's simpler to just bail here.
> > +	 */
> > +	if (pipe_has_watch_queue(pipe))
> > +		return -EXDEV;
> > +
> 
> Linus wanted it to be possible for the user to write to a notificaiton pipe.

Since it has been disabled from the start and nothing has ever actually
materialized we just don't need to care. If we start caring this needs
more work anyway iirc.