Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
MIME-Version: 1.0
References: <000000000000cf908705eaa8c5a7@google.com>
In-Reply-To: <000000000000cf908705eaa8c5a7@google.com>
From:   Jann Horn <jannh@google.com>
Date:   Fri, 24 Nov 2023 17:21:20 +0100
Message-ID: <CAG48ez0JNLENLRSaisWvaY7+o=CwGtP=ZcH_iBoSqW7qD-PU1Q@mail.gmail.com>
Subject: Re: [syzbot] WARNING in __kernel_write_iter
To:     syzbot <syzbot+12e098239d20385264d3@syzkaller.appspotmail.com>
Cc:     clm@fb.com, dsterba@suse.com, josef@toxicpanda.com,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        syzkaller-bugs@googlegroups.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 10, 2022 at 9:04=E2=80=AFAM syzbot
<syzbot+12e098239d20385264d3@syzkaller.appspotmail.com> wrote:
> HEAD commit:    a6afa4199d3d Merge tag 'mailbox-v6.1' of git://git.linaro=
...
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=3D110f6f0a88000=
0
> kernel config:  https://syzkaller.appspot.com/x/.config?x=3Dd19f5d16783f9=
01
> dashboard link: https://syzkaller.appspot.com/bug?extid=3D12e098239d20385=
264d3
> compiler:       Debian clang version 13.0.1-++20220126092033+75e33f71c2da=
-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2
>
> Unfortunately, I don't have any reproducer for this issue yet.
>
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/12e24d042ff9/dis=
k-a6afa419.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/4862ae4e2edf/vmlinu=
x-a6afa419.xz
>
> IMPORTANT: if you fix the issue, please add the following tag to the comm=
it:
> Reported-by: syzbot+12e098239d20385264d3@syzkaller.appspotmail.com
>
> ------------[ cut here ]------------
> WARNING: CPU: 1 PID: 20347 at fs/read_write.c:504 __kernel_write_iter+0x6=
39/0x740
[...]
>  __kernel_write fs/read_write.c:537 [inline]
>  kernel_write+0x1c5/0x340 fs/read_write.c:558
>  write_buf fs/btrfs/send.c:590 [inline]
>  send_header fs/btrfs/send.c:708 [inline]
>  send_subvol+0x1a7/0x4b60 fs/btrfs/send.c:7648
>  btrfs_ioctl_send+0x1e34/0x2340 fs/btrfs/send.c:8014
>  _btrfs_ioctl_send+0x2e8/0x420 fs/btrfs/ioctl.c:5233
>  btrfs_ioctl+0x5eb/0xc10
>  vfs_ioctl fs/ioctl.c:51 [inline]

The issue here is that BTRFS_IOC_SEND looks up an fd with fget() and
then writes into it with kernel_write(). Luckily the ioctl requires
CAP_SYS_ADMIN, and also Linux >=3D5.8 bails out on __kernel_write() on a
read-only file, so this has no security impact.

I'm about to send a fix, let's have syzkaller check it beforehand:

#syz test https://github.com/thejh/linux.git 573fd2562e0f