Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1326399rdh; Fri, 24 Nov 2023 09:48:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IHdiYFHR6TU4aHkIr4BRgJ95RjEYWLu4t6Z+f5IjMiKkA5UefzpZ13aiyXZWotynXD26SUT X-Received: by 2002:a05:6a20:4415:b0:187:b16f:e779 with SMTP id ce21-20020a056a20441500b00187b16fe779mr4257730pzb.5.1700848095922; Fri, 24 Nov 2023 09:48:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700848095; cv=none; d=google.com; s=arc-20160816; b=K0zxYUlxko+8DelYXvGGSxKZ77Q2gZ8BS7LVSZAerMpFWVfjC0T1A9yCL6jaVnKiQZ DMFJmmCe5Na7w19LCGweV1nh8HGOnVpjuI+ilxeYfDJXVX05rDr2EWCJFG5zzLI75/21 O8lLlqyGE7haDyYCndR8s+R3gyu6nIdLP96Cn3bnxHsZB4v0+wIGU0OgGqD8PjRrBLWt ROxNM2qdEq1001BMM4eoiCwaDiZV0f5Hq6zHCD6Xjknp0sEKUk0YRDtxOs3TUD481HBx Gf409m0BkjRjH6wUt4t2yo9CCaHLqlPgamtr0sJ3wVCXVwOTvj+rlVVUUgULnxrsh4Vg j9KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=JhP3NCW/7xMlprJV1hfvm8C/zAowFcpIUy9q3d6+yQA=; fh=g8zd/LnuXp4Go9+D5vlCcehwSokAxeVRqep66iQeqms=; b=V1vjgMmpnlfEBm7YI8eVjRErU98bE7XQ9TqimdP0WMMi3UIbl0n674EZyuD3N7o9mR lChSrNy5a1O8peByRc1GCHmOHpDP9ksYePpBiNL/avniVwOgJ7mrx4sPYfCxAmThltHK 23JlSYMXulCTXv0Yn9F4uTfx1UpKlWJHSKv1PLtdNrmkV36vMl1tcZhrohHmCCpFxq7B /vIfjOFcsuaE61/AsWWXK5oTXbCpSNelTbk7iGazIuU/nvSPob9kykQSpA+Djn9tf65w zdo+2/vWK6H6IfvKsV254pKywkbisi2OsSYL38mu/lL/jNykli9agwlMxqg4O+YUIBud HKjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gZvUSkE9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id q3-20020a631f43000000b005c277ef191esi3803352pgm.295.2023.11.24.09.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 09:48:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gZvUSkE9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 5E79980477B1; Fri, 24 Nov 2023 09:47:28 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230484AbjKXRrR (ORCPT + 99 others); Fri, 24 Nov 2023 12:47:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbjKXRrP (ORCPT ); Fri, 24 Nov 2023 12:47:15 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7236AD56 for ; Fri, 24 Nov 2023 09:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700848042; x=1732384042; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pHB3kGp/ZHmJhMk/4OgkdCbBjqnP3BcYZuSuXzgIY0I=; b=gZvUSkE9A9toaDTVACeI/SDm5xOB1wwSCvqMu1iYmlB0iRvwVGQIwR8Z ck5a27RYtwNZcyVp5gtiOvXHbuCghJ7NdreWx/l3D5xlmh6QaHkAITLBC 7Y5eHvYmyrD38Zy1gLYbFiZkWhHbPkBtrj0hIH4TEzahIYMZXqlYYcr1V P/FB6nJb7X3nhN9ewPEEed96PHky2PIDIvM9A1C+3ZcCiQh7DMzsR5Jrz SbRJRlBDMDjn+vBjMxDjTGw32ZQDtOWmg6ISbNIY12slI3IbM5ijMg3X5 kZrYW0tau1iVsFy2BzU0nErmfczxw1y43SmHr/1nbcItDBDyNtYfTqZgL Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10904"; a="382853373" X-IronPort-AV: E=Sophos;i="6.04,224,1695711600"; d="scan'208";a="382853373" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2023 09:47:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10904"; a="761010357" X-IronPort-AV: E=Sophos;i="6.04,224,1695711600"; d="scan'208";a="761010357" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2023 09:47:20 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r6aGs-0000000GnJx-160x; Fri, 24 Nov 2023 19:47:18 +0200 Date: Fri, 24 Nov 2023 19:47:17 +0200 From: Andy Shevchenko To: Jiasheng Jiang Cc: lee@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mfd: intel-lpss: Add missing check for platform_get_resource Message-ID: References: <20230609014818.28475-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609014818.28475-1-jiasheng@iscas.ac.cn> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 24 Nov 2023 09:47:28 -0800 (PST) On Fri, Jun 09, 2023 at 09:48:18AM +0800, Jiasheng Jiang wrote: > Add the missing check for platform_get_resource and return error > if it fails. > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices") This does not fix anything and just introduces a duplication code. I would like this to be reverted. Should I send one? -- With Best Regards, Andy Shevchenko