Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231123070010.4013969-1-arnd@kernel.org>
In-Reply-To: <20231123070010.4013969-1-arnd@kernel.org>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 24 Nov 2023 19:28:39 +0100
Message-ID: <CAJZ5v0gNE8expsADwoTgDEoTa_5G-R_sBobFEiqLOh0VS5yVug@mail.gmail.com>
Subject: Re: [PATCH] ACPI: thermal_lib: include "internal.h" for function prototypes
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Zhang Rui <rui.zhang@intel.com>,
        Len Brown <lenb@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Nov 23, 2023 at 8:00 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added functions are declared in a header that is not included
> before the definition:
>
> drivers/acpi/thermal_lib.c:46:5: error: no previous prototype for 'acpi_active_trip_temp' [-Werror=missing-prototypes]
>    46 | int acpi_active_trip_temp(struct acpi_device *adev, int id, int *ret_temp)
>       |     ^~~~~~~~~~~~~~~~~~~~~
> drivers/acpi/thermal_lib.c:57:5: error: no previous prototype for 'acpi_passive_trip_temp' [-Werror=missing-prototypes]
>    57 | int acpi_passive_trip_temp(struct acpi_device *adev, int *ret_temp)
>       |     ^~~~~~~~~~~~~~~~~~~~~~
> drivers/acpi/thermal_lib.c:63:5: error: no previous prototype for 'acpi_hot_trip_temp' [-Werror=missing-prototypes]
>    63 | int acpi_hot_trip_temp(struct acpi_device *adev, int *ret_temp)
>       |     ^~~~~~~~~~~~~~~~~~
> drivers/acpi/thermal_lib.c:69:5: error: no previous prototype for 'acpi_critical_trip_temp' [-Werror=missing-prototypes]
>    69 | int acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 6908097aa5a7 ("ACPI: thermal_lib: Add functions returning temperature in deci-Kelvin")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/acpi/thermal_lib.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/thermal_lib.c b/drivers/acpi/thermal_lib.c
> index 646ff6bda6dd..4e0519ca9739 100644
> --- a/drivers/acpi/thermal_lib.c
> +++ b/drivers/acpi/thermal_lib.c
> @@ -9,6 +9,7 @@
>  #include <linux/acpi.h>
>  #include <linux/units.h>
>  #include <linux/thermal.h>
> +#include "internal.h"
>
>  /*
>   * Minimum temperature for full military grade is 218°K (-55°C) and
> --

Applied, thanks!