Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
To:     Karan Tilak Kumar <kartilak@cisco.com>
Cc:     sebaddel@cisco.com, arulponn@cisco.com, djhawar@cisco.com,
        gcboffa@cisco.com, mkai2@cisco.com, satishkh@cisco.com,
        jejb@linux.ibm.com, martin.petersen@oracle.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/13] scsi: fnic: Add and use fnic number
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1y1emtzok.fsf@ca-mkp.ca.oracle.com>
References: <20231114223221.633719-1-kartilak@cisco.com>
Date:   Fri, 24 Nov 2023 20:22:06 -0500
In-Reply-To: <20231114223221.633719-1-kartilak@cisco.com> (Karan Tilak Kumar's
        message of "Tue, 14 Nov 2023 14:32:21 -0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SChUKtG0qP/9EeWMxQ9pMEIsAJC/tFfTqDCs0GesrDad3JEZRprXfLmJy1LW?=
 =?us-ascii?Q?GErH1ocvriTXu6H7t0UAXbNT8ELDT5b2nUNxCGXutnCNDtcm0oUoQ8sxLtcE?=
 =?us-ascii?Q?mLoYLxp3MjP5Qe1M6qsYXNPz+Tx0cIWYRG2lFxULFlqvveX/TKelEWY4LnTW?=
 =?us-ascii?Q?SHrAuoxk9dYZyb0GzLhrzd15jX/+s5yxC0LtAYdI6FJrkobBe9xCbyE46oa3?=
 =?us-ascii?Q?UiXIObH/ZXud5mvFTSsG9u9N68XEUyQJNaRHmEx9xT4hYjjLTwtZWhQIHNjI?=
 =?us-ascii?Q?1fn/Pt+g+nuVufllHen5ka6RGE+3T22VgD2KK84GFFHIibhjIeGwxp9KE5Mx?=
 =?us-ascii?Q?s9UHfr1lkkb6DP45TJhyS47ge6gPaZXHzqsKOC1wbP9j2nDMiLgMCvYguaVi?=
 =?us-ascii?Q?R1O+MlLDWExofDJCCUHGskpLqhfs2dBt/EIQfh31DcXTrmVdvH3dFB6S01sT?=
 =?us-ascii?Q?8XNvLDXXb1YHVMuAnpJhIvnty1jlvYv2jxbRPPFDtQyY8BdQLkOwl2L580iD?=
 =?us-ascii?Q?OpI/RWwBbYQcvM8aKsXsYugWURKBOpJDvxk0wmf9mdCB/Swj4A6oQUf/NhSj?=
 =?us-ascii?Q?/8YcmPCuufp+5L0YoAjPkFzFa/lncU8acnNCsUzLm/+tUIjjcatYJoYY4gI4?=
 =?us-ascii?Q?e48Gsso+56R4NvW9Tv5Apj0yuENRKuhwK206EOjhDfsi9DhLElSoSnrckgW/?=
 =?us-ascii?Q?PrJ6b6a4xuBRGVI6z2F6SLBUE6N1F0pZN3+Hv6k8Vzf49XrHC8c8wtaU682o?=
 =?us-ascii?Q?aAupXhYBLc42+ZJDJX8vN3SQMEvdHaRJX6grfk2QLAPBFbr8GPryVz8THv+5?=
 =?us-ascii?Q?6auNr/NuNqb3/SGMvB4pxG6lJuZgOIxjyofXwk+Wsq8Uriere1kqrEmsb1u8?=
 =?us-ascii?Q?ONlP/aiXEh7wyWRMYDKVny5oTTJ6b/3BLvmtoKNt34jyWwCxTIlLxyEROzEx?=
 =?us-ascii?Q?JGb3NsXDnKRrbC+lQFwyDEIehb6092CHcG5SIprNlNt6cXeOKOc3pezTzSge?=
 =?us-ascii?Q?mTaahKTdEfkg+gzsrVU99L6yX6QARExwvoJJnUg8SkUTN3LMLL0yGikAbrWH?=
 =?us-ascii?Q?IJ74ZVIPgKn0ndflL3VWHtIg85MXLGRa+tIHPrt0b7ZFSyuKZk+9tBgb8TFt?=
 =?us-ascii?Q?5W+nTmRBoPDBf1fEEmeF7eNdObZeMkHfmsjRHatCHZ3i0/9y1UzwjF7RfX/g?=
 =?us-ascii?Q?mGMUIOBJ8eIN8FtSYn+h5RJQi47FPh1Lk2qYhbC02Jiv46fw3L8Mmobf12H3?=
 =?us-ascii?Q?jU1wa1po1BPjU4/ro439At2wtg0TI4x04C+IyhCxYa7htD5JYkywYjbUdSSn?=
 =?us-ascii?Q?L5pvJPtlO0krGHBCno+GTWMTK5xd7y96sTefimpe2driHK2nDu6JJ1oqiYjJ?=
 =?us-ascii?Q?y/t6acU72dlkOsFnIJ583AZqB6QclKRYyugIOwXFKLGVxSFyXJfjh19vS9Bh?=
 =?us-ascii?Q?RTOKbuLyBMxx69GB9ogUhXdJvPibrqfLadGrd/1rE9pmuvM2StGqzO1rjxwy?=
 =?us-ascii?Q?h2dkrfOA9LpWfZDWsQvzPXpGW6CY63FHXwcUdrt4qnBIGFHWgMc2I4VzNjVT?=
 =?us-ascii?Q?Ne7IxQDIKxKJ4tig4Rg5/OX2OTwwEMCE9iotGVEnIOHFOqXrxRc3SyXDsU5U?=
 =?us-ascii?Q?vA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Rf1OhJWbBQIYILM+UOSQSmFWw6HQbqEW3MTmJRXym3P6OyQpD4NxDX5rXRp4qoj4l3YPMRqPb9b1F/1YJwoIEiihiIDqussYJSZooQj1Co5MfZdTo6dFLPRjsXn1nJnIR75/R5YrF1iPafD8h37oKsdRneZHW5bBFikr3VldF94EtZOpILQDj9oYmcuSzz07UIYE7abx9ok5Xz4NFVCiKXKXc1/vQ20mbb2qopZtkF5W8GBcczXRs30b5bAooa1ceZqbpAonzgp/6yPhPNwn8xiH8PDc1NqUPHqUA11uSD9hr0tH9o6qZCKEkPPuuO/o8aIvVlHJq13lr62P71oE7ea4PjsVH37Qlt5eY2iIlHkNQOhG3kLFOeXxl9iu+SKQ679RczhHdmYiHbf45abVUmr29Ex/U/XJa+YICMgyCS5lF3ZfrqvAwZ4DCy1MuKbySBaFzD4IM3WN5W9V9mlpnbPoO3bAIC+pDGzqATbgMSN9VbWq9ISYt48bnm3h7Wq+j7e8SVvhXNtFyFXqf8ZVJBeSsRuv4mxYkxJWq/JD5o7syqSJ5iez8ddVZ9VnaTEV3kl0vEEKq1nnywcCkm4N+pimH/Ak7+rRzIoYEkXG2fNqKFPFh2UfDvS9ERjvmH2fG8dSHccX8UFfCHx6C8s3+XuXUOnrb7zG3x7+w4D5m0DzlsRd3fB3Xl0hxMpIno6nC7htPoztdD/r41MgkTm8AvD18m5rMAbrQjxBQOHxPBFEoXicA2ckJk4buzAEtfjEUjQznm/H4B3pEex9niABq1zwCz9k3AuNQeEQ/WZMSgVgaFRswi/Vj5880z9jCHwP6IddvsljFx9byACZDA6wWw==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: edef3b23-d770-41ef-f127-08dbed54f17e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2023 01:22:09.1069
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jwWQ9qa59rmp96b0Vl3JXZJb4hrkedDxOrAv+8nfLb7Zo8kElDfwgYKw9acQzz+xldoHdW/fxF0/UT04QK2seYJVyyu3QN7HLwd6JX7vF5w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5297
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-25_01,2023-11-22_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 mlxlogscore=717 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000
 definitions=main-2311250009
X-Proofpoint-GUID: iLCJDGbShimfjj7wYph8BIGRj-LylXSz
X-Proofpoint-ORIG-GUID: iLCJDGbShimfjj7wYph8BIGRj-LylXSz
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 24 Nov 2023 17:26:19 -0800 (PST)


Hi Karan,

> Add fnic_num in fnic.h to identify fnic in a multi-fnic environment.
> Increment and set the fnic number during driver load in fnic_probe.
> Replace the host number with fnic number in debugfs.

I agree with Hannes. Everything else in the stack will be using the host
number. Your change will make it harder to correlate a SCSI error
message to an fnic driver instance.

If you absolutely need an instance number I suggest you add it as an
orthogonal value instead replacing the host. Also, we typically use an
idr for enumerating things like this.

-- 
Martin K. Petersen	Oracle Linux Engineering