Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1619048rdh; Fri, 24 Nov 2023 18:54:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+DPSV6YUaD3evyRdExYoKUvRkSCv7XA9MPF/aRMTzfVB4UUB0Jm8wrfPpukcvxxXUIgCE X-Received: by 2002:a05:6808:309e:b0:3b8:43b6:1e34 with SMTP id bl30-20020a056808309e00b003b843b61e34mr6948919oib.30.1700880889081; Fri, 24 Nov 2023 18:54:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700880889; cv=none; d=google.com; s=arc-20160816; b=Hyh0pxYq/YrC5Y0wt7lE97ujoWiqQ0Lmmzn1dNURmHyv0UilpN6EfMiotliVaZ4Qb7 tN6Fy1XOqMyzsp6Cg+JwSJX1XxLNvqA8X/MqqpzJJ7lCvFUCzlK26O/erlo9LvooWPVF E3fqW9q8JN72+E3WViV7+scdfZRNstDfUhogWuZs4yX/qSshLvryPx16FQzchdDb25iW nID/scLCkRrl0m+kHzl0DHqN1UTKw8rSyMwupxaKWFr4OALKpGp8BqcP0tmzPkWSXyi1 +sFM9yzN/GgVq4KYPXr/iKor2Tt8UBjF2hmIoNLguCnlygkCmw8UeKGbinLvXWt6LyIy 3ifw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DB//RmChznsOdm7RWNNcbB7S3LcEYo8EEQ97c7anty8=; fh=7GZfWSA80jjfR/luPP0s1B2iobjC7wTTXU3astGHRfc=; b=NcZ7lxY1etgeTkbauOtopJn6XIiUaBItle0StAGuqqaxHatcnr53j7+CLnOtGij2Ew n8OWEv0phPUbZUccnG7gdMNh2pXy2j8IlvBujH9w1uF63ODkwefwxQ0c7bzVz0+4Ux2O Jh/JV6SIjLkds6CfBeuMasA3xBPgmNqGHo+jc1ydvtZ/TnCRxB3OwvQgJb/cvhPU+pFm LrId7KvjnXpj+gan7dqYnnDqTcPhMqScqOqFHrKAK8BUh2hX3rbRf9kd0l1lyDdDoHOg hhMJI2BAQwrkhIA5epEPzdS8xHJ0QC6fQLiD9psxzKdLg6FdZCXmt2MgaV+vT2VdUv+y dtiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=L23o7vYU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id fd31-20020a056a002e9f00b006be0f482c0fsi5067333pfb.63.2023.11.24.18.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 18:54:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=L23o7vYU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DFDBA802C8E2; Fri, 24 Nov 2023 18:54:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231726AbjKYCyd (ORCPT + 99 others); Fri, 24 Nov 2023 21:54:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231666AbjKYCy1 (ORCPT ); Fri, 24 Nov 2023 21:54:27 -0500 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB1821998; Fri, 24 Nov 2023 18:54:34 -0800 (PST) Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AP282uB002747; Sat, 25 Nov 2023 02:54:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=DB//RmChznsOdm7RWNNcbB7S3LcEYo8EEQ97c7anty8=; b=L23o7vYU4NpPhEEbZ9feW37RTgyxzXLsZ9jirdI2hZrJ2zsNHfPr/jBDywf7mI36ATnF uVpsmZO/9OYsgj5GAZn/aMv0JhU/M9iQ5zkp2qzj0M/mJvOVCr4DMPuNKzZZXket6oQo O2+5qoyFhbkVBuNfWqpES1u3dRZSZRysdg0Wn/7D+5ZhamfCH92gdtx9dFe2p2+not+Y UATdjxesT0mnLMCb9GtikvcI9dvLZgxH1BNL/8Qk8fS5gugRiyhW0ruTt3bbhG0QhIQk RUbQKSGTOtzK59ag3DjxefP1EDQUc/o7mZl2EXgnrY1EDUUFD8wPHR6ro39BAyEuvLrO Tw== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3uk7ucg12b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 25 Nov 2023 02:54:30 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3AP1XqlO027040; Sat, 25 Nov 2023 02:54:29 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3uk7c99f5y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 25 Nov 2023 02:54:29 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AP2sRSr011828; Sat, 25 Nov 2023 02:54:28 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3uk7c99f5h-3; Sat, 25 Nov 2023 02:54:28 +0000 From: "Martin K. Petersen" To: Saurav Kashyap , Javed Hasan , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" , Justin Stitt Cc: "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] scsi: bnx2fc: replace deprecated strncpy with strscpy Date: Fri, 24 Nov 2023 21:54:15 -0500 Message-ID: <170087016625.1036733.14760172612221800618.b4-ty@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231023-strncpy-drivers-scsi-bnx2fc-bnx2fc_fcoe-c-v1-1-a3736943cde2@google.com> References: <20231023-strncpy-drivers-scsi-bnx2fc-bnx2fc_fcoe-c-v1-1-a3736943cde2@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-25_01,2023-11-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 mlxlogscore=687 mlxscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311250020 X-Proofpoint-GUID: y8uFlME6m-oVT9cPp01O0QjKBzo_CeVc X-Proofpoint-ORIG-GUID: y8uFlME6m-oVT9cPp01O0QjKBzo_CeVc X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 24 Nov 2023 18:54:48 -0800 (PST) On Mon, 23 Oct 2023 20:12:22 +0000, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We expect hba->chip_num to be NUL-terminated based on its usage with > format strings: > > [...] Applied to 6.8/scsi-queue, thanks! [1/1] scsi: bnx2fc: replace deprecated strncpy with strscpy https://git.kernel.org/mkp/scsi/c/b04a2eff9e9c -- Martin K. Petersen Oracle Linux Engineering