Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1619067rdh; Fri, 24 Nov 2023 18:54:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IGLqekIdBusrs/WCsWDAy33nrR2i2SVY1fQgBS2QRI4nffsInSiN5dFtKMSAdJodNgTtFG3 X-Received: by 2002:a05:6a20:729c:b0:18c:7b7:8630 with SMTP id o28-20020a056a20729c00b0018c07b78630mr3737763pzk.13.1700880893072; Fri, 24 Nov 2023 18:54:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700880893; cv=none; d=google.com; s=arc-20160816; b=f3FD6YZ2iH/IgW2cVasFMrngLdt+4K4mCo5IsX48p1CEP4UypH3dSoYtBJPFkxKVMv cNghmEyUdDNZuD8PY8XJLY8zNIM2ZORI+5VV/K6juW1Nn1aTIEyhW0hp3APgQPTf4wwm X3lrn8Akd+wtv/jhDfXl31EF9HN5F5EVQbEwsyf/nzrxU62mhMQgo8/KU8Q6RKNAk9F+ t5OXITNtM8wARK86ug2mgck26RmCG6xZrLY5K5VjYzDQRdBBoeJBikblrL2Q5QBy82wv LZwcHEu2TEPCXupBxQTEUs4X3KjeV58h51oRrAefKZVRzoNrCQI0pV+D0i4K1gBycnoc 7pOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=K7jMtRbm8/3e9jSFRh1rR8pLgVX6BikWUzpJbkHIpbw=; fh=m1n1Gh/OzYQpibH2hVMDmPlFULAxiajGeES82485rh0=; b=cAGVvosa/ZsNP9G4QNYEy/h3ppftdurKOzH3ymwxYLj/EymI8XPJdjw1MK0Jr8e9bi 10/Hq1n54jzA4WpxKZhC07gKQSGFJe/zl4o797p6Afgxn/ty/KeNZsM3i9gukYMcHJLf qkShqghDQGbxrwJK/2i1cVpa95ITOa5/bMdN3UO8tF5AJaCGuOY55Nl2J+p77rEXg/nk 8ZwjuM1lYjfTXMVKKeDODjAWLEvArtu8qLsNmRd0z8ynPVVk9vFDIJbuf7zYFlWJ6INW 1goLHLB43MaNnSv76xkJU3vWm/CyY3ng7ocDLktmJvkwIOfBQPFYRO6ZG+XMwQNBai7x 2HGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=eIFwoogH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id d6-20020a170902cec600b001c7388413besi5037151plg.529.2023.11.24.18.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 18:54:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=eIFwoogH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 1BC17801B9D6; Fri, 24 Nov 2023 18:54:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229810AbjKYCyi (ORCPT + 99 others); Fri, 24 Nov 2023 21:54:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231694AbjKYCyb (ORCPT ); Fri, 24 Nov 2023 21:54:31 -0500 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C007319A7; Fri, 24 Nov 2023 18:54:37 -0800 (PST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AP1a7wc027073; Sat, 25 Nov 2023 02:54:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=K7jMtRbm8/3e9jSFRh1rR8pLgVX6BikWUzpJbkHIpbw=; b=eIFwoogHNCNuDgJgkFxd6bUhGxsVQf/BOSftVjKZxp3ngLPN+YJ1t3lnIbpjetZUoZkB Ur9XhJ+VKBPQkevqWtXs4pN/txniuhjqLU1fQpuJbARxezN9CrUAaoqBkbsTz+TaAI0/ 5hCfZ3y0kDPQNEaO2SHtAmZSLDznQrz1hfbI+tje41Da9YV1/TxjZJPOUjBb9/WV1xme 8ED2pk4c+We02BSkZViN2itPt3Lyu6ATT85nxaW/YTlgMZrpuDiaWIhwY8J0nUKNt70Z LmqPIpdyz98u8hSW14jh9/e4Y4PdUu2KTYwqTiIae6wCGE/Bw30w8sQBcORrC+G4AIGt mg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3uen5bkxgt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 25 Nov 2023 02:54:29 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3AP1Xm0b026991; Sat, 25 Nov 2023 02:54:28 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3uk7c99f5p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 25 Nov 2023 02:54:28 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AP2sRSn011828; Sat, 25 Nov 2023 02:54:27 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3uk7c99f5h-1; Sat, 25 Nov 2023 02:54:27 +0000 From: "Martin K. Petersen" To: Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , James Seo Cc: "Martin K . Petersen" , "James E.J. Bottomley" , Kees Cook , "Gustavo A. R. Silva" , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 00/12] scsi: mpt3sas: Use flexible arrays and do a few cleanups Date: Fri, 24 Nov 2023 21:54:13 -0500 Message-ID: <170087016621.1036733.18221067551058409419.b4-ty@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20230806170604.16143-1-james@equiv.tech> References: <20230806170604.16143-1-james@equiv.tech> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-25_01,2023-11-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311250020 X-Proofpoint-GUID: ELDKgNLqVdfqSQd3bBOKeQnbdrxjsUHc X-Proofpoint-ORIG-GUID: ELDKgNLqVdfqSQd3bBOKeQnbdrxjsUHc X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 24 Nov 2023 18:54:52 -0800 (PST) On Sun, 06 Aug 2023 10:05:52 -0700, James Seo wrote: > Commit df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3") has > resulted in the only arrays that UBSAN_BOUNDS considers unbounded > being trailing arrays declared with [] as the last member of a > struct. Unbounded trailing arrays declared with [1] are common in > mpt3sas, which is causing spurious warnings to appear in some > situations, e.g. when more than one physical disk is connected: > > [...] Applied to 6.8/scsi-queue, thanks! [01/12] scsi: mpt3sas: Use flexible arrays when obviously possible https://git.kernel.org/mkp/scsi/c/aa4db51bbd51 [02/12] scsi: mpt3sas: Make MPI2_CONFIG_PAGE_IO_UNIT_8::Sensor[] a flexible array https://git.kernel.org/mkp/scsi/c/f7830af68eb6 [03/12] scsi: mpt3sas: Make MPI2_CONFIG_PAGE_RAID_VOL_0::PhysDisk[] a flexible array https://git.kernel.org/mkp/scsi/c/cb7c03c5d357 [04/12] scsi: mpt3sas: Make MPI2_CONFIG_PAGE_SASIOUNIT_0::PhyData[] a flexible array https://git.kernel.org/mkp/scsi/c/dccc1e3ed9e3 [05/12] scsi: mpt3sas: Make MPI2_CONFIG_PAGE_SASIOUNIT_1::PhyData[] a flexible array https://git.kernel.org/mkp/scsi/c/e249a957ce43 [06/12] scsi: mpt3sas: Make MPI26_CONFIG_PAGE_PIOUNIT_1::PhyData[] a flexible array https://git.kernel.org/mkp/scsi/c/1f1126609969 [07/12] scsi: mpt3sas: Use struct_size() for struct size calculations https://git.kernel.org/mkp/scsi/c/f4f76e141769 [08/12] scsi: mpt3sas: Remove the iounit_pg8 member of the per-adapter struct https://git.kernel.org/mkp/scsi/c/66f2a53fc620 [09/12] scsi: mpt3sas: Fix an outdated comment https://git.kernel.org/mkp/scsi/c/8a3db51e01d5 [10/12] scsi: mpt3sas: Fix typo of "TRIGGER" https://git.kernel.org/mkp/scsi/c/e5035459d302 [11/12] scsi: mpt3sas: Replace a dynamic allocation with a local variable https://git.kernel.org/mkp/scsi/c/dde41e0c1cc2 [12/12] scsi: mpt3sas: Replace dynamic allocations with local variables https://git.kernel.org/mkp/scsi/c/e18821556272 -- Martin K. Petersen Oracle Linux Engineering