Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1619068rdh; Fri, 24 Nov 2023 18:54:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IEtOWbU2+fAHRw3anC65R0DIRIujc6/b9vc9TOY3kZb7vg2WZTfB3587AiK+SSst8btO2Ze X-Received: by 2002:a17:90a:f006:b0:285:777d:7b7f with SMTP id bt6-20020a17090af00600b00285777d7b7fmr8586726pjb.13.1700880893314; Fri, 24 Nov 2023 18:54:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700880893; cv=none; d=google.com; s=arc-20160816; b=ktW7ODFuPkfneb1FgFcqYTreTnVgelY8zbSEBhuto2SugVH5Zcuu6RBFFjfyUdGQN2 t7eSAdohqi7qM0a6fA86OuUqk7xsaEkyF4s7MVwJmxiyanmLclIula670/eTkIC8UKTe K0WS3PzLWVNNnOFGmhw4cyqlruSS5fMx3tQrpEM03yLaLwjJjO9jUcAFLLlqrNUynw92 uYqYP7Q0pvlrmgYJTkQRMuxKv3Tc4M4IEweYRTvcQYGcy6uqSSJZ8HEKj+sMioF7ig1l 4WpCJONgCEw2FIT6KpwafwOF4T29Nu0GvnAcuA5IjxKZCGoU9YWmcAOkURPSQ/XcnZIC KUIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=V1EvjHFDdB5RgF7K1AGuoYod4vq925hfukjjcv5bSVE=; fh=U4W/b+NtYDg6JlN/0bgoYMpMxKjUqSctgE5DXMIR5b0=; b=lmFJrzevR3IWmc3qiN/f/roE1oRQhdAIF2m57h6ncd+FN3TFDzarJ9EAbg+XAP183M AF2FO51ETmlmoFOqiEku74R1RlvI3kF+DyoMQyGhTBpfTCd4ha840J1wfGVBxhzPtAu2 jP+jHWY/PFilZcW6pvaVcrTyXpv7w2RCOFf3XbBx5pWIaw0iKu+jsNz5Zx1S3nXw98r+ N81qXa1ADjwY7JSkNCHM1NfWlOOdi4x4Ak68FiWeDTgiX7UbgFeIr5N3m0g/78O/44fk QpOIRrX1efaRpLWPskqXWtPX8jtXugTIgPZYH6OFqIi1G3E5zhLQG3t5C2IEVPHVVR2V lUPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=M+NCnrhm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id mr21-20020a17090b239500b002803298b98asi5303462pjb.43.2023.11.24.18.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 18:54:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=M+NCnrhm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id DFF068042501; Fri, 24 Nov 2023 18:54:45 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229710AbjKYCy1 (ORCPT + 99 others); Fri, 24 Nov 2023 21:54:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229569AbjKYCy0 (ORCPT ); Fri, 24 Nov 2023 21:54:26 -0500 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D4271990; Fri, 24 Nov 2023 18:54:33 -0800 (PST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AP1aDuJ027085; Sat, 25 Nov 2023 02:54:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=V1EvjHFDdB5RgF7K1AGuoYod4vq925hfukjjcv5bSVE=; b=M+NCnrhmf3RV4wjHIHmHFcUE+moSwhGGtbfpd6BNwiYAsWZMVlCBvNqmYWppYlMzAtuS rwe0ojbvYHGYQBg5NiVvTXn/QoPbd6Y9jV1Oxt/aV/1Z/PLftg/VdUHc6S9r2sanVY4R QnfSzB63SCseJ8qbpbkRUZaBqIbnaLQOcD213xu90F1O8Ld3zc76PUD2BeJzFqq3hVji xmjJYqJeReUGm0hAv0n1mBZlNvGRn3Cok5ydr6qyHdkdO1eJ/suGrJBrcMTH5qpqg8uh ZGJJZjyqvE6dRrMzR7dKNvnSX6a4Vc4i9JMwCS3EoYg7JO2okKd8CTQlB9DL8gYyGrI0 6Q== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3uen5bkxgu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 25 Nov 2023 02:54:31 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3AP1YA0O027690; Sat, 25 Nov 2023 02:54:29 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3uk7c99f67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 25 Nov 2023 02:54:29 +0000 Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AP2sRSv011828; Sat, 25 Nov 2023 02:54:29 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3uk7c99f5h-5; Sat, 25 Nov 2023 02:54:29 +0000 From: "Martin K. Petersen" To: "James E.J. Bottomley" , Justin Stitt Cc: "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] scsi: csiostor: replace deprecated strncpy with strscpy Date: Fri, 24 Nov 2023 21:54:17 -0500 Message-ID: <170087016625.1036733.15170921326314557519.b4-ty@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231023-strncpy-drivers-scsi-csiostor-csio_init-c-v1-1-5ea445b56864@google.com> References: <20231023-strncpy-drivers-scsi-csiostor-csio_init-c-v1-1-5ea445b56864@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-25_01,2023-11-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 mlxlogscore=876 mlxscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311250020 X-Proofpoint-GUID: jTpubG0R1qsZjTe4kAiIn0aH34t4wsAj X-Proofpoint-ORIG-GUID: jTpubG0R1qsZjTe4kAiIn0aH34t4wsAj X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 24 Nov 2023 18:54:46 -0800 (PST) On Mon, 23 Oct 2023 20:26:13 +0000, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > `hw` is kzalloc'd just before this string assignment: > | hw = kzalloc(sizeof(struct csio_hw), GFP_KERNEL); > > [...] Applied to 6.8/scsi-queue, thanks! [1/1] scsi: csiostor: replace deprecated strncpy with strscpy https://git.kernel.org/mkp/scsi/c/4592411784cc -- Martin K. Petersen Oracle Linux Engineering