Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1629710rdh; Fri, 24 Nov 2023 19:23:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGg3gMMaRLZvezv7bycCWKFbBvAPVmUBCXaeFW6tmqyPw0xgvE6VCMrPJDHW3dvrweldg63 X-Received: by 2002:a17:902:bd46:b0:1cc:1efb:1bab with SMTP id b6-20020a170902bd4600b001cc1efb1babmr5372215plx.38.1700882585710; Fri, 24 Nov 2023 19:23:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700882585; cv=none; d=google.com; s=arc-20160816; b=wHZJvXdaDPBdFAa2WbRZI2jC6DQspkNPe3BTWNpSCC4BbjamiX+3E6xj2WgDUFhOaD R8KGczWgi/BpGzvGPZWX7iWQJEfweIAMagzmMryViKOGv1a9NQFLkjkXaKhFjTiQgLiX SG3jCGoZnCfUxJ3zJdDQWnNy0ERens+myUZys3NELszzuzFEH6au8JCcdsN4KzrY337F nTuAL44N3MxZ7wvG1ccKtl1vIXZdn63m/FKwd0KW/WTDA0z7TR/pcC3BtTI4rdsx40av f1cmJSuPeJceDouJ7RWaFUYDw1ePJk+TKfHuYLEzKgMWevc1vJNAcflILS9RqwdNFsxV /3dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=rMvToBJHCipDORTIOSmsVjLY4hgs4GLBlWC934vVrzc=; fh=s7aYjE8WzB+A4D0+XBtVV/epkYEx6v5yREShTvrsj8w=; b=aD9K32d9E1eYmqDBqT/Mz4txQlmzrQ9hSe5LunMHrscbrTJDzPublbLAbGWbRPLbsS mlUTbNNGBBV/8t5KD7m5KkmfepvWrmAKiEDDPwW3EW8QYswc/TeBEIpQ86PgYNpVrPlM wOH8Cu09bUrl20ta6OdcM5foHI2bf74WIje1RngBEi8jj7OSeSOjvTLG0wr2gDQKXdl7 rQi5sOZ9xNKEBX3exBd1DfvMn7Tw4NApI2fiXqsBkJzsMvXIm0PRAPtLN1GF0DxfYaMs 3mDRoLZHVL7oYjgUZRZPiTGPmF9cC3QNrXBSqRxJ3eXkLT4Sc8OnCKU6bqR+/2tniNPw DDJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Z2gjmPrR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id q22-20020a170902789600b001b8a8f359fcsi4608469pll.208.2023.11.24.19.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 19:23:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Z2gjmPrR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 615A4804270B; Fri, 24 Nov 2023 19:23:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229569AbjKYDWr (ORCPT + 99 others); Fri, 24 Nov 2023 22:22:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjKYDWq (ORCPT ); Fri, 24 Nov 2023 22:22:46 -0500 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69F391998; Fri, 24 Nov 2023 19:22:52 -0800 (PST) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a0b7f793b8aso20395666b.2; Fri, 24 Nov 2023 19:22:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700882571; x=1701487371; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rMvToBJHCipDORTIOSmsVjLY4hgs4GLBlWC934vVrzc=; b=Z2gjmPrR3i8u5WyiPBeURBcjuK4mjdS5RiPY86krSs92DWvPXIDeWqk8Ta3AU2LmPk oLRhEWcQCKNhRof4skVb/FBTUz37eDYTlDmgQIIGQdlFC5vAjNNE/1KiXFhYORALiOvu FBBEwEiNEI4AQcka2Ot5/Y4RvDWjz12qvUbsV+2kxrcutZCPLJSJi3dl2AsyZtPnz/Ha R98FO0w37fcZcuO0ugnLKBD8U7AQEEYBon40F/qrDU57HjUCBvzVOCND9JIU/nL3CJQP uNJ4bb41iXZAZbkhpf0sq/8VfYId9LDkXriHkXAB23nMqLU/ReuIW37w4wDhWaru8joi cIvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700882571; x=1701487371; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rMvToBJHCipDORTIOSmsVjLY4hgs4GLBlWC934vVrzc=; b=wQqXFhCYq4PjRghxhRHJpFiVrxQG4ZF6V/fWOIORPz8CObFxE3t7rISPYv1wh1Kezd S3ADgeunO6pid9S9N52R3QMxJJGVBsvfQsRzNImrX+MGw5QRS6IHwbK45iz8FCAbu6r3 hYsTxzdq/BQdI5Jldmvcr7JMPTkCCOwN47HGBvfxK75qaK5HRZraZE+SHwiWJyHrLAy1 hBFmt7dRiAN4RoogOabZ3NQC1z9pWP2exNrGD9zm3LVAJ/bngev1S4H1IX5ERJGyDkcq e2ejEtv5vmioqPIsmrJ6ZelgwEAFbA9rgZRpOyyy9/7zjSaRUJE5pb/sx9pXcmjhQiXF WD0w== X-Gm-Message-State: AOJu0Yz5o09sxXGHLhDicr5HkBt4Xmy1Rlfjb29MfGQodxzRyD8H1JYl Zol6wJfXZm6f2pPdRTAavpBafHDsmpXJ+dUbb5vPsUnXMaQ= X-Received: by 2002:a17:906:3787:b0:a02:9700:bf53 with SMTP id n7-20020a170906378700b00a029700bf53mr3599111ejc.46.1700882570638; Fri, 24 Nov 2023 19:22:50 -0800 (PST) MIME-Version: 1.0 References: <1297339.1700862676@warthog.procyon.org.uk> <1335877.1700868425@warthog.procyon.org.uk> In-Reply-To: <1335877.1700868425@warthog.procyon.org.uk> From: Steve French Date: Fri, 24 Nov 2023 21:22:38 -0600 Message-ID: Subject: Re: [PATCH] cifs: Set the file size after doing copychunk_range To: David Howells Cc: Steve French , Shyam Prasad N , Rohith Surabattula , Jeff Layton , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: multipart/mixed; boundary="0000000000006d8c61060af19511" X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 24 Nov 2023 19:23:03 -0800 (PST) --0000000000006d8c61060af19511 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable updated On Fri, Nov 24, 2023 at 5:27=E2=80=AFPM David Howells = wrote: > > David Howells wrote: > > > + truncate_inode_pages_range(&target_inode->i_data, destoff, len); > > That should actually be: > > truncate_inode_pages_range(&target_inode->i_data, destoff, destof= f + len); > > David > > --=20 Thanks, Steve --0000000000006d8c61060af19511 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-cifs-Set-the-file-size-after-doing-copychunk_range.patch" Content-Disposition: attachment; filename="0001-cifs-Set-the-file-size-after-doing-copychunk_range.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lpdhjyx10 RnJvbSBjNjAwOGFkMjM0MjJjMGEyOWQxYmExNzU5MDVjZDhhMDJiNWRmNWI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBIb3dlbGxzIDxkaG93ZWxsc0ByZWRoYXQuY29tPgpE YXRlOiBGcmksIDI0IE5vdiAyMDIzIDIxOjUxOjE2ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gY2lm czogU2V0IHRoZSBmaWxlIHNpemUgYWZ0ZXIgZG9pbmcgY29weWNodW5rX3JhbmdlCgpTZXQgaV9z aXplIG9uIHRoZSBpbm9kZSBhZnRlciBkb2luZyB0aGUgY29weWNodW5rX3JhbmdlIG9wZXJhdGlv biBhcyB0aGlzCnZhbHVlIG1heSBiZSB1c2VkIGJ5IHZhcmlvdXMgdGhpbmdzIGludGVybmFsbHku ICBzdGF0KCkgaGlkZXMgdGhlIGlzc3VlCmJlY2F1c2Ugc2V0dGluZyAtPnRpbWUgdG8gMCBjYXVz ZXMgY2lmc19nZXRhdHIoKSB0byByZXZhbGlkYXRlIHRoZQphdHRyaWJ1dGVzLgoKQWxzbyByZWR1 Y2UgdGhlIHBhZ2VjYWNoZSB0cnVuY2F0aW9uIHRvIG9ubHkgaW52YWxpZGF0ZSB0aGUgcmFuZ2Ug b2YgYnl0ZXMKdGhhdCB3aWxsIGJlIGNvcGllZCBvdmVyIG90aGVyd2lzZSB3ZSB3aWxsIGRpc2Nh cmQgZGlydHkgZGF0YSB0aGF0IGlzbid0Cmluc2lkZSB0aGUgdGFyZ2V0IHJhbmdlLgoKRml4ZXM6 IDYyMGQ4NzQ1YjM1ZCAoIkludHJvZHVjZSBjaWZzX2NvcHlfZmlsZV9yYW5nZSgpIikKQ2M6IHN0 YWJsZUB2Z2VyLmtlcm5lbC5vcmcKU2lnbmVkLW9mZi1ieTogRGF2aWQgSG93ZWxscyA8ZGhvd2Vs bHNAcmVkaGF0LmNvbT4KY2M6IFNoeWFtIFByYXNhZCBOIDxuc3BtYW5nYWxvcmVAZ21haWwuY29t PgpjYzogUm9oaXRoIFN1cmFiYXR0dWxhIDxyb2hpdGhzLm1zZnRAZ21haWwuY29tPgpjYzogSmVm ZiBMYXl0b24gPGpsYXl0b25Aa2VybmVsLm9yZz4KU2lnbmVkLW9mZi1ieTogU3RldmUgRnJlbmNo IDxzdGZyZW5jaEBtaWNyb3NvZnQuY29tPgotLS0KIGZzL3NtYi9jbGllbnQvY2lmc2ZzLmMgfCA3 ICsrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZnMvc21iL2NsaWVudC9jaWZzZnMuYyBiL2ZzL3NtYi9jbGllbnQvY2lm c2ZzLmMKaW5kZXggZWEzYTdhNjY4YjQ1Li5mODQ1ZTczNWYxMTYgMTAwNjQ0Ci0tLSBhL2ZzL3Nt Yi9jbGllbnQvY2lmc2ZzLmMKKysrIGIvZnMvc21iL2NsaWVudC9jaWZzZnMuYwpAQCAtMTMwNywx MiArMTMwNywxNSBAQCBzc2l6ZV90IGNpZnNfZmlsZV9jb3B5Y2h1bmtfcmFuZ2UodW5zaWduZWQg aW50IHhpZCwKIAkJZ290byB1bmxvY2s7CiAKIAkvKiBzaG91bGQgd2UgZmx1c2ggZmlyc3QgYW5k IGxhc3QgcGFnZSBmaXJzdCAqLwotCXRydW5jYXRlX2lub2RlX3BhZ2VzKCZ0YXJnZXRfaW5vZGUt PmlfZGF0YSwgMCk7CisJdHJ1bmNhdGVfaW5vZGVfcGFnZXNfcmFuZ2UoJnRhcmdldF9pbm9kZS0+ aV9kYXRhLCBkZXN0b2ZmLCBkZXN0b2ZmICsgbGVuKTsKIAogCXJjID0gZmlsZV9tb2RpZmllZChk c3RfZmlsZSk7Ci0JaWYgKCFyYykKKwlpZiAoIXJjKSB7CiAJCXJjID0gdGFyZ2V0X3Rjb24tPnNl cy0+c2VydmVyLT5vcHMtPmNvcHljaHVua19yYW5nZSh4aWQsCiAJCQlzbWJfZmlsZV9zcmMsIHNt Yl9maWxlX3RhcmdldCwgb2ZmLCBsZW4sIGRlc3RvZmYpOworCQlpZiAocmMgPiAwICYmIGRlc3Rv ZmYgKyByYyA+IGlfc2l6ZV9yZWFkKHRhcmdldF9pbm9kZSkpCisJCQl0cnVuY2F0ZV9zZXRzaXpl KHRhcmdldF9pbm9kZSwgZGVzdG9mZiArIHJjKTsKKwl9CiAKIAlmaWxlX2FjY2Vzc2VkKHNyY19m aWxlKTsKIAotLSAKMi4zOS4yCgo= --0000000000006d8c61060af19511--