Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1657332rdh; Fri, 24 Nov 2023 20:50:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IGNELG3mNPSUiuEmw0Ppm7fQf4ayHojqQsKi7VLfPPRwvWrA9mdvfm+jz8D/MjwvmfGpoyc X-Received: by 2002:a17:902:da82:b0:1cc:5674:9184 with SMTP id j2-20020a170902da8200b001cc56749184mr5866120plx.31.1700887815994; Fri, 24 Nov 2023 20:50:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700887815; cv=none; d=google.com; s=arc-20160816; b=HwMhszlqvehQWozVgkH2VaROV0e7OJLbbxhiCAJ8AJXMw7+wg5llIvAYng9QoM38zm 194PuxYIFPpz62tKr/l9KvCn1WsBMLfJ0mg+CvBwibH+MjEhPrWo/FhS44P8Ek5cMMhV 1LDSP+34jzvlXwXoFBm9dO6HBchUpCfiC6KEER9kOjkHX43zauhXQ1a2NeUzFaicL56r ++rvy/OybhML+ehnLn76P1/5feTc9I6abBkv9XiXW/Pfqz+LvxgMhERFDdNJpL1OdPJ3 j8O1srQpe+KclpW0F8jtWDgUEErNz/lH2KuTljdTN3wDWYTJFv7QKBFYK/nU5aK+7byO cAMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nLYARbPomSl/uJGWsvEa59hDCCv752oywOGu0kXKEgI=; fh=klp1rs+3KCYjzHfPA6JWqE1JFLttdGczyzIB0QScJ6E=; b=GZ5M7Wn3LfQOeDWIf3dQRo3GqiG3NIB/1/JpvhFD9rclPic8dHrQiMSM7WMqV3Ryda vNRcBA4SE2tvgTyH+gGP7Xwxvi+xJjT98ZJlnOD62rmIN+A9hHLAQunviEoT7fLQoVBi XioDM02z5elOdyv0Nu2mek19Rtd/C2lzSI63IEdyU6WX2W6KOuxod5GWXBqJdVYDChuw 7Fj0KevE+vVkkjOkqsVl4EMA0jnnC5pHxp9IELRuWRNRZVenFJziH5c5zoXMXRVXnZQz 3LeEkYLx1UU5qiD91H8BmSk2fWEx0Ro/SmjyBXGNj20S0XWnOqYYo7QcWrSJ3xhhdEHc /RlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="m998r/w5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id q2-20020a170902788200b001cf677b6c20si4600115pll.594.2023.11.24.20.50.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 20:50:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="m998r/w5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id E2909822B8C8; Fri, 24 Nov 2023 20:50:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231676AbjKYEp1 (ORCPT + 99 others); Fri, 24 Nov 2023 23:45:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjKYEpZ (ORCPT ); Fri, 24 Nov 2023 23:45:25 -0500 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FA5D10FB; Fri, 24 Nov 2023 20:45:32 -0800 (PST) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-5c194b111d6so1792003a12.0; Fri, 24 Nov 2023 20:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700887532; x=1701492332; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nLYARbPomSl/uJGWsvEa59hDCCv752oywOGu0kXKEgI=; b=m998r/w53Ee0b1TbPST4ZIXusD70rwF/WK+MfRxUDqVllRvEC1DNO6/l15xWBfE9nC FAtbRJRfIO13YoYVS2YNFlaFT/UJIpQk99mqL209PBgAD0SODRjE/ii9wt8HC2wihlqa x23wTOKdim41A4NM/Y1rILOPaq4FC3MpIiaUw5OMZ7sX5m4zoEyPZJ8cIKP9252u9cZq L2qlxOiKx6NpKoOrjAT5APMXNKKm77iFY4Aq2TvctrRgZRqX/NJdJ5lmxnIJFYjx3VFP a6Keyn1J+FNvKBP10xa8vsdqZg+lIt2LfSs5RCq/+31+YlFq1PDAtUEiNq61ftYKUeID 4RbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700887532; x=1701492332; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nLYARbPomSl/uJGWsvEa59hDCCv752oywOGu0kXKEgI=; b=j+KRr8pOid8WSwxdz/CDalYSTHZrb/lT6nJH8Fa/eZ1DTj2yjIKDpte4MLkJGltWOM yzljSaEnDRW3S2nEKJ3mQ/R4b7NAk8xmuxXCk7Jd/GzwQ9Ax54/45XCj/XIOv1kNjt+W T8bMcmiD+nVgFJEYQQQmOVZyuE+m2U/0LhHGHLPINxyC/JkKhhCjWkY6a0VFO0lr33SJ 7UTA016zkxUPN8nBCCcTid1AQsh3HRiPDK/JDP2ZUuegYfqwhn9hK60KkDoQBQ6cuNzl v+ib5a7lEul4roG6Q7jYcs8w3ELO7IbCyZbRlSmXDUUxGuZYyOEWqyQIbGU19G+pmzmS BDhw== X-Gm-Message-State: AOJu0YxG4tG4bmeKU/nLlveortSgzqV5pmigew+qCEtzL5jjSCi4yPIW Wb8iXlidja2KZdLAB3qPiiU= X-Received: by 2002:a17:902:c40d:b0:1ce:33b2:a1e0 with SMTP id k13-20020a170902c40d00b001ce33b2a1e0mr6976140plk.33.1700887531598; Fri, 24 Nov 2023 20:45:31 -0800 (PST) Received: from google.com ([2620:15c:9d:2:8b5c:82d0:578f:d0]) by smtp.gmail.com with ESMTPSA id x16-20020a170902ec9000b001cfb41589ddsm391726plg.293.2023.11.24.20.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 20:45:31 -0800 (PST) Date: Fri, 24 Nov 2023 20:45:28 -0800 From: Dmitry Torokhov To: Jonathan Denose Cc: linux-input@vger.kernel.org, Jonathan Denose , Hans de Goede , Huacai Chen , Mattijs Korpershoek , Takashi Iwai , Werner Sembach , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: i8042 - add quirk for Lenovo ThinkPad T14 Gen 1 Message-ID: References: <20230925163313.1.I55bfb5880d6755094a995d3ae44c13810ae98be4@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230925163313.1.I55bfb5880d6755094a995d3ae44c13810ae98be4@changeid> X-Spam-Status: No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 24 Nov 2023 20:50:13 -0800 (PST) Hi Jonathan, On Mon, Sep 25, 2023 at 04:33:20PM -0500, Jonathan Denose wrote: > The ThinkPad T14 Gen 1 touchpad works fine except that clicking > and dragging by tapping the touchpad or depressing the touchpad > do not work. Disabling PNP for controller setting discovery enables > click and drag without negatively impacting other touchpad features. I would like to understand more on how enabling PnP discovery for i8042 affects the touchpad. Do you see it using different interrupt or IO ports? What protocol does the touchpad use with/without PnP? If the protocol is the same, do you see difference in the ranges (pressure, etc) reported by the device? Thanks. -- Dmitry