Message-ID: <474E8669.6060409@cn.fujitsu.com>
Date: Thu, 29 Nov 2007 17:29:13 +0800
From: Li Zefan <lizf@cn.fujitsu.com>
User-Agent: Thunderbird 2.0.0.0 (X11/20070419)
MIME-Version: 1.0
To: Frans Pop <elendil@planet.nl>
CC: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
       tglx@linutronix.de, trivial@kernel.org
Subject: Re: [PATCH 6/6] tick: add a missing dot in prink
References: <474E6BD0.20103@cn.fujitsu.com> <E1IxfE8-0000Sr-9w@faramir.fjphome.nl>
In-Reply-To: <E1IxfE8-0000Sr-9w@faramir.fjphome.nl>
Content-Type: text/plain; charset=x-user-defined
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1315
Lines: 34

Frans Pop wrote:
> Li Zefan wrote:
>> Add a missing '.' in prink information.
>> -			printk(" no tick device\n");
>> +			printk(" no tick device.\n");
> 
> I wonder if that is correct. CodingStyle says:
>                 Chapter 13: Printing kernel messages
>    [...]
>    Kernel messages do not have to be terminated with a period.
> 
> I personally think that rule could be made a bit stricter as for example
> dmesg output currently looks fairly inconsistent with some messages
> terminated with a period while most messages are not and have been wondering
> if I should file patches to _remove_ periods.
> 
> Maybe the rule should be changed to:
>    Kernel messages should not be terminated with a period, unless a single
>    message contains multiple sentences.
> ?

But why a kernel message should not be terminated with a period? It does no harm
at all. And if the message is a complete sentence, it's grammatical correct to
terminated with a period.

I think CodingStyle just says an ending period is not mandatory. It does not
discourage the ending period.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/