Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Sat, 25 Nov 2023 14:54:29 +0000
To:     Alice Ryhl <alice@ryhl.io>
From:   Benno Lossin <benno.lossin@proton.me>
Cc:     rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        Miguel Ojeda <ojeda@kernel.org>,
        Wedson Almeida Filho <walmeida@microsoft.com>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        Andreas Hindborg <a.hindborg@samsung.com>,
        Alice Ryhl <aliceryhl@google.com>,
        Martin Rodriguez Reboredo <yakoyoku@gmail.com>,
        Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 3/3] rust: workqueue: add `#[pin_data]` to `Work`
Message-ID: <FAzxAy7jRUJ6uc-DBqKKJi76s7ddxab9IyXMW5g_SxyxJKCSH8Xarqda9M3-DTDFvlgmNr9S8-X4prDvw57ZLYqR953uK6pd1qGqFpXWWXk=@proton.me>
In-Reply-To: <45e5de7e-d787-4200-82dc-389cbdad9ee8@ryhl.io>
References: <20231125125024.1235933-3-benno.lossin@proton.me> <45e5de7e-d787-4200-82dc-389cbdad9ee8@ryhl.io>
Feedback-ID: 71780778:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 25.11.23 15:35, Alice Ryhl wrote:
> On 11/25/23 13:51, Benno Lossin wrote:
>> +        pin_init!(Self {
>> +            work: Opaque::ffi_init(|slot| {
>=20
> Surely there should be an <- here instead of the : character?

You are absolutely correct. I did this so rustfmt would format it nicely. B=
ut
forgot to change it back.

--=20
Cheers,
Benno