Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1951888rdh; Sat, 25 Nov 2023 08:08:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IEaSBS81W9WqRl6R87F5VnEV6fwEHAmr6ZGOmZaHtilo4okzJXSFYFEl9FnNy45EaiMtdLa X-Received: by 2002:a17:90b:3b51:b0:280:85a:b425 with SMTP id ot17-20020a17090b3b5100b00280085ab425mr5602935pjb.49.1700928511665; Sat, 25 Nov 2023 08:08:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700928511; cv=none; d=google.com; s=arc-20160816; b=no2cxvLWanPSTZd9GT2D8v1dJW57kCzofAQVN10Mv1zSSt98P2yULwdhr+a/MoSBEL a/61CpiSRzGT0aSJe/DcNX8Q24xZO7lvBjGqafZJkMRwd71AYsGWPEMNqp1Xs+7xPuph nrSOWeulYALqh4P8xYqn2LTFga5QFq1Npx4LGNWe79yL3g0mQxYr9lE6Z8lyUF9hw0Xq JMDTLwt3P+g28gyIems2D+C+yY0OfvRnQEfY4JMGe1cMSXZuX8Sbs0Rd90484m2+x6PS ZQV3fpVCiFecU5SAT8KpilPahaJZdEGxNzAw/nK1blXr2+RM72ahUel1jdhsoHnh9Rey HB2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=9RTf+TvE2sTnSyCQRlrOtc0ibfaOSKjgG37Inlp9HQw=; fh=IFLr0RfEdpy4/GeI6HgM4X7ZavR3nZ8IeJF0ZG0s1VI=; b=F1rxOmUQ41IsNRS/75Yl0UQvNCdaa9RSfy8PHh4KiBR2xvLrgbkfEnzXN7epD09mI+ f3kn6BBfvfTHrS7h6W6o/6DZbGFWCGI0T7QXcC8OM2Hih+EnBEySBbfenr0BaTY5boo7 Q3JmheD9RubqSYWgmKkZvVnR/UJkGQyPN+ffhEdv2OmwjT1AlxJ0lQNLG7vYVk9rfWrV rgmT2OJ83xn9lUi8CJrxvhPFBNavIxzy3tqVu1gUihGbQfgr5PpfaDjsQrwzsxOYv/aU KsmDrTXTOt6YfoCE62k2qYSD9mCqNbY+N+uu65PRgQimK9YIbOB9acN2UmW8kVjHCCAa h+eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XK82r4cp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id o2-20020a17090aac0200b00285a910661esi1063923pjq.10.2023.11.25.08.08.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Nov 2023 08:08:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XK82r4cp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7FC938065008; Sat, 25 Nov 2023 08:08:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232273AbjKYQII (ORCPT + 99 others); Sat, 25 Nov 2023 11:08:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232230AbjKYQIG (ORCPT ); Sat, 25 Nov 2023 11:08:06 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F4092 for ; Sat, 25 Nov 2023 08:08:13 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42535C433C7; Sat, 25 Nov 2023 16:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700928493; bh=+JdvZzFz1fUXLr7nCkndqXtxJjfFTBUCZxGIR3myW/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XK82r4cpxnh9hdFs2xGKa0X1tALGw0LxQ1t2THSEhxqG76NMMrS5TELZ2Y7cjfUz1 9x0nQUCp9Gbx4GA2D7xj5X5s2tLvIM9oelKKTxWMFlDOMW+CeVcEhPYFcwkn94DRAE 1ebETkgDslvfycoGPAlUPjmlH8+XVd90RSJYwBW4mRiomWagnPqgOpMWexMGeWsuh/ jQ4SU/Oqbq6i8U5NmgP9ohB2ENdhhxjH6sUnlmJT3snaU8DY1kjbfjxgrDQdmaF2gI FMRXp9V1EXuAHYb6g+EAB8u0TsMRk6R/rA9JrP3l3ZOvcTmnyF9fuQkpEUVUpgv899 ZFZ4wf0DLKpIw== Date: Sat, 25 Nov 2023 16:08:04 +0000 From: Jonathan Cameron To: Marcelo Schmitt Cc: , , , , , , , , , , Subject: Re: [PATCH v2 0/7] Add support for AD7091R-2/-4/-8 Message-ID: <20231125160804.63c30be9@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sat, 25 Nov 2023 08:08:23 -0800 (PST) On Thu, 23 Nov 2023 13:29:12 -0300 Marcelo Schmitt wrote: > From: Marcelo Schmitt > > This series adds support for AD7091R-2/-4/-8 ADCs which can do single shot > or sequenced readings. Threshold events are also supported. > Overall, AD7091R-2/-4/-8 are very similar to AD7091R-5 except they use SPI interface. > > This has been tested with raspberrypi and eval board on kernel 6.1 from ADI fork. > Link: https://wiki.analog.com/resources/tools-software/linux-drivers/iio-adc/ad7091r8 > > I ran get_maintainers on driver files but completely forgot to run it on the > yaml doc, my bad. > I made the changes requested so far. > For v2, I also ran dt_binding_check on iio testing branch to check out for any > additional dt-schema issues. None reported. > Didn't see any other warn after running Sparse, Smatch, and Coccicheck. > I get a warn from checkpatch about IIO_DMA_MINALIGN which I don't know how to fix :( Fix checkpatch :) It has some exclusions for some of the warnings so probably look at what was added to avoid issues with __cacheline_aligned and friends. https://elixir.bootlin.com/linux/latest/source/scripts/checkpatch.pl#L515 > > Change log v1 -> v2: > - Added device tree related To/Cc recipients. > - Removed extra print of error code > - $ref: "adc.yaml" -> $ref: adc.yaml > - Fixed defined but not used build warn > - Moved dt documentation of required properties to after patternProperties. > - Removed incorrect return before regmap_update_bits(). > > Marcelo Schmitt (7): > iio: adc: ad7091r-base: Set alert config and drvdata > MAINTAINERS: Add MAINTAINERS entry for AD7091R > iio: adc: ad7091r: Move defines to header file > iio: adc: ad7091r: Alloc IIO device before generic probe > dt-bindings: iio: Add binding documentation for AD7091R-8 > iio: adc: Add support for AD7091R-8 > iio: adc: ad7091r-base: Add debugfs reg access > > .../bindings/iio/adc/adi,ad7091r8.yaml | 101 +++++++ > MAINTAINERS | 12 + > drivers/iio/adc/Kconfig | 16 ++ > drivers/iio/adc/Makefile | 4 +- > drivers/iio/adc/ad7091r-base.c | 114 +++++--- > drivers/iio/adc/ad7091r-base.h | 64 ++++- > drivers/iio/adc/ad7091r5.c | 55 ++-- > drivers/iio/adc/ad7091r8.c | 270 ++++++++++++++++++ > 8 files changed, 549 insertions(+), 87 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7091r8.yaml > create mode 100644 drivers/iio/adc/ad7091r8.c >