Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1958142rdh; Sat, 25 Nov 2023 08:19:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IHsn1slMFmkfh6WQWSJVYblIfAyd/zguay1JvLF3dP2hjtc8fcwOF/fd8hxAPbCscr5IlVs X-Received: by 2002:a05:6a20:d809:b0:186:7988:c747 with SMTP id iv9-20020a056a20d80900b001867988c747mr8193737pzb.19.1700929140196; Sat, 25 Nov 2023 08:19:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700929140; cv=none; d=google.com; s=arc-20160816; b=svWuwCEtfdSzx9rCOnByNBTTyjHThf8ceKUVYFCTgOvkFhbgFxUiuN+BtlQBDcR3KO RLY93zn9MpkgeRSIA1Xj6LiV8G0P9SDkb1iQr/sC/36TnJt9sj1DzwvmbzbXRWWzTQ/L NVKzIwt9TFW2ofoII8IbQ/lYy6JHIPtju8pcF3wRYsKfjQ3XMC0XiuZ+ZfPHEFQlRh3E NvDKppISf9IB0BQli8TW/DEmVyvJcfXTIPmLG68j5KidvL0v/DkMGZFF6Mh90Fk8/Mw1 X2FZ3thX8hvaw9K9gCQh884v/zpI1bYZf0dxI5B6awNclaDbEzoQFECdBaHsMr/ZA5xf fWGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=hScmJU/T9adCW5qAiAIGKK5EkHg0MQ6i5UkekOAvSkI=; fh=ESPtyGfxO2/njBQIL8vjsGAP9XGYUG/mWqSAPV+GTUY=; b=tLA/BSs+gAcSYU9iJfdeb95QHErsa7akSQBZVvOc+hYzHIkpycoZ1Hqv4IBfEnAimB 4YIv0JEIeLmkRStT6sFftNPNbYw5wibnoMA6BQbe9N28WOh41BuGatHje0UtkLdwg+Az 7O9Spvv8GsRwn0jFpufBya26DQZvqAEa20VErctGiwrDsN86n0/NpX2mxK5H8LwSuDIB eKfbRZKqZbSWJLv0hKaw32U4yxJ5oFPDDvMcg4XDUdTW0HomJ8ahQiM3oDRny5D+hu8S us5ZcyfWT2I6p9HiRqnF+kPw5/YGybzDMVaE6Zop9np4J/Pua4sxSm9f/HLCZtOv7Koy Ytiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GL9xjaOo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id f14-20020a056a0022ce00b0069026fd5a48si6001236pfj.34.2023.11.25.08.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Nov 2023 08:19:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GL9xjaOo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D0FA0805AA17; Sat, 25 Nov 2023 08:18:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232177AbjKYQSn (ORCPT + 99 others); Sat, 25 Nov 2023 11:18:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230030AbjKYQSm (ORCPT ); Sat, 25 Nov 2023 11:18:42 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49602EA for ; Sat, 25 Nov 2023 08:18:49 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A391FC433C8; Sat, 25 Nov 2023 16:18:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700929128; bh=EaJyO/m/g95FBqHOnwDYmQe9cCbHuHP/FAMaf64auWU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GL9xjaOocUk1p+2gflGqmQOHjTDo0GoY+YUdrHJ1AGTVPLf2bb2Ad/eDPVZ2jtO2S RWpiKE4LKp6phybeeWXs8YImvTo/37vnEJpWLlpFuDtwadZW+irt8l0W5DHA+rVkCp 2bp/S+H5BZvt8ltzxzlnuI3x8AuO/4ZH+m+UcoztmHadWp5bXNSBBkv9j6p0vW1f10 A5MDzwbZBw7MIObnGxKxslxWZfedHzaa7nCbtSLC0/aRjQAQq0PAf/E8HlABguFeV0 fl7tI6xv/Tf3nf1Q3yhSM/H8TrYbO556omM+ajUZHQIUHdd2oRI4DvucXgEsINDhQq wQcOJXvz4rVjA== Date: Sat, 25 Nov 2023 16:18:39 +0000 From: Jonathan Cameron To: Marcelo Schmitt Cc: , , , , , , , , , Subject: Re: [PATCH v2 3/7] iio: adc: ad7091r: Move defines to header file Message-ID: <20231125161839.74129fc2@jic23-huawei> In-Reply-To: <60e3914b06997ecb8a153170602272f63c579c57.1700751907.git.marcelo.schmitt1@gmail.com> References: <60e3914b06997ecb8a153170602272f63c579c57.1700751907.git.marcelo.schmitt1@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 25 Nov 2023 08:18:58 -0800 (PST) On Thu, 23 Nov 2023 13:41:28 -0300 Marcelo Schmitt wrote: > Move AD7091R register, channel and event definitions to the header file > so other AD7091R device drivers may use those declaration in follow up > patches. Hi, This is moving stuff into the base.c file as well, but the patch description doesn't talk about that or the exports added. It should describe those parts. Looks good otherwise - one trivial comment below. Jonathan > > Signed-off-by: Marcelo Schmitt > diff --git a/drivers/iio/adc/ad7091r-base.h b/drivers/iio/adc/ad7091r-base.h > index 509748aef9b1..6ff539cd1d39 100644 > --- a/drivers/iio/adc/ad7091r-base.h > +++ b/drivers/iio/adc/ad7091r-base.h > @@ -8,6 +8,27 @@ ... > > +bool ad7091r_volatile_reg(struct device *dev, unsigned int reg); > + Trivial but I'd not have a blank line here. > +bool ad7091r_writeable_reg(struct device *dev, unsigned int reg); > + > #endif /* __DRIVERS_IIO_ADC_AD7091R_BASE_H__ */