Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1993782rdh; Sat, 25 Nov 2023 09:28:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCEX+kwxuG2g/AfbW9bn7i6OZL14pl9whuZmOgvIy9s5CRB2fJqt1D5sGqpIqyTmJzpeZI X-Received: by 2002:a17:902:e546:b0:1cc:6cc7:e29f with SMTP id n6-20020a170902e54600b001cc6cc7e29fmr6829249plf.43.1700933296470; Sat, 25 Nov 2023 09:28:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700933296; cv=none; d=google.com; s=arc-20160816; b=sa6Ba9Zfeu7cx9UMkmpoy5m0MfQvam2sGPb757Vc4bhaBMt+rRAOPpzsvzup1E5kTo +MD/TCW+axE3JFbN0fOEesZ0PqMm5J/BIz+5yc+6Egp1tnGHd1M8AQsoG5ilzh3e08/Q R7AkdY8h6iuEu5ALpWXNX4qWufQXZlG7ogWIMbZlHEeqCRM3Nn5aTwRJz+srsCdSGqbj zn8flLUHGUTqBEhEkh3DYmRqLRCWoNJ7qUJDEAsZ38ojBWFpvLsAIXg+/NZwHpBcWDyT M3DOLTOvPf3s4E4kCvzFRQYrQe6/0MwysjnWQyht2PGTqQkN+LjtAZe66sx89ZCLrnRv 9MyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=hIgEVeZRQHqUseM68mIrjBFCMsbXd5ckMinhgCxpwyk=; fh=PttlPJILJJ4nJYFIytTfnEtoLJlvvvWPqAQ6PI5sdlQ=; b=QQuMCwiTyWiGxY6TzQ1NOqV8NOzIkjFboVz7PanKlMAiiqjoGNhS9Fh/sfsA7F8jjK IaTRm3/+3pGHMJosagEqMY6aFMPinPzPfX/kYs2GvofkdllDlmsyvbQhArMnLCoVnLoj bKc5iQvTpsy83b7/VCGkNAAYXjUkyrOXLBNBixghvbtPnGFchrtgb95oaW8djptG3/Q6 sr3xIjVTBAXUVSoX2oKphqvoH6SgD1ehFZ3vUQC3oFzbzcYYbFTyxD9BJb+6qD0+uFoz WCh+NsKTqKgU4alDox0dgWHMwKCNzZsiNepwghZHZ13qMSUfYkCoEt7+UAAViNpYk91p k0QQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SbQK1jgy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id c5-20020a170903234500b001cf5d4fba4dsi6337540plh.320.2023.11.25.09.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Nov 2023 09:28:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SbQK1jgy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 0DB698065303; Sat, 25 Nov 2023 09:28:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbjKYR2A (ORCPT + 99 others); Sat, 25 Nov 2023 12:28:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229653AbjKYR17 (ORCPT ); Sat, 25 Nov 2023 12:27:59 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50334127 for ; Sat, 25 Nov 2023 09:28:06 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20319C433C8; Sat, 25 Nov 2023 17:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700933285; bh=SdEIJH9TzgPXfaP1Q2Dpkp+FAEfYhe/GjdmyR7hDB+Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SbQK1jgydoMznxVji1B2PXND/RwJ/X1wxjP/8wICn9krvA2d74vnYLrabHpMu0QjE Rm5m3ybwhM1S+daLt0AqhBj1djVoe8E4wjf+6AvOvNc1eSN8gpLg61hyTIDwxDXUdE Xfc4mqe5jESNPIgeOoKq3vJeRx/T9Zk8rxc86d1gp8LIWGMzyZxxYdAfAZG9w8nh9v RAfM0aUsTPMR5rFn77Tm0AcIT/9KHHcftFqu4pT15XB+PaRuzMye0bsnc4jXMar2UQ N2U/0YS1Bxm4W3uzGLZENfXGmj01l9ev3ZY6QoIqnwev29aR4mArPjcn3xjBJN9F25 ATwXeUnNLoCwQ== Date: Sat, 25 Nov 2023 17:27:58 +0000 From: Jonathan Cameron To: Krzysztof Kozlowski Cc: Crt Mori , Rob Herring , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/2] dt-bindings: iio: temperature: add MLX90635 device bindings Message-ID: <20231125172758.04b0254e@jic23-huawei> In-Reply-To: References: <2e8b4a7d3ef4bc1c53bd0a849e4c31eaf2477f6b.1700648165.git.cmo@melexis.com> <99d1808a-da04-4bc1-a1f7-cbd269adbbf0@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sat, 25 Nov 2023 09:28:14 -0800 (PST) On Wed, 22 Nov 2023 13:35:19 +0100 Krzysztof Kozlowski wrote: > On 22/11/2023 13:28, Crt Mori wrote: > >>> + Since measured object emissivity effects Infra Red energy emitted, > >>> + emissivity should be set before requesting the object temperature. > >>> + > >>> +properties: > >>> + compatible: > >>> + const: melexis,mlx90635 > >> > >> It's the same as mlx90632. Add it there (as enum). > >> > > > > Properties are the same, but then you can't have much differences for > > a temperature sensor. It has a bit worse relative measurement error > > outside of the human body range and overall different DSP, register > > map, even physical size - it's 1.8x1.8 mm compared to 90632 3x3 mm. I > > was not sure how it qualifies for adding it as another enum, but I > > went with the feeling that if it can reuse the driver, then it is an > > enum, otherwise it is a new file. And I could not reuse anything from > > 90632. > > > > Thanks for quick feedback and best regards, > > Driver is independent choice. There is no need for new binding file if > everything is the same from bindings point of view. > > Best regards, > Krzysztof > > We got this wrong in the past in IIO and it's a slow effort to merge the various very similar bindings. For now we are mostly keeping to within a vendor though unless a driver supports parts from multiple vendors. It potentially gets too confusing to maintain otherwise. This one is easy case though so definitely merge as Krzystof suggested! Jonathan