Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Sat, 25 Nov 2023 16:39:44 -0600
From:   Jeff LaBundy <jeff@labundy.com>
To:     Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>
Cc:     Anshul Dalal <anshulusr@gmail.com>, linux-input@vger.kernel.org,
        devicetree@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        linux-kernel-mentees@lists.linuxfoundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] input: joystick: driver for Adafruit Seesaw
 Gamepad
Message-ID: <ZWJ3sFfrVQA3djmi@nixie71>
References: <20231027051819.81333-1-anshulusr@gmail.com>
 <20231027051819.81333-2-anshulusr@gmail.com>
 <d1dd2142-546f-42b7-8966-ab75fd4f8817@t-8ch.de>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d1dd2142-546f-42b7-8966-ab75fd4f8817@t-8ch.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?bG9E84EpC2FUR3qvcvhyQ/gKOfxlfgvVKuQC8p72HGlGVwUdHWa1x+0MwQ?=
 =?iso-8859-1?Q?Dme/m96Tugaz+qIxN+iCJkPNaRS7Q0irTAV6NFde1LIbS7zyDe21bd0Juk?=
 =?iso-8859-1?Q?beJNYOms+VX+VdiscV5oQ6cI/zdosiduF62UiSlsQqENzYICzw4wCrZW4/?=
 =?iso-8859-1?Q?QsOfMo8yQVdcVCOQkJbqRQAJu4fn8dG17Z/5aRcfbpDerjxC8BWa1tzcXx?=
 =?iso-8859-1?Q?f4uoBCraOUMlNKYjThvJb4rlt32/t0jvB72thtHXEj4zcxU0AHvcLqsX2w?=
 =?iso-8859-1?Q?8cILi9d4FVMiAw65qhXvxUnGCWly+rXiAqyCbQXVgbcKOdWhpuX5DIpHQf?=
 =?iso-8859-1?Q?GHSDoRfCYh7eS4L09k/ahZbPylZ5a0ALsHqi5b42pn8XU+z2Hu9S5XM9Wm?=
 =?iso-8859-1?Q?xSnnwglDQqUQZ416fjzC2vnDrreZCLvITX9wONFeAt5uwNZyvKckiaHIHg?=
 =?iso-8859-1?Q?xSxuIjuHBUtbglpZlaUf9dmznBdE3DqEzERKYzYXc5zYfLDOfACHlMztho?=
 =?iso-8859-1?Q?iDpTecp3jYCnOjjlWr2jk+3uHaWfJ9+GMTWC5zFr0zhKp4KfWAiAXNhRjX?=
 =?iso-8859-1?Q?+VEg3h7j1kHOyFjT2ii1pr3rS6Uu7pJjdR3t5AvwlIAQmesCN/mjP0QyCp?=
 =?iso-8859-1?Q?ZK5p8LcTgNDwAhAR49pCB38FsrnBPsM0KjjYdIGQmzH7hzV5skiMcUAsnd?=
 =?iso-8859-1?Q?WAsg8Wrtoc02xRh3SNCSxTNAWWC3rpLFgST6OfzRZf5xRmQj+xPf0We5QP?=
 =?iso-8859-1?Q?JZsrQdyAlxS/81R2GsnHrqAqULN1afv/0anr3b/BQ9N1JvwE1pz5kdMj0s?=
 =?iso-8859-1?Q?P3iqMnS2zy01NnDQIP4cVFO/iy8xzCp2Wl8lrp6fCgcmyqJNnyJfona8Go?=
 =?iso-8859-1?Q?pco1i0GD5LWqOUH+T+5nqgUjiiHuyuwweA8xEKBm4eZ1iX5ADwk5uX0VqV?=
 =?iso-8859-1?Q?WmuyH+D0SnQqzxZBXYJuJR2F3o/AXqqvqo4MbZKgaxaQqc6sK5Cz75NF2T?=
 =?iso-8859-1?Q?q95JBqAw8Keu8eTZUBzd9ibnwRzbgY3eZMSk8ykhEU+KA9PkrEeTPs48aE?=
 =?iso-8859-1?Q?jjN5+kT2G9I+iySZ0vF4jFTNE2M+JWpl2lmkm67Zr6FrH0ijrg2zxu4WzC?=
 =?iso-8859-1?Q?dsYxMTG8QPhSIStMS8q120hxmK6ILkl3R9HQF3AYJKTGHz8IsJvi9qKGid?=
 =?iso-8859-1?Q?y0+A3noG/qR7E6q+BEwlXxf00Z13hX2nqjLQgZm2vaTS1hk1H88X3FpIHM?=
 =?iso-8859-1?Q?2WhvWaXqjSliqqa/lPoOWaLLyYo+hJjI2bSLYshAZHGiX6r9pBlML9VSbL?=
 =?iso-8859-1?Q?hCAbQcUsbzMRK64+Ph1nYs3zc6BjijanCIXzE0D1iWGL2Xv43bJhEF6r1e?=
 =?iso-8859-1?Q?qPlP1HGgOLKxkUQwWLgR7QxnxJiORiLJu4WD3s5OvAcz27azCh2f/HgTyp?=
 =?iso-8859-1?Q?Jmk8okUJe0KIYZEiR3mWd5TsMMibRWtZ4V/f9txWB4WdfLfDLFj1gu+niv?=
 =?iso-8859-1?Q?7GfS7RsoMaUEq2CXalLT6EzjS5jNCXBY5ZZaEzWPjzHo/bflAlqMhmqrvi?=
 =?iso-8859-1?Q?evwUSMMNVJMBAsME2uIp1dwwOBF7yoMYGHL+spuhBXJXzNHxWCMRUdmoTW?=
 =?iso-8859-1?Q?3Lmb8FJkXwSJG/Y5ezt6uZPwkYTuRTbmYX?=
X-OriginatorOrg: labundy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b7fc18b-73e4-4e5d-5c71-08dbee076da5
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2023 22:39:47.6645
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wj7QxmTzqplEy0Xx2bCXRQcSdE7KYzZY7dfPoHnBlmLpPuCTY5l4QQAruGChyYdkBVIq+kos21c/PoK8kZfFgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR08MB7256
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sat, 25 Nov 2023 14:40:02 -0800 (PST)

Hi Thomas and Anshul,

On Fri, Oct 27, 2023 at 06:14:58AM +0000, Thomas Wei?schuh wrote:

[...]

> > +struct seesaw_data {
> > +	__be16 x;
> > +	__be16 y;
> 
> The fact that these are big endian is now an implementation detail
> hidden within seesaw_read_data(), so the __be16 can go away.
> 
> > +	u32 button_state;
> > +} __packed;
> 
> While this was requested by Jeff I don't think it's correct.
> The struct is never received in this form from the device.
> I guess he also got confused, like me, by the fact that data is directly
> read into the fields of the struct.

Apologies for some confusion on my part here; Thomas is correct and
my comment can be disregarded. Originally I thought this struct was
mapped to a continguous range of registers, but after studying the
documentation some more, that is clearly not the case :)

Kind regards,
Jeff LaBundy