Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762436AbXK2KaE (ORCPT ); Thu, 29 Nov 2007 05:30:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751662AbXK2K3v (ORCPT ); Thu, 29 Nov 2007 05:29:51 -0500 Received: from mail.suse.de ([195.135.220.2]:33292 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbXK2K3u (ORCPT ); Thu, 29 Nov 2007 05:29:50 -0500 To: Vegard Nossum Cc: linux-kernel@vger.kernel.org Subject: Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2) References: <474C34CC.6060509@gmail.com> From: Andi Kleen Date: 29 Nov 2007 11:29:48 +0100 In-Reply-To: <474C34CC.6060509@gmail.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 17 Vegard Nossum writes: > > - We properly flush TLB entries that change. This used to not be the case, and so we For low values of "properly" @) > + pte = lookup_address(addr); > + change_page_attr(page, 1, __pgprot(pte->pte_low | _PAGE_VISIBLE)); > + __flush_tlb_one(addr); That's not enough, you need to flush all CPUs. Also when you don't call global_flush_tlb() eventually because c_p_a() will leak flush objects over time. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/