Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231124101619.6470-1-hkallweit1@gmail.com> <20231124101619.6470-11-hkallweit1@gmail.com>
In-Reply-To: <20231124101619.6470-11-hkallweit1@gmail.com>
From:   jim.cromie@gmail.com
Date:   Sat, 25 Nov 2023 23:03:35 -0700
Message-ID: <CAJfuBxw4=Aku32yx3e0zbTCARSo9r1ST71UoaC-Dp3K3_m44jQ@mail.gmail.com>
Subject: Re: [PATCH v2 10/10] i2c: scx200_acb: Don't let i2c adapters declare
 I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Wolfram Sang <wsa@kernel.org>, linux-i2c@vger.kernel.org,
        Andi Shyti <andi.shyti@kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Nov 24, 2023 at 3:16=E2=80=AFAM Heiner Kallweit <hkallweit1@gmail.c=
om> wrote:
>
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>

Acked:


> ---
>  drivers/i2c/busses/scx200_acb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_=
acb.c
> index 83c1db610..3648382b8 100644
> --- a/drivers/i2c/busses/scx200_acb.c
> +++ b/drivers/i2c/busses/scx200_acb.c
> @@ -427,7 +427,7 @@ static struct scx200_acb_iface *scx200_create_iface(c=
onst char *text,
>         snprintf(adapter->name, sizeof(adapter->name), "%s ACB%d", text, =
index);
>         adapter->owner =3D THIS_MODULE;
>         adapter->algo =3D &scx200_acb_algorithm;
> -       adapter->class =3D I2C_CLASS_HWMON | I2C_CLASS_SPD;
> +       adapter->class =3D I2C_CLASS_HWMON;
>         adapter->dev.parent =3D dev;
>
>         mutex_init(&iface->mutex);
>