Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Sun, 26 Nov 2023 10:05:52 +0100
From:   Andrea Righi <andrea.righi@canonical.com>
To:     Tejun Heo <tj@kernel.org>
Cc:     torvalds@linux-foundation.org, mingo@redhat.com,
        peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org,
        joshdon@google.com, brho@google.com, pjt@google.com,
        derkling@google.com, haoluo@google.com, dvernet@meta.com,
        dschatzberg@meta.com, dskarlat@cs.cmu.edu, riel@surriel.com,
        changwoo@igalia.com, himadrics@inria.fr, memxor@gmail.com,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        kernel-team@meta.com
Subject: Re: [PATCH 12/36] sched_ext: Implement BPF extensible scheduler class
Message-ID: <ZWMKcPXIAuJ22Q+i@gpd>
References: <20231111024835.2164816-1-tj@kernel.org>
 <20231111024835.2164816-13-tj@kernel.org>
 <ZV8IR/w4IaxJ2vPA@gpd>
 <ZWJSL15eCe0aXnZe@mtj.duckdns.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZWJSL15eCe0aXnZe@mtj.duckdns.org>
Precedence: bulk

On Sat, Nov 25, 2023 at 09:59:43AM -1000, Tejun Heo wrote:
> Hello,
> 
> On Thu, Nov 23, 2023 at 09:07:35AM +0100, Andrea Righi wrote:
> > On Fri, Nov 10, 2023 at 04:47:38PM -1000, Tejun Heo wrote:
> ...
> > > +#ifdef CONFIG_SCHED_CLASS_EXT
> > > +	p->scx.dsq		= NULL;
> > > +	INIT_LIST_HEAD(&p->scx.dsq_node);
> > > +	p->scx.flags		= 0;
> > > +	p->scx.weight		= 0;
> > > +	p->scx.sticky_cpu	= -1;
> > > +	p->scx.holding_cpu	= -1;
> > > +	p->scx.kf_mask		= 0;
> > > +	atomic64_set(&p->scx.ops_state, 0);
> > 
> > We probably need atomic_long_set() here or in 32-bit arches (such as
> > armhf) we get this:
> > 
> > kernel/sched/core.c:4564:22: error: passing argument 1 of ‘atomic64_set’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> >  4564 |         atomic64_set(&p->scx.ops_state, 0);
> >       |                      ^~~~~~~~~~~~~~~~~
> >       |                      |
> >       |                      atomic_long_t * {aka atomic_t *}
> > 
> ...
> > > +static void set_next_task_scx(struct rq *rq, struct task_struct *p, bool first)
> > > +{
> > > +	if (p->scx.flags & SCX_TASK_QUEUED) {
> > > +		WARN_ON_ONCE(atomic64_read(&p->scx.ops_state) != SCX_OPSS_NONE);
> > 
> > Ditto. Even if this line is replaced later by
> > "[PATCH 31/36] sched_ext: Implement core-sched support"
> > 
> > > +		dispatch_dequeue(&rq->scx, p);
> > > +	}
> > > +
> > > +	p->se.exec_start = rq_clock_task(rq);
> > > +}
> 
> Sorry about that. I updated them and will include the changes in the next
> iteration. Will test 32bit build too next time.
> 
> Thanks.

No problem, if you don't I'll test it for you. :)

-Andrea