Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Received-SPF: pass (mx2fc6: connection is authenticated)
Message-ID: <c7a38307ac74a973e26ac820a0b98773262720bd.camel@bigler.one>
Subject: Re: spi: imx: Increase imx51 ecspi burst length fails on imx6dl and
 imx8mm
From:   Benjamin Bigler <benjamin@bigler.one>
To:     benjamin@bigler.one
Cc:     broonie@kernel.org, francesco@dolcini.it,
        linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
        linux@bigler.io, regressions@lists.linux.dev,
        stefan.moring@technolution.nl
Date:   Sun, 26 Nov 2023 14:19:56 +0100
In-Reply-To: <d795999676663a576f12f07a7013bee758fb781c.camel@bigler.one>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.0
MIME-Version: 1.0
Precedence: bulk

Hi

I did some debugging and I think the problem is that in this case bits_per_=
word is 8. So in
spi_imx_dma_configure the buswidth is set to DMA_SLAVE_BUSWIDTH_1_BYTE. But=
 in
mx51_ecspi_prepare_transfer the BURST_LENGTH is now set to (spi_imx->count =
* spi_imx->bits_per_word
- 1)
before 15a6af94a2779d5dfb42ee4bfac858ea8e964a3f it was (spi_imx->bits_per_w=
ord - 1). Now the spi
transmits 4 byte per byte except for the first word. I added the following =
patch and it worked again

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 498e35c8db2c..f514966e2ada 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -659,11 +659,22 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx=
_data *spi_imx,
 		ctrl |=3D (spi_imx->target_burst * 8 - 1)
 			<< MX51_ECSPI_CTRL_BL_OFFSET;
 	else {
-		if (spi_imx->count >=3D 512)
-			ctrl |=3D 0xFFF << MX51_ECSPI_CTRL_BL_OFFSET;
-		else
-			ctrl |=3D (spi_imx->count * spi_imx->bits_per_word - 1)
+		if (spi_imx->usedma)
+			ctrl |=3D (spi_imx->bits_per_word *
+					 spi_imx_bytes_per_word(
+						 spi_imx->bits_per_word) -
+				 1)
 				<< MX51_ECSPI_CTRL_BL_OFFSET;
+		else {
+			if (spi_imx->count >=3D MX51_ECSPI_CTRL_MAX_BURST)
+				ctrl |=3D (MX51_ECSPI_CTRL_MAX_BURST - 1)
+					<< MX51_ECSPI_CTRL_BL_OFFSET;
+			else
+				ctrl |=3D (spi_imx->count *
+						 spi_imx->bits_per_word -
+					 1)
+					<< MX51_ECSPI_CTRL_BL_OFFSET;
+		}
 	}
=20
 	/* set clock speed */

Best regards,
Benjamin Bigler